[RESOLVED] How do I change this line to urlencode?

[needinghelpasap]

So how would I change this complete header using urlencode?

header("Location:messagepayment.php?messageonelineone={$messageonelineone}&messageonelinetwo={$messageonelinetwo}&messagetwolineone={$messagetwolineone}&messagetwolinetwo={$messagetwolinetwo}&colourone={$colourone}&colourtwo={$colourtwo}&font={$font}&package={$package}&amount={$amount}");

[laserlight]

You would write something like this:

$uri = rtrim(dirname($_SERVER['PHP_SELF']), '/\\');
header('Location: http://' . $_SERVER['HTTP_HOST'] . $uri . '/messagepayment.php'
    . '?messageonelineone=' . urlencode($messageonelineone)
    . '&messageonelinetwo=' . urlencode($messageonelinetwo)
    . '&messagetwolineone=' . urlencode($messagetwolineone)
    . '&messagetwolinetwo=' . urlencode($messagetwolinetwo)
    . '&colourone=' . urlencode($colourone)
    . '&colourtwo=' . urlencode($colourtwo)
    . '&font=' . urlencode($font)
    . '&package=' . urlencode($package)
    . '&amount=' . urlencode($amount));

Notice that the URL sent for the location header is an absolute URL.

[iceomnia]

Try this:

<?php

function FormatData($data)
{
	// Initialise output variable
	$output = "";

	// Step through the fields
	foreach($data as $key => $value)
	{
		// Stick them together as key=value pairs (url encoded)
		$output .= "&" . $key . "=". urlencode($value);
	}

	// Kludge to take out the initial &
	$output = substr($output,1);

	// Return the output
	return $output;
}

// First, let's start with an array:

$array = array();
$array['var_1'] = 'varone_value';
$array['var_2'] = 'vartwo_value';
$array['var_3'] = 'varthree_value';
// And so on...

// Next, 
$data = FormatData($array);

$url = "messagepayment.php?".$data;

header("Location: ".$url); 
?>

[laserlight]

Using an array makes for reusable code, but again, note that the URL should be an absolute URL. Furthermore, the separator should be escaped to & instead of just &.

[needinghelpasap]

The last one works thanks 🙂 Now my information is being read from one page to the next what do I type to display a particular variable i.e. messageonelineone?

[laserlight]

Now my information is being read from one page to the next what do I type to display a particular variable i.e. messageonelineone?

You would use $_GET['messageonelineone']. By the way, using sessions might be a better way of doing this.

[needinghelpasap]

My system to add a custom order consists of four PHP pages.

The first is a form to add the custom order.
The second is code that passes the information from the first page to the third page, as seen below:

<?php
	session_start();
	require "connect.php";

function FormatData($data) 
{ 
    // Initialise output variable 
    $output = ""; 

    // Step through the fields 
    foreach($data as $key => $value) 
    { 
        // Stick them together as key=value pairs (url encoded) 
        $output .= "&" . $key . "=". urlencode($value); 
    } 

    // Kludge to take out the initial & 
    $output = substr($output,1); 

    // Return the output 
    return $output; 
} 

$customerorder = array();
$customerorder['messageonelineone'] = $_GET['messageonelineone'];
$customerorder['messageonelinetwo'] = $_GET['messageonelinetwo'];
$customerorder['messagetwolineone'] = $_GET['messagetwolineone'];
$customerorder['messagetwolinetwo'] = $_GET['messagetwolinetwo'];
$customerorder['colourone'] = $_GET['colourone'];
$customerorder['colourtwo'] = $_GET['colourtwo'];
$customerorder['font'] = $_GET['font'];
$customerorder['package'] = $_GET['package'];
$customerorder['amount'] = $_GET['amount'];
$customerorder['amount2'] = $_GET['amount2'];

$data = FormatData($customerorder); 

$url = "messagepayment.php?".$data; 

header("Location: ".$url); 
?> 

The third form is to read and display the information. I currently am declaring this at the top of the page:

<?php
	session_start();
	require "connect.php";
	?>
<?php
	if (isset ($_SESSION['customerorder'])){ ?>

Then for each input I am using this code:

<?=$_SESSION['customerorder'][$key]['messageonelineone']?>

Is this right or should I declare the session at the top?

As currently nothing is being displayed and the code throws out the else statement.

[rsmith]

messageonelineone would be your key so it would be:

<?
     echo $_SESSION['customerorder']['messageonelineone'];
?>

[iceomnia]

Hi again,

You know, I have hundreds of bookmarked sites that I show my students, but this is one I reference for my lectures, it really does give you a good understanding of PHP Sessions:

http://www.phpriot.com/articles/intro-php-sessions

(I hope there's no regulations on this forum about posting links to other sites, if there is please remove it and accept my apologies)

[laserlight]

You know, I have hundreds of bookmarked sites that I show my students, but this is one I reference for my lectures, it really does give you a good understanding of PHP Sessions:

http://www.phpriot.com/articles/intro-php-sessions

Looks good, though I note that that article recommends session_unset(), but the PHP manual states that session_unset() should only be used "for older deprecated code that does not use $SESSION". Instead, $SESSION should be set to array(), the session cookie should be deleted and then session_destroy() should be called.

I hope there's no regulations on this forum about posting links to other sites, if there is please remove it and accept my apologie

There are regulations against advertisement, but not against links to PHP articles.