[RESOLVED] A syntax error?

mhodge87

Now I've used this snippet of code, but this time its giving me an error and I can't seem to find out. Here is my query:

$title = trim($_POST['title']);
$desc = trim($_POST['description']);
$img = trim($_POST['imgsrc']);
$edate = trim($_POST['edate']);
$timeh = trim($_POST['timeh']);
$timem = trim($_POST['timem']);
$timez = trim($_POST['timez']);
$cic =$_POST['cic'];

//Query

$sql = sprintf("INSERT INTO jos_events (NAME, IMG, DESC, DATE, TIMEH, TIMEM, TIMEZ, CIC) VALUES('%s', '%s', '%s', '%s', '%s', '%s', '%s')", 
               mysql_real_escape_string($title, $con), 
               mysql_real_escape_string($img, $con), 
               mysql_real_escape_string($desc, $con),
               mysql_real_escape_string($edate, $con),  

               mysql_real_escape_string($timeh, $con), 
               mysql_real_escape_string($timem, $con), 
               mysql_real_escape_string($timez, $con), 
               mysql_real_escape_string($cic, $con));

When I mysql_query it it says there is an error in the sprintf syntax. I can't find it for the life of me. Here are my values for the above values

"Test",
"www.blah.com"
"This is a test",
"03/10/08",
"00",
"15",
"Z",
"Michael Hodge (961044)"

Now here is what i've done to test this myself. I've echoed each of those variables and its outputting the text box inputs for each thing. So its acutally submitting to the script. I've tried taking out the "Michael Hodge (961044)" because I thought maybe the parenthisis were throwing it off, but still same thing. i've compared the syntax to another script that submits into a similar table, and i've compared the two and coulden't find anything. lol. Its probally some stupid comma or something somewhere that I can't see.

-Mike

laserlight

Look carefully:

(NAME, IMG, DESC, DATE, TIMEH, TIMEM, TIMEZ, CIC)
('%s', '%s','%s', '%s', '%s',  '%s',  '%s')

mhodge87

Ah yes I was missing the '%s', I've added it in and I still get the error

My code now looks like,

$sql = sprintf("INSERT INTO jos_events (NAME, IMG, DESC, DATE, TIMEH, TIMEM, TIMEZ, CIC) VALUES('%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s')", 
               mysql_real_escape_string($title, $con), 
               mysql_real_escape_string($img, $con), 
               mysql_real_escape_string($desc, $con),
               mysql_real_escape_string($edate, $con),  

               mysql_real_escape_string($timeh, $con), 
               mysql_real_escape_string($timem, $con), 
               mysql_real_escape_string($timez, $con), 
               mysql_real_escape_string($cic, $con));

mhodge87

There was an error preforming the query: INSERT INTO jos_events (NAME, IMG, DESC, DATE, TIMEH, TIMEM, TIMEZ, CIC) VALUES('Add controller to roster', 'http://www.trescoconsoles.com/images/tracon/tracon-dt-1.jpg', '', '05/27/87', '10', '15', 'Z', 'Michael Hodge (961044)'

Error:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'DESC, DATE, TIMEH, TIMEM, TIMEZ, CIC) VALUES('Add controller to roster', 'http:/' at line 1

Thats the Error

laserlight

What's the error message?

EDIT:
Okay, what is the relevant database schema?

mhodge87

ID int(11) (auto incrementing and set as primary)
NAME text
IMG text
DESC text
DATE char(8)
TIMEH int(2)
TIMEM int(2)
TIMEZ char(1)
CIC text

laserlight

Okay, I suspect the problem is that DESC is a keyword. Since this is MySQL, quote it with backquotes to DESC.

mhodge87

ah ha! it has been fixed, thank you very much! ok, so is it good practice to put `` around all my fields? like:

$sql = sprintf("INSERT INTO jos_events (NAME, IMG, DESC, DATE, TIMEH, TIMEM, TIMEZ, CIC)

laserlight

ok, so is it good practice to put `` around all my fields?

That's debatable. On one hand, it avoids errors like what you just experienced. On the other hand, it could add unnecessary characters to read and the backticks are peculiar to MySQL anyway (other SQL dialects use double quotes and/or brackets).

mhodge87

ok, well i'll grab a list of mysql keywords and if i use them in my tables i'll be sure to put them in the backquotes. Thanks again.