Is the problem me or my machine with this code ?

pufftissue

<!DOCTYPE html PUBLIC
"-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>hit counter from scratch</title>
<link rel="stylesheet" href="#" type="text/css" />
<meta http-equiv="content-type"
content="text/html; charset=iso-8859-1" />
</head>
<body>


$hit = file_get_contents("numberOfHits.txt");

if (file_exists("numberOfHits.txt"))
{
	$hit = file_get_contents("numberOfHits.txt");
	$hit = $hit + 1;
}
else 
	$hit = 1;
file_put_contents("numberOfHits.txt",$hit);
echo "This page has been visited $hit times";

My hits increment by 2! Does this increment by 1 or by 2 on your computers?

1,(refresh)3 (refresh), 5 (refresh)...I am not sure why this is happening.

But I have since moved on to very basic databases and file manipulation, and my databases are being written to twice as well as when writing to any text files.

I think that I am doing something wrong (probably a similar thing in all situations) but what on earth is my problem?

laserlight

Does this increment by 1 or by 2 on your computers?

It increments by 1.

I might write it this way instead:

<?php
$hit = file_exists("numberOfHits.txt") ?
       file_get_contents("numberOfHits.txt") + 1: 1;
file_put_contents("numberOfHits.txt", $hit);

echo "This page has been visited $hit times";
?>

But there should be no difference in increment.

It may be safer to use [man]fopen/man with [man]flock/man, then [man]fread/man [man]fwrite/man and [man]fclose/man, but the lack of file locking does not seem to be the problem.

pufftissue

Laserlight,
Thank you for trying this.

Could you please tell me what the problem on my particular machine is?

I am using wamp on a macbook pro running parallels. I believe that I have also tried this via mamp natively but I seem to get the same problem.

Is the likelihood that this is a php.ini configuration problem high, or is it something wrong with my mac platform and mamp, or just the way that I code things?

bradgrafelman

Have you tried other browsers and/or other computers? It could be some web accelerator, proxy, or something of that nature is hitting the page before your browser is, thus causing double page hits each time.

Ian_Brindley

Hmm,

What I would do i rearange the code.

    if (file_exists("numberOfHits.txt"))
    {
        $hit = file_get_contents("numberOfHits.txt");
        $hit = (int)$hit;
        $hit = $hit + 1;
        $hitS = (str)$hit;
        file_put_contents("numberOfHits.txt, $hitS");

    echo "This page has been visited $hit times.";
}
else {
    //Hit file cannot be found;
    $hit = 1;

    file_put_contents("numberOfHits.txt",$hit);

    echo "An error occured in the hit counter."; 
}

Probably not exact (More than likely no way near correct) but if the syntax was 100% I think that would work fine but I would recommend using the fopen(), fread(), and fwrite() functions.

This is a counter I have used in the past...

$filename= "hit_counter.txt" ;
$fd = fopen ($filename , "r") or die ("Can't open $filename") ;

$fstring = fread ($fd , filesize ($filename)) ;
echo "$fstring" ;
fclose($fd) ;

$fd1 = fopen ($filename , "w") or die ("Can't open $filename") ;

$fcounted = $fstring + 1 ;
$fout= fwrite ($fd , $fcounted ) ;
fclose($fd1) ;