What is wrong with this code?

Braveheart

if(isset($POST['fixed']))
echo "<strong><font color='#00FF00'>Fixed by".$POST['editn']."!</font></strong>";
elseif(isset($POST['work']))

echo "<strong><font color='#0033FF'>".$POST['editn']."is working on it!</font></strong>";
else
echo "<strong><font color='#FFCC00'>Not yet taken</font></strong>";

It should take the 'editn' input from another page and display whatever was put into the field in "editn". What have I done wrong?

Input code:

echo "<form method='POST' action='bugs_main.php'> <input type='text' value='Your name' name='editn'></form>";
echo "<form method='POST' action='bugs_main.php'> <input type='submit' value='Fixed!' name='fixed'><br /></form>";
echo "<form method='POST' action='bugs_main.php'> <input type='submit' value='Working on' name='work'></form>";

Bear in mind those pieces of code are part of a larger script. They work! Just whatever is put into the "editn" field doesn't display with the "Fixed by...!" "... is working on it!" strings.

halojoy

<?php
// page: bugs_main.php

//test submitted
if(isset($_POST['fixed']))
    echo "<strong><font color='#00FF00'>Fixed by".$_POST['editn']."!</font></strong>";

elseif(isset($_POST['work']))
    echo "<strong><font color='#0033FF'>".$_POST['editn']."is working on it!</font></strong>";

else
    echo "<strong><font color='#FFCC00'>Not yet taken</font></strong>";

// 3 forms
echo "<form method='POST' action='bugs_main.php'> 
        <input type='text' value='Your name' name='editn'>
    </form>";

echo "<form method='POST' action='bugs_main.php'>
        <input type='submit' value='Fixed!' name='fixed'><br />
    </form>";

echo "<form method='POST' action='bugs_main.php'>
        <input type='submit' value='Working on' name='work'>
    </form>";

?>

What we have here is 3 separate <forms> on one page.
Only 1 form can be submitted, when a button pressed or make an enter inside a form field.
And here only 1 value is posted.
From the other 2 forms comes nothing.

Each form is one openening tag <form> and one closing </form>

Solution might be:
a) make each form submit several values (several inputs)
or
b) make 1 form only,
by using something like this form below.

It actually works. Notice, I have changed quote method.
Single quotes around the strings.
Double quotes inside, around attributes.
This is the way we use the most in PHP. The smart way.

I may have changed your colors a bit 😉 but you can easily change back, I imagine.

Regards 🙂
halojoy

<?php

// page: bugs_main.php
$namestring = isset($_POST['editn']) ? $_POST['editn'] : 'Your Name';

//test if button 1
if( isset($_POST['fixed']) ){
    echo '<strong>Fixed by <font color="#00FF00">' .$namestring. '</font>!</strong>'."\n";
}
//test if button 2
elseif( isset($_POST['work']) ){
    echo '<strong><font color="#0033FF">' .$namestring. '</font> is working on it!</strong>'."\n";
}
//first time, no button
else{
    echo '<strong><font color="#FFCC00">Not yet taken</font></strong>'."\n";
}

// break
echo "<br />\n";
echo "<br />\n";

// ONE new form
// will always return: $_POST['editn'] == entered string   ( or 'Your Name' )
// and either one of 2 SUBMIT BUTTONS: 
// $_POST['fixed']=='Fixed!'  or  $_POST['work']=='Working on'

echo '<form method="POST" action="bugs_main.php">'."\n";

echo '<input type="text"   value="' .$namestring. '" name="editn"><br />'."\n";

echo '<input type="submit" value="Fixed!" name="fixed"><br />'."\n";

echo '<input type="submit" value="Working on" name="work"><br />'."\n";

echo '</form>'."\n";

?>

Braveheart

Hey there! Thanks for the help, I'm going to post both my scripts so you can hopefully help me further. Basically I have a bugs_main.php and a bugs_main_edit.php, bugs_main.php displays the bugs within tables and a "status" column at the end which by default shows "Not yet taken". Now when you click an "edit" button, you're taken to a password screen, enter the password if correct the bugs_main_edit.php page loads, now this page shows all the bugs and also shows an input field plus two buttons in the "status" column, the input field takes the person's name and they then press one of the two buttons "fixed" or "working on", bugs_main.php takes that information and depending on which button is pressed, the corresponding text will display ("fixed" or "working on") along with the inputted name or whatever was input to the text field.

I hope you can understand that! :p

Here are the two scripts; I hope you or anyone can help me out!! I've tried a lot of different stuff, nothing's working yet :mad:. (I've obviously removed sensitive information from the following code!)

bugs_main.php:

<?php require("menu.php"); 
$ida = $id += 0;
//Connect to MYSQL server
mysql_connect("*removed*", "*removed*", "*removed*") or die(mysql_error());
   //echo "<center><font color='white'>Successfully connected to MySQL!</font></center><br />"; 

//Connect to MYSQL database   

mysql_select_db("*removed*") or die(mysql_error());
   echo "<center><font color='white'><h4>Successfully connected to the Bugs Database!</h4></font></center>";

// Retrieve all the data from the table
$result = mysql_query("SELECT * FROM bugs ORDER BY ID DESC")
or die(mysql_error());  

// store the record of table into $row
echo "<CENTER><TABLE BORDER='2' BORDERCOLOR='#336699' CELLPADDING='2' BGCOLOR='#000000' CELLSPACING='2' WIDTH='100%'></CENTER>";
echo "<tr> <th><font color='#FFFFFF'>ID</font></th> <th><font color='#FFFFFF'>Priority</font></th> <th><font color='#FFFFFF'>Bug Type</font></th> <th><font color='#FFFFFF'>Poster</font></th> <th><font color='#FFFFFF'>Bug Description</font></th> <th><font color='#FFFFFF'>Screenshot 1</font></th> <th><font color='#FFFFFF'>Screenshot 2</font></th> <th><font color='#FFFFFF'>Screenshot 3</font></th><th><font color='#FFFFFF'>Status</font></th></tr>";
// keeps getting the next row until there are no more to get
while($row = mysql_fetch_array( $result )) {
 // Print out the contents of each row into a table  

  echo "</td><td align='center'>";
 echo "<font color='white'>".$ida++."</font>"; 
 echo "</td><td align='center'>";
 if($row['priority'] == Urgent)
    echo "<strong><font color='#FF0000'>Urgent</font></strong>";
 elseif($row['priority'] == Medium)   

     echo "<strong><font color='#FF6600'>Medium</font></strong>"; 
  elseif($row['priority'] == Low)   

     echo "<strong><font color='#FFCC00'>Low</font></strong>";  

  echo "</td><td align='center'>";
 echo "<font color='#FFFFFF'>".$row['type']."</font>";
 echo "</td><td align='center'>"; 
 echo "<font color='#FFFFFF'>".$row['poster']."</font>";
 echo "</td><td align='center'>"; 
 echo "<TEXTAREA wrap='hard' name='des' rows=5 cols=60 COLOR='#FFFFFF' readonly='yes' MAXLENGTH=9999>".$row['description']."</TEXTAREA>";
 echo "</td><td align='center'>";  

 if(empty($row['screen1']))
    echo "<font color='#FFFFFF'>No Screenshot submitted</font>";
 else
   echo "<A HREF=".$row['screen1']."><font color='#0099FF'>Screenshot1</font></A>";   

   echo "</td><td align='center'>";  

 if(empty($row['screen2']))
    echo "<font color='#FFFFFF'>No Screenshot submitted</font>";
 else        

   echo "<A HREF=".$row['screen2']."><font color='#0099FF'>Screenshot2</font></A>";
   echo "</td><td align='center'>";
if(empty($row['screen3']))
    echo "<font color='#FFFFFF'>No Screenshot submitted</font>";
   else  

   echo "<A HREF=".$row['screen3']."><font color='#0099FF'>Screenshot3</A>";
    echo "</td><td align='center'>";    

    if(isset($_POST['fixed'])) 
       echo "<strong><font color='#009900'>Fixed by".$_POST['name']."!</font></strong>";
    elseif(isset($_POST['working_on']))   

       echo "<strong><font color='#0033FF'>".$_POST['name']." is working on it!</font></strong>";
    else
     echo "<strong><font color='#FFCC00'>Not yet taken</font></strong>";       

    echo "</td></tr>";
 } 
echo "</TABLE>";

   ?></font></center></body></html>

bugs_main_edit.php:

<?php require("menu.php"); 
if($_POST['password'] != "password")
 { echo "<center><font color='red'><h4>Incorrect password!</h4></font></center>"; }

 else 

                   {
                            //Connect to MYSQL server
                            mysql_connect("*removed*", "*removed*", "*removed*") or die(mysql_error());
                            //echo "<center><font color='white'>Successfully connected to MySQL!</font></center><br />"; 

                           //Connect to MYSQL database   
                           mysql_select_db("*removed*") or die(mysql_error());
                           echo "<center><font color='white'><h4>Successfully connected to the Bugs Database!</h4></font></center>";

                          //Retrieve all the data from the table
                          $result = mysql_query("SELECT * FROM bugs ORDER BY ID DESC")
                          or die(mysql_error());  

                          //store the record of table into $row
                          echo "<CENTER><TABLE BORDER='2' BORDERCOLOR='#336699' CELLPADDING='2' BGCOLOR='#000000' CELLSPACING='2' WIDTH='100%'></CENTER>";
                          echo "<tr> <th><font color='#FFFFFF'>ID</font></th> <th><font color='#FFFFFF'>Priority</font></th> <th><font color='#FFFFFF'>Bug Type</font></th> <th><font color='#FFFFFF'>Poster</font></th> <th><font color='#FFFFFF'>Bug Description</font></th> <th><font color='#FFFFFF'>Screenshot 1</font></th> <th><font color='#FFFFFF'>Screenshot 2</font></th> <th><font color='#FFFFFF'>Screenshot 3</font></th><th><font color='#FFFFFF'>Update</font></th></tr>";
                         //keeps getting the next row until there are no more to get

                          while($row = mysql_fetch_array( $result )) 
                              {

                                 // Print out the contents of each row into a table
                                echo "<tr><td align='center'>";
                                echo "<font color='white'>".$ida++."</font>"; 
                                echo "</td><td align='center'>";
                               if($row['priority'] == Urgent)
                                {echo "<strong><font color='#FF0000'>Urgent</font></strong>"; }
                               elseif($row['priority'] == Medium)   
                                 { echo "<strong><font color='#FF6600'>Medium</font></strong>"; } 
                                elseif($row['priority'] == Low)   
                                 { echo "<strong><font color='#FFCC00'>Low</font></strong>"; }

                                echo "</td><td align='center'>";
                               echo "<font color='#FFFFFF'>".$row['type']."</font>";
                               echo "</td><td align='center'>"; 
                               echo "<font color='#FFFFFF'>".$row['poster']."</font>";
                               echo "</td><td align='center'>"; 
                               echo "<TEXTAREA wrap='hard' name='des' rows=3 cols=60 COLOR='#FFFFFF' readonly='yes'>".$row['description']."</TEXTAREA>";
                               echo "</td><td align='center'>";  
                                if(empty($row['screen1']))
                                 {  echo "<font color='#FFFFFF'>No Screenshot submitted</font>"; }
                                else
                                {  echo "<A HREF=".$row['screen1']."><font color='#0099FF'>Screenshot1</font></A>"; }   
                              echo "</td><td align='center'>";  
                               if(empty($row['screen2']))
                                {   echo "<font color='#FFFFFF'>No Screenshot submitted</font>"; }
                              else        
                               {   echo "<A HREF=".$row['screen2']."><font color='#0099FF'>Screenshot2</font></A>"; }
                             echo "</td><td align='center'>";
                             if(empty($row['screen3']))
                                {  echo "<font color='#FFFFFF'>No Screenshot submitted</font>"; }
                             else  
                               {  echo "<A HREF=".$row['screen3']."><font color='#0099FF'>Screenshot3</A>"; }
                             echo "</td><td align='center'>";
                             echo "<form method='POST' action='bugs_main.php'> <input type='text' value='Your name' name='name'></form>";
                             echo "<form method='POST' action='bugs_main.php'> <input type='submit' value='Fixed!' name='fixed'><br /></form>";
                             echo "<form method='POST' action='bugs_main.php'> <input type='submit' value='Working on' name='working_on'></form>";
                             echo "</td></tr>";
                      } 
                echo "</TABLE>";
                echo "<center><form method='POST' action='bugs_main.php'><input type='submit' value='Save' name='save'></center>";

      }                    

?></font></center></body></html>

Thanks!
-Brave.

halojoy

I will put your pages into my personal PHP server ( in my own PC, PHP 5.2.4 currently ).

If I got you right, bugs_main.php is START Page
and from there edit etc is called from buttons.
I can not promise anything,
but I try to see if I can find some fixes needed.

I wont do YOUR Work, so I expect you try the best you can at your place, too.
I gave you 2 options for a solution.
See if you can implement any of them.

Hope we can get Weedpicker or someone really experieced to support us.
Even if we do not get very high STATUS by helping beginners
it is very rewarding sometimes.
Because they are often full of spirit to explore 'new PHP possibilities'
and can be very happy when things start to work for them.
🙂

I be back.
If noone else solves this before you and me,
then I will stand by you, as much as my time schedule allows me.

Regards 🙂
halojoy

( writing on my fully Object Oriented website manager, small CMS, right now )
http://www.opensourcecms.com/
Like these, click >>> Lite <<< in left menu.
* CMS = website Content Managment System
.

Braveheart

Sounds great, thanks!

bugs_main.php is the main page, but I also have a bug submission page, but that isn't included in the problem here. All I'm trying to do is edit a status table for now. Later I plan to add in a delete function, but one step at a time :p.