[RESOLVED] PHPnews script

RodrigoDC

Hello,

I've got an interesting challenge: I am using a script called PHPnews. It is basically unsupported because their forum is down and the programmers are not returning my e-mails.

In any event, one of the features is this News program is that you can select the headlines to display by category by simply entering a price of code as follows:

<?php
$_GET['headcat'] = 1;
include("path/to/phpnews/headlines.php");
?>

The headlines.php file includes the following piece of code that enables users like me to include the headlines by category:


/* Check if headlines are being display by category or by views */
if(isset($_GET['headcat']) && is_Numeric($_GET['headcat']))
{
  $sql = 'SELECT id,posterid,time,subject FROM ' . $db_prefix . 'news WHERE catid=\'' . $_GET['headcat'] . '\' AND trusted = 1 ORDER BY id DESC LIMIT ' . $Settings['numtoshowhead'] . '';
}
elseif(isset($_GET['headviews']) && ($_GET['headviews'] == '1'))
{
    if(($_GET['headorder'] == 'down') || ($_GET['headorder'] == ''))
    {
        $sql = 'SELECT id,posterid,time,subject FROM ' . $db_prefix . 'news WHERE trusted = 1 ORDER BY views DESC LIMIT ' . $Settings['numtoshowhead'] . '';
    }
    elseif($_GET['headorder'] == 'up')
    {
        $sql = 'SELECT id,posterid,time,subject FROM ' . $db_prefix . 'news WHERE trusted = 1 ORDER BY views ASC LIMIT ' . $Settings['numtoshowhead'] . '';
    }
}
else
{
  $sql = 'SELECT id,posterid,time,subject FROM ' . $db_prefix . 'news WHERE trusted = 1 ORDER BY id DESC LIMIT ' . $Settings['numtoshowhead'] . '';
}

However, no such thing is possible when trying to show the entire news titles (not the headlines). To show the news, one most use the following piece of code:

<?php
include("path/to/phpnews/news.php");
?>

The challenge is to be able to add code into the news.php that will enable me to show the news but only by a selected category ID, something like:

<?php
$_GET['catid'] = 3;
include("path/to/phpnews/news.php");
?>

Alas, I am yet to find the answer despite breaking my head. If you're so inclined to help, you can review the entire news.php code here.

Any clue will be greatly appreciated.

WeAnswer_IT

From what I can tell, news.php uses $_GET['catid'] to determine which news stories to show, so the code you posted above almost works.

In news.php, you will find these lines:

else if($_GET['action'] == 'showcat' && isset($_GET['catid']))
{
    showCat();
}

These lines are basically saying, "If the GET variable 'action' is equal to 'showcat' and the GET variable 'catid' is set to something, show the category."

What you need to do in your code is set the GET variable 'action' to be equal to 'showcat'. Try this:

<?php
$_GET['catid'] = 3;
$_GET['action'] = "showcat";
include("path/to/phpnews/news.php");
?>

RodrigoDC

WeAnswer.IT, it is great to be in the company of geniuses.

You hit it right on the spot, and for that I am very grateful (oh, and my headache is also gone :-)

WeAnswer_IT

Great, glad I could help; remember to put [RESOLVED] in the thread title🙂

RodrigoDC

Actually, before I select to resolve the issue. I did notice that when I include the code to select the category, this one:

	<?php 
	$_GET['catid'] = 3; 
	$_GET['action'] = "showcat";
	include("/home/cfassist/public_html/news2/news.php"); 
	?>

for some reason the link to the full news no longer works, as the link uses a $_SERVER['PHP_SELF'] with the string to show the news aby ID no.

Here is an example of the problem.

When one clicks on "More news...", the string "?action=fullnews&showcomments=1&id=3" is added to to the URL, but instead of showing the expanded news piece, it reverts back to the same page, showinng all news titles within the selected category (in this case all news that apepar in catid=3.

Any thoughts to fix this problem?

RodrigoDC

Before I manage to resolve this issue, I notices that after adding the code to enable the list of news by category, this one:

<?php 
	$_GET['catid'] = 3; 
	$_GET['action'] = "showcat";
	include("/home/cfassist/public_html/news2/news.php"); 
	?>

The link that wwould otherwise enable a visitor to see the full news piece no longer appears. That is, the above code enables the list of so called news titles, and each news title includes a link to visit the full news piece. After I added the code, the full news piece no longer works, all it does is to link back to the same list of news, although the URL now shoes the string with the news ID number.

You can see the example here.

If you clcik onj the link "read more...", it should take you to the full news of the news title you just clicked on. But no, not so this time.

Needless to say, when I added

$_GET['action'] = "showcat";

the link, which uses $_SERVER['PHP_SELF'], will revert back to the same list of news titles.

Any thoughts?

WeAnswer_IT

Replace the code I gave you before with this:

<?php
if(!isset($_GET['action']))
{
    $_GET['action'] = "showcat";
    $_GET['catid'] = 3;
}
include("path/to/phpnews/news.php");
?>

RodrigoDC

WeAnswer.IT, indeed you are a genius. This case is now officially closed.

Thanks a million!

RodrigoDC

Sorry for the question, but how do I edit the thread to add [RESOLVED]?

WeAnswer_IT

I don't know, I've only been on this forum one day, I just know you're supposed to do it! 😃

jeremyphphaven

in the top right there is a menu called thread tools... hit the drop down arrow and select "Mark as resolved"