Update image problem

[Myrok]

Hi there,

i have this (i thought) simple update form in wich i can update text and if necessary an image. Updating works fine. But: if im only updating text ($label) then the image is empty after de submit (update button).
The image is also gone when i just press update.

I cant figure out how to keep the image if i don't change it.
Here's a snippet of my code: THNX in advance!

<? 
if ($_FILES['userfile']['tmp_name']) { 

    $name = $_FILES['userfile']['name']; 
    $tmpName  = $_FILES['userfile']['tmp_name']; 
    $fileSize = $_FILES['userfile']['size']; 
    $fileType = $_FILES['userfile']['type']; 

    $uploadDir = '../image/'; 
    $filePath = $uploadDir . $name; 



  if (is_uploaded_file ($_FILES['userfile']['tmp_name'])) { 
       $result = move_uploaded_file($tmpName, $filePath); 
    } 



  //  $result = move_uploaded_file($tmpName, $_SERVER['DOCUMENT_ROOT'] . '/image/' . $_FILES['userfile']['name']); 

    if (!$result) { 
        echo "Error uploading file"; 
        exit; 
    } 

} else { 
    $name = "name"; //fault?
?>

[rsmith]

I'm assuming you are talking about a form where you can see what photo is currently posted and the ability to change it or an associated text label.

I had something similar to this. I retrieved the current image path from the database and stored it into a hidden field in my form. Then on the processing side of it I checked to see if the $_FILES['file']['size'] > 0. If it was I knew the image changed and coded appropriately. If not, then I knew the file was the same and only updated the label. That should guide you in the right direction.

[Myrok]

Is it possible to do something like this:

if(!empty($_FILES['userfile']['tmp_name'])){

nothing? .. }

else { <<UPDATE the text& image files? & move & unlink old image..}

uhm.. but then in goog php language.. ?

[rsmith]

Here's what I did. Adapt for your own needs.

//Upload the listing photo
				if($_FILES['file']['size'] <= 0){
					$listingPhoto = $_POST['listingPhoto'];
				}else{
						$target_path = "../propimages/listingPhotos/";

					$tmp_name = $_FILES['file']['tmp_name'];
					$name = str_replace(" ", "_", $_FILES['file']['name']);
					if(!move_uploaded_file($tmp_name, "$target_path$name")){
						if(!is_writable($target_path)){
							echo "path not writable<br />";
						}
						echo "Could not upload the file<br />";
						exit();
					}else{
						unlink($_POST['listingPhoto']);
						$listingPhoto = "$target_path$name";
						exec("/usr/bin/convert '".$listingPhoto."' -resize 200x150! '".$listingPhoto."'");
					}
				}

[Myrok]

i just dont get it working 🙁 tried it on serveral ways... still not working.

Ik dont want to be rude, but.. take a look at my code.. can you (or anyone) see where to change it?.. tnhx a lot!

<?php
include '../library/config.php'; 
include '../library/opendb.php';

if (!isset($_GET['id'])) {  

	echo "Album id is not defined"; 
	exit; 

} else if(isset($_POST['upload'])) {
	$id   = $_POST['id'];
	$name = $_POST['name'];
	$label = $_POST['label'];

if (!get_magic_quotes_gpc()) {
	$name  = addslashes($name);
	$label  = addslashes($label);
}


if ($_FILES['userfile']['tmp_name']) {

	$name = $_FILES['userfile']['name'];
	$tmpName  = $_FILES['userfile']['tmp_name'];
	$fileSize = $_FILES['userfile']['size'];
	$fileType = $_FILES['userfile']['type'];

	$uploadDir = '../image/';
	$filePath = $uploadDir . $name;


	if( file_exists($filePath) ) {
		unlink($filePath);
	}

	$result = move_uploaded_file($tmpName, $filePath);
  //  $result = move_uploaded_file($tmpName, $_SERVER['DOCUMENT_ROOT'] . '/image/' . $_FILES['userfile']['name']); 

	if (!$result) {
		echo "Error uploading file";
		exit;
	}

} else {
	$name = "name"; //zit hier de fout?...
}


$query = "UPDATE upload ".
		"SET label = '$label', name = '$name', path = '$filePath',size = '$fileSize', type = '$fileType' ".
		"WHERE id = '{$_GET['id']}'";

		mysql_query($query) or die('Error, modify album failed : ' . mysql_error());




} else {

$id = $_GET['id'];
$sql = "SELECT id, name, label, path FROM upload WHERE id = '{$_GET['id']}'";
$result = mysql_query($sql) or die('Error, get album info failed. ' . mysql_error());

if (mysql_num_rows($result) == 0) {

} else {
	$row = mysql_fetch_assoc($result);
	?>

	<form action="" method="post" enctype="multipart/form-data" name="uploadform">
	  <table width="400" border="0" cellpadding="8" cellspacing="0" bordercolor="#FFFFFF" bgcolor="#990066">
			<tr>
			<td class="info">Titel:</td>
			<td><input name="label" type="text" id="label" value="<?php echo $row['label']; ?>"> </td>
		</tr>
		<tr>
		  <td class="info">Locatie:</td>
			<td><input name="path" type="text" id="path" value="<?php echo $row['path']; ?>"> </td>
		</tr>
		<tr>
		<tr>
		  <td class="info">Huidge afbeelding: </td>
			<td><?php echo '<img class=scale2 src="../image/' . $row['name'] . '" />' ; ?></td>
		</tr>
		<tr>
		  <td class="info">Afbeelding uploaden:</td>
			<td><input name="userfile" type="File" class="box" id="userfile" size="15"></td>
		</tr>
		<tr>
			<td class="info">&nbsp;</td>
			<td><input name="upload" type="Submit" id="upload" value="Uploaden">
			  <input type="hidden" name="id" value="<? echo "$id"; ?>" /></td>
		</tr>
	</table>

</form>
<?php
	}
}
?>
<input name="btnCancel" type="button" id="btnCancel" value="Terug" onclick="window.history.back();" />