Fatal Error?

[Eq4bits]

I'm 'redesigning' a page in a protected admin directory for my 'game' admins to use. It's present state isn't very user friendly and my game admins need LOTS of handholding.. hence trying to redesign it. The main part of the redesign entails using a single 'header.php' instead of the present 4 or 5 (mainly because it will make my life easier when items need to be changed/added to the header.. just one file to fix instead of 4 or 5). Problem is 'on update' of the forms involved on these pages the information IS inserted into the correct tables and fields of the d/b but a 'fatal error' shows up on the redirect after update page.
The 'original' code:

<?php include('../Connections/POOLTIME.php'); ?>
<?php
if (!function_exists("GetSQLValueString")) {
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "")
{
$theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue;

$theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue);

switch ($theType) {
case "text":
$theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
break;
case "long":
case "int":
$theValue = ($theValue != "") ? intval($theValue) : "NULL";
break;
case "double":
$theValue = ($theValue != "") ? "'" . doubleval($theValue) . "'" : "NULL";
break;
case "date":
$theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
break;
case "defined":
$theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
break;
}
return $theValue;
}
}

$editFormAction = $_SERVER['PHP_SELF'];
if (isset($_SERVER['QUERY_STRING'])) {
$editFormAction .= "?" . htmlentities($_SERVER['QUERY_STRING']);
}

if ((isset($_POST["MM_insert"])) && ($_POST["MM_insert"] == "ADD_CHARACTER")) {
$insertSQL = sprintf("INSERT INTO persona (persona_user_id, persona_name, persona_gender, persona_age, persona_birthdate, persona_birthmonth, persona_birthplace, persona_type, persona_type2, persona_deathturn, persona_deathmonth, persona_deathday, persona_species, persona_species_char, persona_birthplace_alt, persona_mother, persona_mother_rank, persona_father, persona_father_rank, persona_siblings, persona_history, persona_sexor, persona_relstat, persona_spouse, persona_children, persona_height, persona_height2, persona_weight, persona_eye, persona_hair, persona_appear_dscrptn, persona_prsnlt_dscrptn, persona_rank, persona_hobbies, persona_stat, persona_curloc, persona_submitted, persona_modified, persona_approved, persona_voc1_craft, persona_voc1_rank, persona_voc1_specialty, persona_extra) VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s)",
GetSQLValueString($_POST['PERSONA_USER_ID'], "int"),
GetSQLValueString($_POST['PERSONA_NAME'], "text"),
GetSQLValueString($_POST['PERSONA_GENDER'], "text"),
GetSQLValueString($_POST['PERSONA_AGE'], "int"),
GetSQLValueString($_POST['PERSONA_BIRTHDATE'], "text"),
GetSQLValueString($_POST['PERSONA_BIRTHMONTH'], "int"),
GetSQLValueString($_POST['PERSONA_BIRTHPLACE'], "text"),
GetSQLValueString($_POST['PERSONA_TYPE'], "text"),
GetSQLValueString($_POST['PERSONA_TYPE2'], "text"),
GetSQLValueString($_POST['PERSONA_DEATHTURN'], "int"),
GetSQLValueString($_POST['PERSONA_BIRTHMONTH'], "int"),
GetSQLValueString($_POST['PERSONA_DEATHDAY'], "int"),
GetSQLValueString($_POST['PERSONA_SPECIES'], "text"),
GetSQLValueString($_POST['PERSONA_SPECIES_CHAR'], "text"),
GetSQLValueString($_POST['PERSONA_BIRTHPLACE_ALT'], "text"),
GetSQLValueString($_POST['PERSONA_MOTHER'], "text"),
GetSQLValueString($_POST['PERSONA_MOTHER_RANK'], "text"),
GetSQLValueString($_POST['PERSONA_FATHER'], "text"),
GetSQLValueString($_POST['PERSONA_FATHER_RANK'], "text"),
GetSQLValueString($_POST['PERSONA_SIBLINGS'], "text"),
GetSQLValueString($_POST['PERSONA_HISTORY'], "text"),
GetSQLValueString($_POST['PERSONA_SEXOR'], "text"),
GetSQLValueString($_POST['PERSONA_RELSTAT'], "text"),
GetSQLValueString($_POST['PERSONA_SPOUSE'], "text"),
GetSQLValueString($_POST['PERSONA_CHILDREN'], "text"),
GetSQLValueString($_POST['PERSONA_HEIGHT'], "text"),
GetSQLValueString($_POST['PERSONA_HEIGHT2'], "int"),
GetSQLValueString($_POST['PERSONA_WEIGHT'], "text"),
GetSQLValueString($_POST['PERSONA_EYE'], "text"),
GetSQLValueString($_POST['PERSONA_HAIR'], "text"),
GetSQLValueString($_POST['PERSONA_APPEAR_DSCRPTN'], "text"),
GetSQLValueString($_POST['PERSONA_PRSNLT_DSCRPTN'], "text"),
GetSQLValueString($_POST['PERSONA_RANK'], "text"),
GetSQLValueString($_POST['PERSONA_HOBBIES'], "text"),
GetSQLValueString($_POST['PERSONA_STAT'], "int"),
GetSQLValueString($_POST['PERSONA_CURLOC'], "text"),
GetSQLValueString($_POST['PERSONA_SUBMITTED'], "int"),
GetSQLValueString($_POST['PERSONA_MODIFIED'], "int"),
GetSQLValueString(strtotime($_POST['PERSONA_APPROVED']), "int"),
GetSQLValueString($_POST['PERSONA_VOC1_CRAFT'], "text"),
GetSQLValueString($_POST['PERSONA_VOC1_RANK'], "text"),
GetSQLValueString($_POST['PERSONA_VOC1_SPECIALTY'], "text"),
GetSQLValueString($_POST['PERSONA_EXTRA'], "text"));

mysql_select_db($database_POOLTIME, $POOLTIME);
$Result1 = mysql_query($insertSQL, $POOLTIME) or die(mysql_error());

$insertGoTo = "/member_admin/characters_main.php";
if (isset($_SERVER['QUERY_STRING'])) {
$insertGoTo .= (strpos($insertGoTo, '?')) ? "&" : "?";
$insertGoTo .= $_SERVER['QUERY_STRING'];
}
header(sprintf("Location: %s", $insertGoTo));
}

$MMBR_USERINFO = "-1";
if (isset($_GET['edit_id'])) {
$MMBR_USERINFO = (get_magic_quotes_gpc()) ? $_GET['edit_id'] : addslashes($_GET['edit_id']);
}
mysql_select_db($database_POOLTIME, $POOLTIME);
$query_USERINFO = sprintf("SELECT * FROM member, user WHERE member.member_id = %s AND user.user_member_id = member.member_id", GetSQLValueString($MMBR_USERINFO, "int"));
$USERINFO = mysql_query($query_USERINFO, $POOLTIME) or die(mysql_error());
$row_USERINFO = mysql_fetch_assoc($USERINFO);
$totalRows_USERINFO = mysql_num_rows($USERINFO);
?><!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1" />
<title>ADMIN - USERS CHARACTERS ADD</title>
<link href="/member_admin/madmin_styles.css" rel="stylesheet" type="text/css" />
</head>
<script language="JavaScript" type="text/javascript" src="wysiwyg/wysiwyg.js">
</script>
<body>
<?php include('header_users.html'); ?>
<div class="shbar" align="center"><strong><a href="users_main.php">USERS MAIN</a></strong> | <a href="users_view_all.php">VIEW ALL USERS</a> | <a href="users_profiles_view_all.php">VIEW ALL PROFILES</a> | <a href="users_add.php">ADD USER</a></div>
<div class="cbox" align="center">

next is several hundred lines of tables and form code then:

</table>
<input type="submit" name="Submit" value="ADD CHARACTER" />
<input type="hidden" name="MM_insert" value="ADD_CHARACTER">
</form>
</div>
<?php include('footer.html'); ?>
</body>
</html>
<?php
mysql_free_result($USERINFO);
?>

Continued in reply post because it's 'too long....

[Eq4bits]

my 'redesigned' one as follows:

<?php include "header2.php";
include('../Connections/POOLTIME.php'); ?>
<?php
if (!function_exists("GetSQLValueString")) {
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "")
{
$theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue;

$theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue);

switch ($theType) {
case "text":
$theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
break;
case "long":
case "int":
$theValue = ($theValue != "") ? intval($theValue) : "NULL";
break;
case "double":
$theValue = ($theValue != "") ? "'" . doubleval($theValue) . "'" : "NULL";
break;
case "date":
$theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
break;
case "defined":
$theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
break;
}
return $theValue;
}
}

$editFormAction = $_SERVER['PHP_SELF'];
if (isset($_SERVER['QUERY_STRING'])) {
$editFormAction .= "?" . htmlentities($_SERVER['QUERY_STRING']);
}

if ((isset($_POST["MM_insert"])) && ($_POST["MM_insert"] == "ADD_CHARACTER")) {
$insertSQL = sprintf("INSERT INTO persona (persona_user_id, persona_name, persona_gender, persona_age, persona_birthdate, persona_birthmonth, persona_birthplace, persona_type, persona_type2, persona_deathturn, persona_deathmonth, persona_deathday, persona_species, persona_species_char, persona_birthplace_alt, persona_mother, persona_mother_rank, persona_father, persona_father_rank, persona_siblings, persona_history, persona_sexor, persona_relstat, persona_spouse, persona_children, persona_height, persona_height2, persona_weight, persona_eye, persona_hair, persona_appear_dscrptn, persona_prsnlt_dscrptn, persona_rank, persona_hobbies, persona_stat, persona_curloc, persona_submitted, persona_modified, persona_approved, persona_voc1_craft, persona_voc1_rank, persona_voc1_specialty, persona_extra) VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s)",
GetSQLValueString($_POST['PERSONA_USER_ID'], "int"),
GetSQLValueString($_POST['PERSONA_NAME'], "text"),
GetSQLValueString($_POST['PERSONA_GENDER'], "text"),
GetSQLValueString($_POST['PERSONA_AGE'], "int"),
GetSQLValueString($_POST['PERSONA_BIRTHDATE'], "text"),
GetSQLValueString($_POST['PERSONA_BIRTHMONTH'], "int"),
GetSQLValueString($_POST['PERSONA_BIRTHPLACE'], "text"),
GetSQLValueString($_POST['PERSONA_TYPE'], "text"),
GetSQLValueString($_POST['PERSONA_TYPE2'], "text"),
GetSQLValueString($_POST['PERSONA_DEATHTURN'], "int"),
GetSQLValueString($_POST['PERSONA_BIRTHMONTH'], "int"),
GetSQLValueString($_POST['PERSONA_DEATHDAY'], "int"),
GetSQLValueString($_POST['PERSONA_SPECIES'], "text"),
GetSQLValueString($_POST['PERSONA_SPECIES_CHAR'], "text"),
GetSQLValueString($_POST['PERSONA_BIRTHPLACE_ALT'], "text"),
GetSQLValueString($_POST['PERSONA_MOTHER'], "text"),
GetSQLValueString($_POST['PERSONA_MOTHER_RANK'], "text"),
GetSQLValueString($_POST['PERSONA_FATHER'], "text"),
GetSQLValueString($_POST['PERSONA_FATHER_RANK'], "text"),
GetSQLValueString($_POST['PERSONA_SIBLINGS'], "text"),
GetSQLValueString($_POST['PERSONA_HISTORY'], "text"),
GetSQLValueString($_POST['PERSONA_SEXOR'], "text"),
GetSQLValueString($_POST['PERSONA_RELSTAT'], "text"),
GetSQLValueString($_POST['PERSONA_SPOUSE'], "text"),
GetSQLValueString($_POST['PERSONA_CHILDREN'], "text"),
GetSQLValueString($_POST['PERSONA_HEIGHT'], "text"),
GetSQLValueString($_POST['PERSONA_HEIGHT2'], "int"),
GetSQLValueString($_POST['PERSONA_WEIGHT'], "text"),
GetSQLValueString($_POST['PERSONA_EYE'], "text"),
GetSQLValueString($_POST['PERSONA_HAIR'], "text"),
GetSQLValueString($_POST['PERSONA_APPEAR_DSCRPTN'], "text"),
GetSQLValueString($_POST['PERSONA_PRSNLT_DSCRPTN'], "text"),
GetSQLValueString($_POST['PERSONA_RANK'], "text"),
GetSQLValueString($_POST['PERSONA_HOBBIES'], "text"),
GetSQLValueString($_POST['PERSONA_STAT'], "int"),
GetSQLValueString($_POST['PERSONA_CURLOC'], "text"),
GetSQLValueString($_POST['PERSONA_SUBMITTED'], "int"),
GetSQLValueString($_POST['PERSONA_MODIFIED'], "int"),
GetSQLValueString(strtotime($_POST['PERSONA_APPROVED']), "int"),
GetSQLValueString($_POST['PERSONA_VOC1_CRAFT'], "text"),
GetSQLValueString($_POST['PERSONA_VOC1_RANK'], "text"),
GetSQLValueString($_POST['PERSONA_VOC1_SPECIALTY'], "text"),
GetSQLValueString($_POST['PERSONA_EXTRA'], "text"));

mysql_select_db($database_POOLTIME, $POOLTIME);
$Result1 = mysql_query($insertSQL, $POOLTIME) or die(mysql_error());

$insertGoTo = "index2.php";
if (isset($_SERVER['QUERY_STRING'])) {
$insertGoTo .= (strpos($insertGoTo, '?')) ? "&" : "?";
$insertGoTo .= $_SERVER['QUERY_STRING'];
}
header2(sprintf("Location: %s", $insertGoTo));
}

$MMBR_USERINFO = "-1";
if (isset($_GET['edit_id'])) {
$MMBR_USERINFO = (get_magic_quotes_gpc()) ? $_GET['edit_id'] : addslashes($_GET['edit_id']);
}

mysql_select_db($database_POOLTIME, $POOLTIME);
$query_USERINFO = sprintf("SELECT * FROM member, user WHERE member.member_id = %s AND user.user_member_id = member.member_id", GetSQLValueString($MMBR_USERINFO, "int"));
$USERINFO = mysql_query($query_USERINFO, $POOLTIME) or die(mysql_error());
$row_USERINFO = mysql_fetch_assoc($USERINFO);
$totalRows_USERINFO = mysql_num_rows($USERINFO);
?>
<!-- End whizzy stuff -->
<!-- Start whizzy display stuff -->

then the several hundred lines of table/form code and then:

<!-- End whizzy display stuff -->
<?php include('footer2.php'); ?>
<?php
mysql_free_result($USERINFO);
?>

The error I get when i test the 'redesigned' one is

Fatal error: Call to undefined function: header2() in /home/******/public_html/member_admin/users_characters_add2.php on line 92

Line 92 is the

header2(sprintf("Location: %s", $insertGoTo));

but that gives me no clue as how to 'fix', I've tried several things (taking out/putting in) and realize of course that it has to do with the header call but I have no clue how to fix it.
(Connections/POOLTIME is essentially an 'includes' file that just has the db, dbuser and password in it.)

Any assistance would be appreciated. And yes I 'own' the original version, but the guy that wrote it for me is no longer available for me to poke for help.

[NogDog]

The problem is that you try to call a function named "header2" in this line:

header2(sprintf("Location: %s", $insertGoTo));

But nowhere in the code you have provided is there a definition of such a function. Perhaps you meant to use the built-in [man]header/man function?

[Eq4bits]

I really have no clue...
I have

<!--
function MM_preloadImages() { //v3.0
var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a[i];}}
}

function MM_swapImgRestore() { //v3.0
var i,x,a=document.MM_sr; for(i=0;a&&i<a.length&&(x=a[i])&&x.oSrc;i++) x.src=x.oSrc;
}

function MM_findObj(n, d) { //v4.01
var p,i,x; if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[i][n];
for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers[i].document);
if(!x && d.getElementById) x=d.getElementById(n); return x;
}

function MM_swapImage() { //v3.0
var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new Array; for(i=0;i<(a.length-2);i+=3)
if ((x=MM_findObj(a[i]))!=null){document.MM_sr[j++]=x; if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}
}
//-->

in the header2.php file....

if I take the

 header(sprintf("Location: %s", $insertGoTo));

out the form DOES update and doesn't return a 'fatal error' or 'warning', but reopens to the same page/form instead of redirecting to the index2.php as indicated in

$insertGoTo = "index2.php";
if (isset($_SERVER['QUERY_STRING'])) {
$insertGoTo .= (strpos($insertGoTo, '?')) ? "&" : "?";
$insertGoTo .= $_SERVER['QUERY_STRING'];
}
}

is there another function that I need to put somewhere?