PHP OOP Database connection

[OtaconSN]

Hi all,

I've got a small problem that's driving me nuts (perhaps I'm just missing something). I've written a class that basically loads data from a file into an array (essentially my own custom config file). I want to use this array to assign the values to the database connections. When I use the following it works perfectly:

  $this->host = "localhost";
  $this->name = "user";
  $this->password = "pass";
  $this->database = "MyDatabase";

but if I use the following it gives me a "No database selected" error:

  $this->host = "localhost";
  $this->name = "user";
  $this->password = "pass";
  $this->database = settings[1];

When testing, I echo settings[1] within the class it displays "MyDatabase" so I know that the data has indeed been loaded correctly into the array.

The function that I have written to connect the database follows:

function dbconnect(){
$connection = mysql_connect($this->host,$this->name,$this->password);
mysql_select_db($this->database,$connection);
}

Any ideas why this is happening or what he solution could be. Any help at all will be greatly appreciated.

[NogDog]

Is the missing "$" before "settings[1]" just a typo in this post, or is it missing in the actual code? If it's just a typo here, how is it passed to your object?

[OtaconSN]

It's just a typo. My code does include "$" so the line looks like:

$this->database = $settings[1];

I've also done a check using procedural programming (no objects) and the same error occurs. The data loads correctly into the $settings array. Once loaded and if I print($settings[1]); the value that gets displayed is MyDatabase (which is correct - this is the name of my database).

Now if I do this, it gives me an error:

$connection = mysql_connect("localhost","admin","nimda");
mysql_select_db($settings[1],$connection);

But if I change the $settings[1] to "MyDatabase" then it works:

$connection = mysql_connect("localhost","admin","nimda");
mysql_select_db("MyDatabase",$connection);

Any ideas?

[laserlight]

Where does the $settings array come from? It might not be in scope.

Also, why not just use the MySQLi extension or the PDO extension?

[OtaconSN]

I have a class called Loader that contains a function that loads the data from the config file into the array. Below is what the classes look like. Can your'll see any errors? Perhaps I am doing something wrong.

//The class below is saved as file loader.php
class ConfigLoader{

var $settings;

function loadConfigFile(){

	$file_handle = fopen("config/config.cfg", "rb");

	$i = 0;

	while (!feof($file_handle) ) {
		$line_of_text = fgets($file_handle);
		$parts = explode('=', $line_of_text);

		$settings[$i]=$parts[1];

		$i = $i + 1;
		}

		fclose($file_handle);

	return $settings;
	}			
}

//This file is saved as mysql.php
require_once("loader.php");

class MySQL extends ConfigLoader{
var $connection;
var $host;
var $name;
var $password;
var $database;

function MySQL(){

	$settings2 = ConfigLoader::loadConfigFile();

//When I use it like this it does not work
//remove the comments to use
//$this->host = $settings[0];
//$this->name = $settings[1];
//$this->password = $settings[2];
//$this->database = $settings[3];

//When I use it like this it works perfectly
//remove the comments to use
//$this->host = "localhost";
//$this->name = "admin";
//$this->password = "nimda";
//$this->database = "MyDatabase";
}

function dbconnect(){
$connection = mysql_connect($this->host,$this->name,$this->password);
mysql_select_db($this->database,$connection);
}


function dbclose(){
	mysql_close($this->connection);
}


function fetchRow($query){
	$rows = mysql_fetch_row($query);
	return $rows;
}


function fetchArray($query){
	$array = mysql_fetch_array($query);
	return $array;
}


function fetchNum($query){
	$num = mysql_num_rows($query);
	return $num;
}


function dbquery($sql){
	$query = mysql_query($sql) or die(mysql_error());
	return $query;
}

}

<?
//This is the file that I am using for testing

require_once("sql/mysql.php");

$DB = new MySQL();

$connection = $DB->dbconnect();

$myqry = "SELECT Username, Password FROM login";

$query = $DB->dbquery($myqry);

//fetch all rows
while($array = $DB->fetchArray($query)){
print('Username= '.$array['Username'].' and Password= '.$array['Password']);
}

$DB->dbclose();
?>

[OtaconSN]

Oops, I made a typo. In the MySQL function it should have read:

$settings = ConfigLoader::loadConfigFile();

and not

$settings2 = ConfigLoader::loadConfigFile();

[OtaconSN]

Still not working. Please help. By the way, my config.cfg file looks as follows:

Server=localhost
Username=admin
Password=nimda
Database=MyDatabase

[NogDog]

Please discover the wonders and marvels of this forum's

[/b] [url=http://phpbuilder.com/board/misc.php?do=bbcode]bbcode tags[/url]. It will make things much easier on the people who want to take the time to read your code in order to help you.

[ascribano]

I've test you code and this is working, you only need to put TRIM()

$this->host = trim($settings[0]);