Mising images when iterating array

[neridaj]

Hello,

I'm trying to build a 5 column table of divs containing images from a directory and I don't understand why there is always 2 images missing from the output. The correct number of divs show up but when I view the html output, the image name is not getting picked up from the loop for the first 2 divs. If I echo the $imgarr[$i] in the foreach loop I get all of the images, but when the function goes into the for loop it skips 2 images.

function display_photos()
{
	$propertyaddress = $_GET['pa'];
	$userfolder = $_SESSION['valid_user'];
	$dir    = 'members/' . $userfolder . '/' . $propertyaddress . '/';
	$files = scandir($dir);
	$i = 0;
	foreach($files as $value) {
		// check for image files
		if(valid_image_file($value))
			// build image array
			$imgarr[$i] = $value;
			$i++;
	}

$count = count($imgarr);	
for($j = 0; $j < $count; $j++) {
 	if($j == 0 || $j%5 == 0)
		// echo '<div class="lastrowcol"><img src="' . $dir . $imgarr[$j] . '" width="100" height="100" /></div>';
		// 	 			else
		// 	 		echo '<div class="floatright"><img src="' . $dir . $imgarr[$j] . '" width="100" /></div>';
		echo '<div class="lastrowcol">' . $imgarr[$j] . '</div>';
			else
		echo '<div class="floatright">' . $imgarr[$j] . '</div>';
}
}

Thanks for any help with this,

Jason

[halojoy]

hi
Put in a temporary 'debug' display, of $j
this may give a hint what is going on

I frequently put in such debug variables and outputs in my script.
This way I can quickly hunt down where problems are.
Also of course [man]var_dump/man is great!

Notice that you do not have to use $i,in the first part.
Just leave the indexempty. PHP will add a new item to array automatically

$imgarr[] = $value;

function display_photos()
{
	$propertyaddress = $_GET['pa'];
	$userfolder = $_SESSION['valid_user'];
	$dir    = 'members/' . $userfolder . '/' . $propertyaddress . '/';
	$files = scandir($dir);

foreach($files as $value) {
	// check for image files
	if(valid_image_file($value)){
		// build image array
		$imgarr[] = $value;
      }
}

    // debug $imgarr
    echo '<pre>'; var_dump( $imgarr ); echo '</pre>';

$count = count($imgarr);	
for($j = 0; $j < $count; $j++) {

    // debug counter
    echo $j."<br />\n";

 	if($j == 0 || $j%5 == 0){
		// echo '<div class="lastrowcol"><img src="' . $dir . $imgarr[$j] . '" width="100" height="100" /></div>';
		// 	 			else
		// 	 		echo '<div class="floatright"><img src="' . $dir . $imgarr[$j] . '" width="100" /></div>';
		echo '<div class="lastrowcol">' . $imgarr[$j] . '</div>';
	}
	else
	{
		echo '<div class="floatright">' . $imgarr[$j] . '</div>';
	}
}
}

[neridaj]

I guess the $i was the problem, I took it out as you suggested and it works now.

Thanks,

Jaosn

[laserlight]

Remember to mark this thread as resolved (if it is) using the thread tools.