[RESOLVED] Not returning anything from mySQL

[cristal777]

Hi,

I am a semi newbie, revisiting PHP after a few years.

See my code below, I cannot get it to return any data from my mySQL database, can anyone assist me please. Any help is greatfully appreciated.

<?php

$db_handle = mysql_connect("localhost","root","") or die(mysql_error());
mysql_select_db("spl",$db_handle);

?>
<TABLE width="300" cellpadding="1" cellspacing="1">
<?
$myquery = mysql_query("SELECT NumberGoals, PlayerName, TeamName FROM scorers ORDER BY Position",$db_handle);
?>
		<tr>
		<td width="50" class="EventTitle" valign="top" align="center"><img border="0" src="photos/goals.gif"></td>
		<td width="200" class="EventTitle" valign="top" align="center"><img border="0" src="photos/name.gif"></td>
		<td width="200" class="EventTitle" valign="top" align="center"><img border="0" src="photos/team.gif"></td>
		</tr>
<?
while($rs = mysql_fetch_array($myquery)){
if($BGColor == "#D9D9F3"){
$BGColor="#F8F8FF" ;
} else {
$BGColor="#D9D9F3";
}
?>
<div ALIGN="center">

	<tr BGColor="<?echo ($BGColor);?>">
	<td class="description" valign="top" align="center"><?=$rs["NumberGoals"]; ?></td>
	<td class="description" valign="top" align="center"><?=$rs["PlayerName"]; ?></td>
	<td class="description" valign="top" align="center"><?=$rs["TeamName"]; ?></td>
	</tr>
<? } ?>
</table>

Many thanks.

[laserlight]

I suggest that you simplify your example script. Remove the HTML code that is not directly related to the problem, and then state how exactly does it not work (e.g., any error messages, what exactly is the expected output and the actual output, etc).

[cristal777]

OK will do.

<?php 

$db_handle = mysql_connect("localhost","root","") or die(mysql_error()); 
mysql_select_db("spl",$db_handle); 

?>
<? 
$myquery = mysql_query("SELECT NumberGoals, PlayerName, TeamName FROM scorers ORDER BY Position",$db_handle); 
?> 
<? 
while($rs = mysql_fetch_array($myquery)){ 
if($BGColor == "#D9D9F3"){ 
$BGColor="#F8F8FF" ; 
} else { 
$BGColor="#D9D9F3"; 
} 
?> 
<div ALIGN="center"> 

    <tr BGColor="<?echo ($BGColor);?>"> 
    <td class="description" valign="top" align="center"><?=$rs["NumberGoals"]; ?></td> 
    <td class="description" valign="top" align="center"><?=$rs["PlayerName"]; ?></td> 
    <td class="description" valign="top" align="center"><?=$rs["TeamName"]; ?></td> 
    </tr> 
<? } ?> 
</table> 

Bascially I expect to see 8 rows of data returned from the database as this is what is in the table called scorers.

I am not getting any error messages on my PHP page, I tested it was connecting to the database OK and it was.

I have made sure that my fields are spelt correctly etc but I am still not getting any error message or any results being returned. If you can assist it would be most appreciated.

Thanks.

[NogDog]

A couple things to help with debugging:

Add the following lines at the top of the script if you don't know for sure that all error reporting is already turned on. (You can delete them later, or just set display_errors to 0 for the production version.)

<?php
ini_set('display_errors', 1);
error_reporting(E_ALL);

Use "<?php" rather than "<?' tags throughout, in case short_open_tags is not enabled on your system (and just to be more compatible in general).

Always check return values for problems:

if(mysql_select_db("spl",$db_handle) == false)
{
   // log error, throw exception, die(), etc.
}
// . . .
$sql = "SELECT NumberGoals, PlayerName, TeamName FROM scorers ORDER BY Position";
$myquery = mysql_query($sql, $db_handle);
if($myquery == false)
{
   user_error(mysql_error()."<pre>$sql</pre>");
   // error message, exception, die(), or whatever
}

[cristal777]

Thanks NogDog.

I have done what you have said.

Its still not reporting any errors and it still blank.

EDIT: It was reporting " but that was my fault.

Anymore advice would be greatly appreciated.

Thanks.

[NogDog]

I just noticed that it appears you are starting your table with a <div> tag instead of a <table> tag. Perhaps everything is working PHP-wise, but invalid HTML is keeping it from displaying?

[cristal777]

NogDog wrote:

I just noticed that it appears you are starting your table with a <div> tag instead of a <table> tag. Perhaps everything is working PHP-wise, but invalid HTML is keeping it from displaying?

Hi NogDog,

Thanks for replying.

I have the table tag in my script, see my full code in my original post. I reposted my reduced code (with most HTML removed as per laserlight request in post #2).

Thanks.

[cristal777]

I have manged to solve it.

Where I had <?php=$rs["NumberGoals"]; ?> I have changed this to <?php echo $rs["NumberGoals"]; ?>

Before:

<td class="description" valign="top" align="center"><?php=$rs["NumberGoals"]; ?></td> 
<td class="description" valign="top" align="center"><?php=$rs["PlayerName"]; ?></td> 
<td class="description" valign="top" align="center"><?php=$rs["TeamName"]; ?></td>

After:

<td class="description" valign="top" align="center"><?php echo $rs["NumberGoals"]; ?></td> 
<td class="description" valign="top" align="center"><?php echo $rs["PlayerName"]; ?></td> 
<td class="description" valign="top" align="center"><?php echo $rs["TeamName"]; ?></td>