[RESOLVED] Problem witrh function called by cron job

[unitedintruth]

I have a script that is meant to rotate a list called from a database table so that all members get a chance at being first on the list.

The script continually fails to function, anyone got any ideas? Both pages involved are below.

Rotate.php reads:

<?
include("/home/american/public_html/list/includes/config.php");

if(rotateBreeders()) { echo("BREEDERS ROTATED!"); } else { echo("ERROR"); }

?>

config.php contains this function:

Function rotateBreeders() {
	$getall = mysql_query("SELECT * FROM breeders ORDER BY position ASC");

$number = 0;
$last = mysql_num_rows($getall);

while($breeder = mysql_fetch_array($getall)) {
	if($number == 0) {
		mysql_query("UPDATE breeders SET position=$last WHERE id=$breeder[id]");
	} else {
		mysql_query("UPDATE breeders SET position=$number WHERE id=$breeder[id]");
	}
	$number++;
}

}

Thanks in advance,
UnitedInTruth

[Kudose]

Your if statement expects a return value to return true or false on. You don't return a value so it is always false.

[unitedintruth]

Thank you very much, can you however please also tell me how I may fix it.

I am very new to php and do not know the ins and outs.

Thanks

[halojoy]

unitedintruth wrote:

Thank you very much, can you however please also tell me how I may fix it.

I am very new to php and do not know the ins and outs.

Thanks

you should add return value from your function
a (BOOLEAN or whatever) value that can be tested, by the caller

function myfunction(){

if(this and that){
     //dothis;
     //and
     return true;
}
else{
     //dosomething else;
     //and
     return false;
}

} // end function