Login Problems

[phpboyhelp]

I have a problem with thsis code while trying to log in with this code

In this line of code it checks database to see if the username and password matches the input fields which is shown below

mysql_connect ("$dbhost", "$dbuser", "$dbpass") or die ("Can not Connect");
			mysql_select_db("$db_name") or die ("Can  not connect to the database");

		$myusername =$_POST['user'];
		$mypassword =$_POST['password'];

		$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and
		password='$mypassword'";
		$result = mysql_query($sql);

		$count = mysql_num_rows($result);

		if($count==1){
			session_register("user");
			session_register("password");
			header("location:login_success.php");
			}
		else{
			echo "Wrong Username or Password";
			}

and the second code below checks the session and redirects me back to the main page

session_start();
if(!session_is_registered(user)){
	include ("index.html");
}

When i select the login button this error keeps coming up:

Notice: Use of undefined constant user - assumed 'user' in H:\p3t\phpappfolder\public_php\project\login_success.php on line 3

Can anyone try and help me to fix it please

[NogDog]

if(!session_is_registered([b][color=red]user[/color][/b])){

I assume you want the literal string "user" there, in which case it should be quoted.

Note however that session_register() and session_is_registered() require the now deprecated [man]register_globals[/man] "feature", so you may want to rethink using them at all in order to keep your script portable and forward-compatible. (register_globals will not be available at all in PHP 6.)

[kbc1]

Change it too:

 if($count==1){
                $_SESSION['S_USER_NAME'] = $myusername;
                 $_SESSION['S_USER_PASSWORD'] = $mypassword;
                header("location:login_success.php");
                }
            else{
                echo "Wrong Username or Password";
                } 

and then:

session_start();
if(!isset($_SESSION['S_USER_NAME'])){
    header("Location: /");
}

That should get you started but listen to NogDog, because if you are using this method on the login page, then I suspect you will be using it elsewhere...

[dclamp]

also you may want to use an encryption for the password. For all my scripts i use MD5 encrypting.

[phaseonemedia]

store the session in a $array=base64_encode(serialize($_SESSION)) and insert into sessions values('".session_id()."', '".$array."')");
md5,sha1, or any encryption method you like the password and just compare upon revalidating.