PROBLEM WITH INSERT $_POST + VARIABLES

[morena84]

Hi there!

I am new to this forum so I would like to say hello to everybody.

What I am working on is www.morenafiore.com/blog

I have working code for
- inserting new blog entry
- showing blog entries
- showing comments for every blog entry (comments that I have inserted from my mysql admin website)

I can not insert new comments though. It works like this: you have the blog entries on the main page ---> you click

onto "Read comment" button ---> it takes you to the comment page for that post and i can see the comments fine.

There is a form underneath the comment to insert a new comment but i get the error "Parse error: syntax error,

unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in

D:\inetpub\webs\morenafiorecom\blog\entries\okcomment.php on line 107" when trying to insert a new post.

Here's the code:

• form from the main page carrying the "entryid" hidden field:
  <? echo "<form name='read comment' action='entries/readcomment.php'method='get'>";
  echo "<input type='hidden' name='entryid' value='{$row['entryid']}'></input>";
  echo "<input type='hidden' name='title' value='{$row['title']}'></input>";
  echo "<input type='submit' value='Read comments' STYLE='font-family:sans-serif; font-size:10px;

background:#FFe9ca none; bordercolor:#FFe9ca;'></input></form>"; ?>

• This is the code in the readcomment.php page:
  <? echo "<h1>\"$title\"</h1><p class='commentstitle'>Comments: $comment_num</p>";
  while($row = mysql_fetch_array($result, MYSQL_ASSOC)) { ;
  echo "<p class='commentstitle'><strong> {$row['author']} </strong>said:<br>" ;
  echo "<span style= font-family:arial; font-size:20px;'>\"</span>{$row['comment']}<span style= font-family:Arial;

font-size:20px;'>\"</span><div id='line'>&nbsp</div>";
} ?>
<form class="form" name="leavecomment" action="okcomment.php" method="post">
<input type="hidden" name="numero" value=<? $row['entryid'] ?> ></input>
<label>Comment <textarea name="text" cols="60" rows="6" class="form" id="text"></textarea></label>
<p><label>Author<input name="author" type="text" class="form" id="author" size="60"

maxlength="100"></textarea></label><p>
<input type="submit" value="Leave a comment" STYLE="font-family:sans-serif; font-size:10px; background:#FFe9ca

none; bordercolor:#FFe9ca></input></form></p></p>

• This is the code in the okcomment.php page that should confirm the comment has been inserted:
  <? $day = date('d');
  $month = date('m');
  $year = date('Y');
  mysql_select_db (DB_NAME);
  if (!$dbc)
  {
  die('Could not connect: ' . mysql_error());
  }

  $sql="INSERT INTO comments (entryid, comment, author, day, month, year)
  VALUES ('$POST['numero']','$POST['text']','$_POST['author']', '.$day.', '.$month.', '.$year.');

if (!mysql_query($sql,$dbc))
{
die('Error: ' . mysql_error());
}
echo "1 comment added";mysql_close($dbc)
?>

any suggestion on what i am doing wrong?(probably everything 🙂

morena

[sandthipe]

i can't tell which line is 107 (maybe you should indicate that in your question), but i found one typo. The line:

while($row = mysql_fetch_array($result, MYSQL_ASSOC)) { ;

should not end in a semi-colon, it should read

while($row = mysql_fetch_array($result, MYSQL_ASSOC)) {

Also, the line:

$sql="INSERT INTO comments (entryid, comment, author, day, month, year)
VALUES ('$POST['numero']','$POST['text']','$_POST['author']', '.$day.', '.$month.', '.$year.');

is missing an end quote, should read

$sql="INSERT INTO comments (entryid, comment, author, day, month, year)
VALUES ('$POST['numero']','$POST['text']','$_POST['author']', '.$day.', '.$month.', '.$year.')";

[morena84]

great thanks!
i'm going to try!

it did not have line numbers because i had to work on notepad at work! 🙂

[Kudose]

In Notepad, click View -> Status Bar

You now have what line you are on in the status bar.

[morena84]

great!
my script is still not working 🙁

i'm sure there is something wrong with " and ':

this is the error:
Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in D:\inetpub\webs\morenafiorecom\blog\entries\okcomment.php on line 107

and this is the line:

<?
$inserisci="INSERT INTO comments (entryid, comment, author, day, month, year) VALUES ('.$numero.','.$comment.','.$author.', '.$day.', '.$month.', '.$year.')";

if (!mysql_query($inserisci,$dbc))
{
die('Error: ' . mysql_error());
}
echo "1 comment added";mysql_close($dbc)
?>

actually line 107 is the empty one in between values and if 😮

[morena84]

yes, i have made them all variables:

$numero=$_POST['numero'];

$comment=$_POST['text'];

$author=$_POST['author'];

[foyer]

echo "1 comment added";mysql_close($dbc)

should be

echo '1 comment added';
mysql_close($dbc);

[morena84]

thank u 🙂