form validation problem

captain_caveman

Hi guys,

I have a problem which I think must be pretty simple to solve...

Ages ago I created a web site form which uses both Javascript and php to validate. It also sends out a couple of emails - one to my company and one to the person who filled out the form. This has worked fine for ages, however having updated the website today with some minor changes (none to the form itself), I noticed that the form isn't working properly.

The page is displaying the form fields filled out with what is entered as the value for that field - for example for the first name field I have

and within the field ie displays <? echo $first_name; ?>

Also, after the submit button at the bottom, ie displays ">

I'm sure this is something simple (I'm probably being pretty thick here) and anyone who works with php will know what's going on, but I'm confused as to why this has started to do this without me changing anything to my knowledge?!

I suspect it may be a small error in the code but any ideas?

Thanks for any help.

NogDog

One possibility would be if PHP was upgraded or for some other reason the configuration was changed, and the short_open_tags option was turned off. If that is the case, then you would need to use "<?php" tags instead of just "<?".

captain_caveman

Thanks, that has done the trick in removing the text from the fields, however the form is still not working - once submit is clicked it just returns the same page with the fields cleared - looks like php has been upgraded on the server, is there something this would affect to cause the form data not to send?

This is the code I'm using to send the form:

$mailto='email address goes here';
$subject="Form Response";
$body.="some text here \n";
$body.="--------------------------------------\n";
$body.="Document chosen:		$doc\n";
$body.="Title:			$title\n";
$body.="First Name:			$first_name\n";
$body.="Last Name:			$last_name\n";
$body.="Address Line 1:		$address_1\n";
$body.="Address Line 2:		$address_2\n";
$body.="Address Line 3:		$address_3\n";
$body.="Address Line 4:		$address_4\n";
$body.="Postcode/Zip Code:	$postcode\n";
$body.="Telephone:			$telephone\n";
$body.="Email:			$email\n";
$body.="--------------------------------------\n";


mail($email, 'Document Download Request', 
    '<html>
html goes here
	</html>', 
    "To: $title $first_name $last_name <$email>\n" . 
    "From: email address here \n" . 
    "MIME-Version: 1.0\n" . 
    "Content-type: text/html; charset=iso-8859-1"); 
if (mail($mailto,$subject,$body,"From: $email\n")){

header("Location: f-thanks.php"); }
else {
  header("Location: f-error.php");
 }
}
	}[CODE]

cahva

They have also set the register_globals to off. That means you have to tell the script full variable that came from the form. That means that $title would be $_POST['title'] and so on...

http://www.php.net/manual/en/language.variables.predefined.php

NogDog

cahva wrote:
They have also set the register_globals to off. That means you have to tell the script full variable that came from the form. That means that $title would be $_POST['title'] and so on...

http://www.php.net/manual/en/language.variables.predefined.php

A work-around for this is to use the [man]import_request_variables/man function at the start of your script. Your script is still susceptible to any of the same problems that using [man]register_globals[/man] incurs, so from the viewpoint of getting your code up to current best practices it is not ideal, but it will be no worse off than it was before the change.

captain_caveman

Thanks NogDog, all I want to do is get this up and running as soon as possible really, then I could go back and get it sorted properly. Sorry for my ignorance but can you be more specific about how this function would be written, given the variables in my code?

captain_caveman

Ah I think I have sorted it with the following code -

import_request_variables("gp", "");