error: session_start()

zcollvee

My website
I just added a user system. And this is the code I put into the menu.php and after that I included it into all the other files via include();
Why am I getting this error?

<table bgcolor="white" width="800" height="10" border='0'>
<tr>
<td>
<p align="right">
<?php
session_start();
if( $username == ''){
echo '
<a href="index.php"><img src="house.png" border="0">Home</a> | 
<a href="comment.php"><img src="comments.png" border="0">Comments</a> |
<a href="register.php"><img src="user_add.png" border="0">Register!</a> |
<a href="login.php"><img src="key.png" border="0">Login</a>'
;
}else{
echo '
Logged in as: <b>'.$username.'</b> | 
<a href="index.php"><img src="house.png" border="0">Home</a> | 
<a href="comment.php"><img src="comments.png" border="0">Comments</a> | 
<a href="edit.php"><img src="user_edit.png" border="0">Edit profile</a> | 
<a href="logout.php"><img src="http://coolcenter.latestdot.net/action_forward.gif" border="0">Log Out</a>';
}

dougal85

You cannot have any output before session_start()

You have some HTML before the <?php - either reposition that or place session_start above it.

I just seen this on the front page of PHPBuilder.com 🙂
http://www.phpbuilder.com/columns/anonymousjoe20080225.php3

zcollvee

ok did this:

<?php 
session_start(); 
?>
<table bgcolor="white" width="800" height="10" border='0'>
<tr>
<td>
<p align="right">
<?php


if( $username == ''){
echo '
<a href="index.php"><img src="house.png" border="0">Home</a> | 
<a href="comment.php"><img src="comments.png" border="0">Comments</a> |
<a href="register.php"><img src="user_add.png" border="0">Register!</a> |
<a href="login.php"><img src="key.png" border="0">Login</a>'
;
}else{
echo '
Logged in as: <b>'.$username.'</b> | 
<a href="index.php"><img src="house.png" border="0">Home</a> | 
<a href="comment.php"><img src="comments.png" border="0">Comments</a> | 
<a href="edit.php?username='.$username.'"><img src="user_edit.png" border="0">Edit profile</a> | 
<a href="logout.php"><img src="action_forward.gif" border="0">Log Out</a>';
}
if( $utype == 'admin' ){
echo '
<a href="admin.php"><img src=""user_suit.png" border="0">Admin Panel</a>
';
}else{
echo "";
}
?>
</p>
</td>
</tr>
</table>
<table>
<tr>
<td>
<img src="logo.jpg" align="left">
</td></tr></table>
<hr />

now it shows up like this:
http://coolcenter.latestdot.net/index.php

laserlight

The warnings mention a "menu.php". Perhaps you included menu.php but did not show this to us in your example code?

Dvdbrink

How about when you add ob_start(); in the top of menu.php (above session_start(); ) and place ob_end_flush(); on the bottom. (Between php tags)

Works for me when I get the headers already sent problem.

laserlight

How about when you add 'ob_start();' in the top of menu.php (above session_start(); ) and place 'ob_end_flush();' on the bottom. (Between php tags)

Works for me when I get the headers already sent problem.

That typically is a poor fix since it blindly uses output buffering instead of properly restructuring the code.

halojoy

zcollvee wrote:
My website
I just added a user system. And this is the code I put into the menu.php and after that I included it into all the other files via include();
Why am I getting this error?
<table bgcolor="white" width="800" height="10" border='0'>
<tr>
<td>
<p align="right">
<?php
session_start();

Typically, you should avoid to put session_start() in files that are included/required.

Say you have an index.php, where you include a script that checks session
to see if user is logged in.

I would put [man]session_start[/man] at the beginning of index.php
It is important to START Session early,
before any possible E_NOTICE or other ECHO output to screen.

This has been told a 1.000 of times in this place.
And this issue is surely cover in some STICKY FAQ in our forum.

index.php

<?php

// to avoid Errors, Notices like: headers already sent
// we start session here, before check $_SESSION['user']
// in the reuired include 'user_check.php'
session_start();
require('user_check.php');

include( 'header.php');
include( 'menu.php');
include( 'contents.php');
include( 'footer.php');


//more code
//and more and more ...

exit(); // properly end php

?>

regars 🙂
halojoy

zcollvee

halojoy wrote:

Thanks. It works now.
http://coolcenter.latestdot.net/test/index.php

laserlight

What did you use to solve your problem?

Also, remember to mark this thread as resolved (if it is) using the thread tools.