Thumbnails not working properly

ga86

Hi im fairly new to php and I am making a website which should display lots of thumbnails of images on the main page. When a thumbnail is clicked on, the image appears in large on a new page. However at the moment only 1 thumbnail is displaying (of the latest uploaded image), and instead of the second thumbnail the image name is displayed as a hyperlink which ALSO opens up the same image as the first thumbnail! The remaining 8 images do not work and only their name appears as plain text. Here is my code.

<?php
include('./header.html');
require_once ('dbconnection.php');

$query = "SELECT * FROM image ORDER BY dateadded DESC LIMIT 10";
$result=mysql_query($query);

while($row=mysql_fetch_array($result, MYSQL_ASSOC))
{
$im = @imagecreatefromjpeg($row['imagepath']);
if($im) {
$width = imagesx($im);
$height = imagesy($im);
$scale = min( 150 / $width, 150 / $height);
$newwidth = $width $scale;
$newheight =$height $scale;
$im2 = imagecreatetruecolor($newwidth, $newheight);

imagecopyresampled($im2, $im, 0, 0, 0, 0, $newwidth, $newheight, $width, $height);

imagejpeg($im2, "thumbnails/" . $row['imagepath']);
echo "<a href=\"view_photo.php?imageid={$row['imageid']}\"/>";
echo '<img src="thumbnails/'.$row['imagepath'].'"/><br />';
}
while($row = mysql_fetch_array($result))
{
//echo $row['imageid'] . " " . $row['imagename'];
echo "{$row['imagename']}</a>";

echo "<br />";
}

mysql_close($connection);
}

include('./footer.html');
?>

Please can someone tell me what i am doing wrong, and how i can fix this problem i am having. Thank you in advance.

cahva

Well the first thing that you need to do is first check if the thumbnail is created allready. Now its very CPU intensive if you create the thumbnails everytime the script is run. The reason why it shows the same pic is because you didnt close the link tag inside the first while statement. The second while statement is not necessary at all and it doesnt probably work anyways because you have looped the result earlier to the end.

This should do the trick:

while($row=mysql_fetch_assoc($result)) {
    if (!file_exists('thumbnails/'.$row['imagepath'])) {
        /* Thumbnail generation here */
    }

echo '<a href="view_photo.php?imageid='.$row['imageid'].'">';
echo '<img src="thumbnails/'.$row['imagepath'].'"/></a><br/>';
}

ga86

cahva wrote:
Well the first thing that you need to do is first check if the thumbnail is created allready. Now its very CPU intensive if you create the thumbnails everytime the script is run. The reason why it shows the same pic is because you didnt close the link tag inside the first while statement. The second while statement is not necessary at all and it doesnt probably work anyways because you have looped the result earlier to the end.

This should do the trick:
while($row=mysql_fetch_assoc($result)) {
    if (!file_exists('thumbnails/'.$row['imagepath'])) {
        /* Thumbnail generation here */
    }

echo '<a href="view_photo.php?imageid='.$row['imageid'].'">';
echo '<img src="thumbnails/'.$row['imagepath'].'"/></a><br/>';
}

Hi. Firstly thanks for your reply. I have checked the thumbnails folder and it is correctly making the thumbnails (1 for each image). Sorry i didnt understand where should i put this while loop in the code? And should i completely get rid of the second while loop in my current code?

Thanks

cahva

Yes, get rid of the second while loop. Heres the whole script that should work:

<?php
include('./header.html');
require_once ('dbconnection.php');

$query = "SELECT * FROM image ORDER BY dateadded DESC LIMIT 10";
$result=mysql_query($query);
while($row=mysql_fetch_assoc($result)) {
	if (!file_exists('thumbnails/'.$row['imagepath'])) {
		/* Thumbnail generation */
		$im = @imagecreatefromjpeg($row['imagepath']);
		if($im) {
			$width = imagesx($im);
			$height = imagesy($im);
			$scale = min( 150 / $width, 150 / $height);
			$newwidth = $width * $scale;
			$newheight =$height * $scale;
			$im2 = imagecreatetruecolor($newwidth, $newheight);

		imagecopyresampled($im2, $im, 0, 0, 0, 0, $newwidth, $newheight, $width, $height);

		imagejpeg($im2, "thumbnails/" . $row['imagepath']);
	}
}

echo '<a href="view_photo.php?imageid='.$row['imageid'].'">';
echo '<img src="thumbnails/'.$row['imagepath'].'"/></a><br/>';
}

include('./footer.html');
?>

ga86

It works! 🙂

Thank you ever so much for your help - its much appreciated.

tuscan

ga86
I see your query has been answered and i would like to copy this for something I am thinking of doing and thought I should ask you first if that is ok.

I also wanted to ask what the code is on the 'view_photo.php' page, please.

Tuscan