Problem with db query

rkeppert

From what I am seeing, this code should query the db and return all records in table form...

It is successfully connecting to the db, and no PHP errors are being returned....

I'm confused now... 😕

Any ideas?

And how can I add a statement where if no records are found, it will display a message saying so?

Also could anyone give me a bit of detail on how to format the SELECT query with the WHERE statement, how I can only have it display records based on session variable: $_SESSION['constid'] ?

Thanks.

Rob


<?php
session_start(); // Turn on the sesssion variables
ini_set('display_errors', true); // I want PHP Information On Screen
error_reporting( E_ALL ); // I want as much Debug Info I can get when I code

include ('db_conn.php');

$dbquery = mysql_connect($servhost, $servuser, $servpwd);
if ($dbquery != FALSE)
{
	echo "Connection to Database Successful";
}
else
{
	echo "Connection Failed";
}
mysql_select_db($dbsname, $dbquery);

$srchrslt = mysql_query("SELECT * FROM $tabname", $dbquery);

?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "DTD/xhtml1-transitional.dtd">
<html>
<head>
<title>LISTING SCREEN</title>
<link href="style/style.css" rel="stylesheet" type="text/css" />
<script type="text/javascript" src="scripts/myscripts.js"></script>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"><style type="text/css">
<!--
body {
	background-color: #999999;
}
-->
</style>

</head>
<body>
<div align="center">
  <p><img src="PAconst.jpg" width="207" height="189" /><br>
  LISTING SCREEN </p>
  <p><br>
    </p>
</div>


<div id ="main">
<table>
<tr>
<th>RECORD:</th>
<th>LAST NAME:</th>
<th>FIRST NAME :</th>
<th>SEX:</th>
<th>D.O.B.:</th>
<th>CONST LAST NAME :</th>
<th>CONST FIRST NAME :</a></th>
<th>CONTACT NUMBER:</th>
<th colspan="2">CONST ID :</th>
</tr>
<?php
while ($row = mysql_fetch_row($srchrslt));
{
echo '<td>'.$row['recnum'].'</td>';
echo '<td>'.$row['lastname'].'</td>';
echo '<td>'.$row['firstname'].'</td>';
echo '<td>'.$row['sex'].'</td>';
echo '<td>'.$row['dob'].'</td>';
echo '<td>'.$row['constlname'].'</td>';
echo '<td>'.$row['constfname'].'</td>';
echo '<td>'.$row['constphnum'].'</td>';
echo '<td>'.$row['constid'].'</td>';
}
?>
</table>
</div>

</body>

</html>

halojoy

rkeppert wrote:
Also could anyone give me a bit of detail
on how to format the SELECT query
with the WHERE statement,
how I can only have it display records based on session variable:
$_SESSION['constid']

Here is how you use SQL WHERE:

http://www.tizag.com/sqlTutorial/sqlwhere.php

First let me say to you:
I wish all php coders would have learnt the good thing
of using such a good start of script.
I mean such BASICS as Turn On maximal error_reporting()
while working with php scripting development

You have got it all right!
Great, buddy 🙂

<?php

session_start(); // Turn on the session variables

ini_set('display_errors', true); // I want PHP Information On Screen
error_reporting( E_ALL ); // I want as much Debug Info I can get when I code

?>

This code can almost work, as it is.
But you should of course re-write it,
to your own layout and to fit in with rest of your code.
I only focus on the things You Asked advice about 😉

Regards

halojoy - 1800 posts to try HELP people .. from many countries in our Wide World

something like:

<?php

session_start(); // Turn on the session variables

ini_set('display_errors', true); // I want PHP Information On Screen
error_reporting( E_ALL ); // I want as much Debug Info I can get when I code

include ('db_conn.php');

$db = mysql_connect($servhost, $servuser, $servpwd);
if ( !$db ){
	exit( "Connection Failed" );
}
$dbsname = 'my_db';
if(!mysql_select_db($dbsname, $db) ){
	exit( "DB Selection Failed" );
}


// see if SESSION have some such value, otherwise = '' = empty
$cst_id = isset($_SESSION['constid']) ? $_SESSION['constid'] : '';

if( !empty($cst_id) ){
    $sql = "SELECT * FROM $tabname WHERE constid = '$cst_id'";
}
else{
    $sql = "SELECT * FROM $tabname";
}

// do the sql query and get result
$srchrslt = mysql_query($sql);

 // ARRAY to store the rows, if any
$all_rows = array(); // make an empty array

while($row = mysql_fetch_row($srchrslt)){
    $all_rows[] = $row; // store each row, if any
}

// END of my PHP PART
// in this part we process as much PHP we can
// to have as LITTLE php code as possible, in our HTML Code


///////////////////////////////////////////////////

//Later you display output in HTML
// using all processed values from PHP PART of your php script
?>
<html><body>

<table><tbody>
<?php

if($all_rows){ // not empty array(some key=>value)

foreach($all_rows as $row){
    echo '<tr>';
    echo '<td>'.$row['recnum'].'</td>';
    echo '<td>'.$row['lastname'].'</td>';
    echo '<td>'.$row['firstname'].'</td>';

    echo '<td>'.$row['sex'].'</td>';
    echo '<td>'.$row['dob'].'</td>';
    echo '<td>'.$row['constlname'].'</td>';

    echo '<td>'.$row['constfname'].'</td>';
    echo '<td>'.$row['constphnum'].'</td>';
    echo '<td>'.$row['constid'].'</td>';
    echo '</tr>';
}
}
else{ // $all_rows is empty array(), no results

echo '<tr>';
echo '<td colspan="9">No results</td>'
echo '</tr>';
}

?>
</tbody></table>

</body></html>

rkeppert

halojoy,

First, thank you for all the help so far....

I tried what you posted, and have gotten much farther than with what I had, no php errors and is properly connecting to the database... however I got something new popping up now....

Notice: Undefined index: recnum in /const/listscreen.php on line 93

Notice: Undefined index: lastname in /const/listscreen.php on line 94

Notice: Undefined index: firstname in /const/listscreen.php on line 95

Notice: Undefined index: sex in /const/listscreen.php on line 96

Notice: Undefined index: dob in /const/listscreen.php on line 97

Notice: Undefined index: constlname in /const/listscreen.php on line 98

Notice: Undefined index: constfname in /const/listscreen.php on line 99

Notice: Undefined index: constphnum in /const/listscreen.php on line 100

Notice: Undefined index: constid in /const/listscreen.php on line 101

I have no clue why... As there are records in the db table..

Thanks.

Rob

NogDog

Use [man]mysql_fetch_assoc/man instead of mysql_fetch_row().