[RESOLVED] image resize -> aspect ratio distortion

[knowj]

basically I have an image which is greater in height than width and the script outputs an image that is distorted in aspect ration being long and thin:

in:512px x 768px
out: 206px x 410px

maxwidth: const IMG_NORMAL_WIDTH = 309;
maxheight: const IMG_NORMAL_HEIGHT = 410;

			if (($width >= $maxwidth) || ($height >= $maxheight))
				{
					if ($width > $height)
						{
							echo $newwidth = $maxwidth;
							echo $newheight = $height * ($maxheight/$width);
						}
					if ($width < $height)
						{
							echo $newwidth = $width*($maxwidth/$height);
							$newheight = $maxheight;
						}
					if ($width == $height)
						{
							echo $newwidth = $maxwidth;
							echo $newheight = $maxheight;
						}
				}

[knowj]

This seems to get a better result but still out of proportion.

if (($width >= $maxwidth) || ($height >= $maxheight))
				{
					if ($width > $height)
						{
							$newwidth = $maxwidth;
							$newheight = $height * ($maxheight/$height);
						}
					if ($width < $height)
						{
							$newheight = $maxheight;
							$newwidth = $width * ($maxwidth/$width);

					}
				if ($width == $height)
					{
						$newwidth = $maxwidth;
						$newheight = $maxheight;
					}
			}

RESOLVED!

[NogDog]

I think this is what you are after:

if($width > $height and $width >= $maxwidth)
{
   $newwidth = $maxwidth;
   $newheight = $height * $maxwidth / $width;
}
elseif($height > $width and $height > $maxheight)
{
   $newheight = $maxheight;
   $newwidth = $width * $maxheight / $height;
}
else
{
   $newwidth = $width;
   $newheight = $height;
}

[knowj]

Cheers nogdog that works great everythings back to its aspect ratio.

Now my problem is that it is only meeting on the maximum requirements eg:

image goes in height greater than width:

	if ($height > $width and $height > $maxheight)
		{
			$newheight = $maxheight;
			$newwidth = $width * $maxheight / $height;
		}

the image is resized to match the maxheight requirement but the maxwidth requirement is not met.

			if ($width > $height and $width >= $maxwidth)
				{
					$newwidth = $maxwidth;
					$newheight = $height * $maxwidth / $width;
				}
			else if ($height > $width and $height > $maxheight)
				{
					$newheight = $maxheight;
					$newwidth = $width * $maxheight / $height;
				}
			else
				{
					$newwidth = $width;
					$newheight = $height;
				}

[knowj]

Resolved by removing the "$height > $width and" ive been working too much recently missing really simple things