db query issue

[rkeppert]

Can anyone tell me what I've done wrong here? I can't seem to figure it out :mad:

$sql = "SELECT * FROM $tabname ORDER BY lastname WHERE lastname = .'$_POST['lastname']'.%, AND firstname = .'$_POST['firstname']'.%, AND dob = .'$_POST['dob']'.%";

Thanks.

Rob

[Kudose]

    $sql = "SELECT * FROM $tabname ORDER BY lastname WHERE lastname = .'$_POST['lastname']'.%, AND firstname = .'$_POST['firstname']'.%, AND dob = .'$_POST['dob']'.%";

Should be

    $sql = "SELECT * FROM $tabname ORDER BY lastname WHERE lastname = '".$_POST['lastname']."%', AND firstname = '".$_POST['firstname']."%', AND dob = '".$_POST['dob']."%'";

[rkeppert]

now i'm getting the following:

Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in /const/a_searchlist.php on line 36

here is the db code:

session_start(); // Turn on the session variables

ini_set('display_errors', true); // I want PHP Information On Screen
error_reporting( E_ALL ); // I want as much Debug Info I can get when I code

include ('db_conn.php');

$db = mysql_connect($servhost, $servuser, $servpwd);
if ( !$db ){
    exit( "Connection Failed" );
}
$dbn = ($dbsname);
if(!mysql_select_db($dbn, $db) ){
    exit( "DB Selection Failed" );
}


// see if SESSION have some such value, otherwise = '' = empty
$cst_id = isset($_SESSION['constid']) ? $_SESSION['constid'] : '';

if( !empty($cst_id) ){
    $sql = "SELECT * FROM $tabname ORDER BY lastname WHERE lastname = '".$_POST['lastname']."%', AND firstname = '".$_POST['firstname']."%', AND dob = '".$_POST['dob']."%'";
}
else{
    exit( "NOT LOGGED IN" );

}

// do the sql query and get result
$srchrs = mysql_query($sql);

// ARRAY to store the rows, if any
$all_rows = array(); // make an empty array

while($row = mysql_fetch_assoc($srchrs)){
    $all_rows[] = $row; // store each row, if any
}

and line 36 would be:

// ARRAY to store the rows, if any
$all_rows = array(); // make an empty array

while($row = mysql_fetch_assoc($srchrs)){                          <--(line 36)
    $all_rows[] = $row; // store each row, if any
}

[sheephat]

$all_rows[] = $row;

This is strange, what is this?

shouldnt it be $row['fieldname'];

Lol, just re-looked at the post. Ignore this.

[cahva]

Use mysql_error() to give you what is wrong with the query.

$srchrs = mysql_query($sql) or die(mysql_error());

[NogDog]

That error usually indicates that MySQL was not able to process your query due to a syntax error, incorrect column name, etc., causing the query command to return a boolean false instead of a resource. Always check to see if your query actually worked before assuming it did:

// do the sql query and get result
$srchrs = mysql_query($sql);
if($srchrs === false)
{
   user_error("Query failed: " . mysql_error() . "<br />\n$sql");
   // output "nice" error to user, then exit() or whatever is appropriate
}

[rkeppert]

Ok this is what i'm getting:

Notice: Query failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE lastname = 'kepp%' AND warstatus = 'ACTIVE' OR 'TRANSFERRED'' at line 1
SELECT * FROM warr ORDER BY lastname WHERE lastname = 'kepp%' AND warstatus = 'ACTIVE' OR 'TRANSFERRED' in /const/a_searchlist.php on line 34

Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in /const/a_searchlist.php on line 41

[laserlight]

AND warstatus = 'ACTIVE' OR 'TRANSFERRED' probably should be AND (warstatus = 'ACTIVE' OR warstatus = 'TRANSFERRED')