&lt;option&gt; bug or something

<option> bug or something

EmperiO

Hi all I got here some thing with this code

      print "<form action='****.php' method='post'>";
      print "<select name='class'>";
      $class1="SELECT * from km_class order by class asc";
      $class2=mysql_query($class1) or die("Could not select Class);
      while ($class3=mysql_fetch_array($class2))
      {
        print "<option>$class3[class]</option>";
      }
      print "</select><br>";
      print "<input type='submit' name='submit' value='Deploy'></form>";

Okay there are 4 options
Archers
Cavalry
Swordsman
Pikeman
But when I select a different option then Cavalry and press the submit button, then on the next page it shows that you have selected Cavalry which I didn't.
The next page just shows which soldier type you have deployed but it always shows Cavalry even when I select Archer,Pikeman,Swordsman.

NogDog

Don't know if the current punctuation problems are just a bad copy here, but you didn't close the quote in the die() function's argument.

classix16

in some case this syntax is working :
print "<option>$class3[class]</option>";

but if u want to make sure that the syntax is working properly use value:
print "<option value=\"$class3[class]\">$class3[class]</option>";

ClarkF1

You'd also need to change $class3[class] to {$class3['class']} to ensure the array value is evaluated.

laserlight

You'd also need to change $class3[class] to {$class3['class']} to ensure the array value is evaluated.

That would not be necessary as per classix16's example.

EmperiO

NogDog wrote:
Don't know if the current punctuation problems are just a bad copy here, but you didn't close the quote in the die() function's argument.

It was a bad copy, I've checked

classix16 wrote:
in some case this syntax is working :
print "<option>$class3[class]</option>";

but if u want to make sure that the syntax is working properly use value:
print "<option value=\"$class3[class]\">$class3[class]</option>";

hmm weird its still only selects Cavalry..

ClarkF1 wrote:
You'd also need to change $class3[class] to {$class3['class']} to ensure the array value is evaluated.

This also didn't helped,

Thank you all for helping, could there be something else wrong??

NogDog

I suspect the problem is somewhere else than the code you've shown us so far. I'd start by inspecting the HTML source that is output on the form page, and look to see if there is anything unexpected in it that might point to where the problem is. (You might want to run it through the HTML Validator, too.) And the problem could also be in the form-handler, perhaps?

EmperiO

NogDog wrote:
I suspect the problem is somewhere else than the code you've shown us so far. I'd start by inspecting the HTML source that is output on the form page, and look to see if there is anything unexpected in it that might point to where the problem is. (You might want to run it through the HTML Validator, too.) And the problem could also be in the form-handler, perhaps?

Its not using HTML, It only uses PHP, with some html commands selected with ''print''.

jphilapy

EmperiO wrote:
Its not using HTML, It only uses PHP, with some html commands selected with ''print''.

Could you post the code here that you are passing your form to?

Jeff

NogDog

EmperiO wrote:
Its not using HTML, It only uses PHP, with some html commands selected with ''print''.

Yes, but the PHP is generating HTML code that is output to the browser. What I'm suggesting is that you view the form page in your browser, do a "View Source", and inspect the resulting HTML to make sure that it is properly structured and has the correct values. If the generated HTML is invalid or not containing the correct values, then finding out exactly where it is wrong may help you to back-track to the root cause in the PHP code. You can go to the HTML validator link I provided, and copy-and-paste the resulting HTML source code in the Validate by Direct Input tab to help find if there are any structural problems with that HTML.

EmperiO

There were errors but they had nothing to do with that part.

EmperiO

here is the whole table with the code

$num_position2=count($sfieldx);
for ($a = 0; $a < $num_position2; $a++){
if ($sfieldx[$a]==$x && $sfieldy[$a]==$y && $sfieldname[$a]==$player)
    {
    $showlink=1;
    }
    }
      print "<table class='maintable'><tr class='headline'><td><center>Command Center $showlink</center></td></tr>";
      print "<tr class='mainrow'><td>";
if($showlink==1)
      {
      print "<html<a href='' onClick=MyWindow=window.open('http://conquerorsofsanvia.890m.com/command.php?xx=$sfield3$[x]&yy=$sfield3[y]\','MyWindow','toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=no,resizable=no,width=200,height=600,left=50,top=50'); return false;>Command Selected Soldier</a>";
      }
      print "Each unit contains a squad of 100 units from the same class.<br>";
      print "<form action='dplsoldiers.php' method='post'>";
      print "<select name='class' length='20'>";
      $class1="SELECT * from km_soldierclass order by class asc";
      $class2=mysql_query($class1) or die("Could not select Monster");
      while ($class3=mysql_fetch_array($class2))
      {
        print "<option>$class3[class]</option>";
      }
      print "</select><br>";
      print "<input type='submit' name='submit' value='Deploy'></form>";
      print "Each unit contains a squad of 100 units from the same class.<br>";
      print "<form action='makebase.php?xcord=$x&ycord=$y' method='post'>";
      print "<input type='submit' name='submit' value='Create Kingdom'></form>";
      print "</td></tr></table>"

ClarkF1

Copying and pasting that code into a text editor and then displaying the code gives me a drop down with all four options

scrupul0us

invalid markup:

print "<html<a href=''

i also see no valid HTML doc structure: doctype, head, body, etc...

EmperiO

ClarkF1 wrote:
Copying and pasting that code into a text editor and then displaying the code gives me a drop down with all four options

True, but when I select, Archer and press "deploy" it goes to the other site with the variable called 'class' which holds the selected class, which is Archer. The the other link receives the variable which is always Cavalry, even if I choose another class.

EmperiO

scrupul0us wrote:
invalid markup:

print "<html<a href=''

i also see no valid HTML doc structure: doctype, head, body, etc...

I am not using html, I only use php, with some html commands which are used with ''print''.

NogDog

I am not using html, I only use php, with some html commands which are used with ''print''.

To reiterate, your PHP is outputting HTML. That HTML is what allows the browser to display a form and send a HTTP request to your form-processing script when the submit button is clicked. Therefore, in order to ensure that the browser functions correctly and predictably, you need to be sure that your PHP form script outputs valid HTML.

How about trying it using this HTML file in place of your PHP form? If it works OK, then we know the problem is in the PHP form script. If it does not work, then we know that the problem is in the dplsoldiers.php form-processing script, instead.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">

<html>
<head>
    <title>Test</title>
</head>

<body>
    <!-- note that "size" is not a valid attribute for select, so has been removed -->

<form action='dplsoldiers.php' method='post'>
    <fieldset>
        <legend>Test</legend> <select name='class'>
            <option>
                Archers
            </option>

            <option>
                Cavalry
            </option>

            <option>
                Pikesman
            </option>

            <option>
                Swordsman
            </option>
        </select>
        <br>
         <input type='submit' name='submit' value='Deploy'>
    </fieldset>
</form>
</body>
</html>

EmperiO

NogDog wrote:
To reiterate, your PHP is outputting HTML. That HTML is what allows the browser to display a form and send a HTTP request to your form-processing script when the submit button is clicked. Therefore, in order to ensure that the browser functions correctly and predictably, you need to be sure that your PHP form script outputs valid HTML.

How about trying it using this HTML file in place of your PHP form? If it works OK, then we know the problem is in the PHP form script. If it does not work, then we know that the problem is in the dplsoldiers.php form-processing script, instead.
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">

<html>
<head>
    <title>Test</title>
</head>

<body>
    

<form action='dplsoldiers.php' method='post'>
    <fieldset>
        <legend>Test</legend> <select name='class'>
            <option>
                Archers
            </option>

            <option>
                Cavalry
            </option>

            <option>
                Pikesman
            </option>

            <option>
                Swordsman
            </option>
        </select>
        <br>
         <input type='submit' name='submit' value='Deploy'>
    </fieldset>
</form>
</body>
</html>

It does not work, so the problems are in dplsoldiers, wait I found what the problem was!
Damn how dumb could I be, really sorry guys for wasting your time the problem was that I've used instead of if ($class=='cavalry'), if ($class='cavalry').
Really my apoligizes and ofcourse thank you's for letting me find out that the problem was in dplsoldiers.

ClarkF1

I think we've all made that mistake 😃

It's easy enough to do

Don't forget to mark this thread as resolved