[RESOLVED] function result?

trendMM

Hi I came across this script for resizing/cropping images. Hooked it up so it does it on upload. Anyways it works great thus far. What I'm looking to do however is if the result of the called function is successful call the function again with a different size so it creates two images of different sizes. And if there's no success give an error. I know how if and else statements work, but I'm unsure of how to get the end result of a function that's called.

Here's the code:

$newName = time(mdYhisua) . ".jpg";
$dest = "/path/to/folder/to/upload/to/";

function cropImage($nw, $nh, $source, $stype, $dest) {

$size = getimagesize($source);
$w = $size[0];
$h = $size[1];

switch($stype) {

	case 'gif':
	$simg = imagecreatefromgif($source);
	break;

	case 'jpg':
	$simg = imagecreatefromjpeg($source);
	break;

	case 'png':
	$simg = imagecreatefrompng($source);
	break;

}

$dimg = imagecreatetruecolor($nw, $nh);

$wm = $w/$nw;
$hm = $h/$nh;

$h_height = $nh/2;
$w_height = $nw/2;

if($w> $h) {

	$adjusted_width = $w / $hm;
	$half_width = $adjusted_width / 2;
	$int_width = $half_width - $w_height;

	imagecopyresampled($dimg,$simg,-$int_width,0,0,0,$adjusted_width,$nh,$w,$h);

	} elseif(($w <$h) || ($w == $h)) {

	$adjusted_height = $h / $wm;
	$half_height = $adjusted_height / 2;
	$int_height = $half_height - $h_height;

	imagecopyresampled($dimg,$simg,0,-$int_height,0,0,$nw,$adjusted_height,$w,$h);

	} else {

	imagecopyresampled($dimg,$simg,0,0,0,0,$nw,$nh,$w,$h);

}

imagejpeg($dimg,$dest,100);

}

cropImage(225, 165, $_FILES['photofile']['tmp_name'], 'jpg', $dest . $newName);

Just need to figure out if the result is successful or fail and I can figure out the rest from there. Also, I don't know if anyone else has had this problem. But sometimes depending on the photo being resized I get a black spacing. Should I post a different topic concerning this or does anyone happen to know what this problem may be?

Any help would be great. Thanks in advance!

laserlight

The problem is that cropImage() does not return a result (it is a procedure, not a function), nor does it throw an exception if there is an error, so you really have no way of knowing within the script if it succeeded.

What you can do is modify it, and either return true if it succeeds and false if it fails, or throw an exception if it fails.

trendMM

Sounds simple enough but what's the best way retrieve a true or false result? What I'm looking to do is have a total of 3 different functions being called, not 1 at a time and if 1 fails I don't want it to move onto the next.

laserlight

What I'm looking to do is have a total of 3 different functions being called, not 1 at a time and if 1 fails I don't want it to move onto the next.

It does sound like exceptions are appropriate here, since you can call the functions in a try block, and if any throw an exception, the function calls after that failed function call would be skipped.. If you use boolean return values to signal success/failure, you could write:

foo1() && foo2() && foo3();

Thus making use of the short ciruit evaluation to avoid executing foo2() and foo3() if foo1() returns false.

trendMM

I guess where I'm lost is on where I would add a boolean to return the value within my code. Sorry for the confusion and thanks so much for your help so far.

NogDog

Since imagejpeg() returns a boolean, you could just change the last line of the function to:

return imagejpeg($dimg,$dest,100);
}

Then when you call it, just check the result of the function call:

if(cropImage(225, 165, $_FILES['photofile']['tmp_name'], 'jpg', $dest . $newName))
{
   // do whatever you want to do if the first image was successfully processed
}

trendMM

quick question. do i call the if statement outside of the function or within it after the return result?

NogDog

Outside, replacing the last line of the code sample in your original post.

trendMM

Figured it out myself. On the outside. Here's my code thus far if anyone is interested in it:

$newName = time(mdYhisua) . ".jpg";
$dest1 = "/path/to/place/file/lg/";
$dest2 = "/path/to/place/file/sm/";

function cropImage($nw, $nh, $source, $stype, $dest) {

$size = getimagesize($source);
$w = $size[0];
$h = $size[1];

switch($stype) {

	case 'gif':
	$simg = imagecreatefromgif($source);
	break;

	case 'jpg':
	$simg = imagecreatefromjpeg($source);
	break;

	case 'png':
	$simg = imagecreatefrompng($source);
	break;

}

$dimg = imagecreatetruecolor($nw, $nh);

$wm = $w/$nw;
$hm = $h/$nh;

$h_height = $nh/2;
$w_height = $nw/2;

if($w> $h) {

	$adjusted_width = $w / $hm;
	$half_width = $adjusted_width / 2;
	$int_width = $half_width - $w_height;

	imagecopyresampled($dimg,$simg,-$int_width,0,0,0,$adjusted_width,$nh,$w,$h);

	} elseif(($w <$h) || ($w == $h)) {

	$adjusted_height = $h / $wm;
	$half_height = $adjusted_height / 2;
	$int_height = $half_height - $h_height;

	imagecopyresampled($dimg,$simg,0,-$int_height,0,0,$nw,$adjusted_height,$w,$h);

	} else {

	imagecopyresampled($dimg,$simg,0,0,0,0,$nw,$nh,$w,$h);

}

return imagejpeg($dimg,$dest,100);

}



cropImage(386, 290, $_FILES['photofile']['tmp_name'], 'jpg', $dest1 . $newName);

if(cropImage(386, 290, $_FILES['photofile']['tmp_name'], 'jpg', $dest1 . $newName)) {
	cropImage(39, 30, $_FILES['photofile']['tmp_name'], 'jpg', $dest2 . $newName);
} else {
	die ("<font class=\"font\">There was an error creating the image.</font>");
}

if(cropImage(39, 30, $_FILES['photofile']['tmp_name'], 'jpg', $dest2 . $newName)) {
	echo "<font class=\"font\">Success creating both images!</font>";
} else {
	die ("<font class=\"font\">There was an error creating the thumbnail image.</font>");
	unlink($dest1 . $newName);
}

Now my problem is the fact that with some of the images being uploaded depending on their height and width it comes out with some black spacing on the sides. Any idea on how to correct this?

*nevermind it seems to be working great now. thanks to everyone for their help!