Looking for class solution....

[cgm225]

So I have a database with a table containing blog/note entries with the following fields:

id | timestamp | title | date | note

I want to grab entries based on the numerical id entry. If an entry id is not provided, then I want to grab them all. I have included the beginnings of my class below, but an unsure how to hand the results of my query in a class?

Any ideas?

Thanks in advance!

class Notes {
    //Declaring variables
    private $connection;
    private $entry;

public function __construct(mysqli $connection, $id) {
    $this->connection = $connection;
    $this->entry = isset($id) ? $id : "*";
}

public function getEntry() {
    $query = "SELECT COUNT(*) FROM notes WHERE id = ? ORDER BY id DESC";
    $statement = $this->connection->prepare($query);
    $statement->bind_param('ss', $this->id);
    //$statement->execute(); Do I use this?
    //$statement->fetch(); Do I use this?

   //What do I do with the fetched results?      
}

}

[NogDog]

I think I'd be inclined to make two separate classes, as they represent different sorts of objects: one being a single entry and the other being a group of entries. You could use an abstract class to define the common attributes, something like:

<?php
abstract class Notes
{
   protected $connection;
   protected $data = array();

   protected function __construct(mysqli $connx)
   {
      $this->connection = $connx;
   }

   public function getData()
   {
      return $this->data;
   }
}

class OneNote {
   private $entry;

   public function __construct(mysqli $connection, $id) {
      parent::__construct($connection);
      $this->entry = $id;
      $this->getEntry();
   }

   private function getEntry() {
      $query = "SELECT id, col1, col2, col3 FROM notes WHERE id = ?";
      $statement = $this->connection->prepare($query);
      $statement->bind_param('s', $this->id);
      $statement->execute();
      $statement->bind_result($id, $val1, $val2, $val3);
      if($statement->fetch())
      {
         $this->data = array(
            'id'   => $id,
            'col1' => $val1,
            'col2' => $val2,
            'col3' => $val3
         );
      }
   }

   public function getData()
   {
      return $this->data;
   }
}

class AllNotes {

   public function __construct(mysqli $connection) {
      parent::__construct($connection);
      $this->getEntry();
   }

   private function getEntry() {
      $query = "SELECT id, col1, col2, col3 FROM notes ORDER BY ID DESC";
      $statement = $this->connection->prepare($query);
      $statement->execute();
      $statement->bind_result($id, $val1, $val2, $val3);
      while($statement->fetch())
      {
         $this->data[$id] = array(  // create 2-dim array
            'id'   => $id,
            'col1' => $val1,
            'col2' => $val2,
            'col3' => $val3
         );
      }
   }
}

?>

[cgm225]

Thank you for your reply! With your example, will you show me how you would implement your class? Particularly the AllNotes class with the 2 dimensional array? How do you return all those values for outputting (ie. echoing or printing)?

Thank you in advance!

[NogDog]

Well, the getData() method returns the entire array; so you could use that however you want to output it. The actual output functionality might not belong in this class, but rather in a separate output class or script. In any case, however you want to implement it, all you'd need to do is a foreach on the array, such as:

$notes = new AllNotes();
$data = $notes->getData();
foreach($data as $note)
{
   echo "<h3 class='title'>".htmlentities($note['title'])."</h3>\n";
   echo "<p class='date'>".htmlentities($note['date'])."</h3>\n";
   echo "<p class='note'>".nl2br(htmlentities($note['note']))."</h3>\n";
}

[cgm225]

thank you!

[cgm225]

I am getting the error: Fatal error: Call to a member function execute() on a non-object in C:\public_html\DEVELOPMENT\testing.php5 on line 74

...which corresponds to the $statement->execute(); line in the AllNotes class, and I cannot seem to figure out how to fix it.

Could you help me? Any ideas?

Thanks again!

[NogDog]

Check if the return value of the prepare() is false. If so, output some debug info, e.g.:

$statement = $this->connection->prepare($query);
if($statement == false)
{
   die($this->connection->error);
}

[cgm225]

I think I figured out what the problem is, and wanted to know the best way to solve it. I think the following code is causing the script to go into an infinite loop and, therefore, timeout..

    while($statement->fetch()) {

    $this->data[$id] = array( //Creating two dimensional array
        'id'   => $id,
        'col1' => $val1,
        'col2' => $val2,
        'col3' => $val3,
        'col4' => $val4
     );
}

..an infinite loop because $statement->fetch() is always going to be true if there are any query results returned?

Is there a better way to do this while statement? Thank you in advance!

[laserlight]

That should not be an infinite loop since fetch() will return false after reaching the last row in the result set.