Fatal error: call to member function on....

[Rodders]

Fatal error: Call to a member function on a non-object in blah/blah/blah.php on line 2365

This is the message I get and the line of code in question is:

$rs=$conn->execute($sql);

Now, I believe $conn is supposed to be setup by an include file as follows:

&ADONewConnection($DBTYPE);

Can anyone help me pick through this to clear up the issue? I don't even understand what the error message means!

[dougal85]

The error means that $conn is not an object. So you are not setting it up correctly or something is going wrong.

Can you show us the code where you create $conn? Also, what version of PHP do you have?

[Rodders]

OK, that's pretty much what I thought it meant....and I tried to print out $conn but got nothing so I think you must be right that $conn hasn't been set up.

The code is inside a function which is called from a PHP page. Both the page and the function library contain various included/required files. I'll try to represent this as best as I can.

ucp.php

<?php
define('IN_PHPBB', true);
$phpbb_root_path = (defined('PHPBB_ROOT_PATH')) ? PHPBB_ROOT_PATH : './';
$phpEx = substr(strrchr(__FILE__, '.'), 1);
require($phpbb_root_path . 'common.' . $phpEx);
require($phpbb_root_path . 'includes/functions_user.' . $phpEx);
require($phpbb_root_path . 'includes/functions_module.' . $phpEx);

require($_SERVER["DOCUMENT_ROOT"] . '/configcs.' . $phpEx);
require($_SERVER["DOCUMENT_ROOT"] . '/functioncs.' . $phpEx);

.....
login_box(request_var('redirect', "index.$phpEx"));

functions.php (included by common.php)

function login_box($redirect = '', $l_explain = '', $l_success = '', $admin = false, $s_display = true)
{
    $username_cs = mysql_real_escape_string($_REQUEST[username]);
    $password_cs = mysql_real_escape_string($_REQUEST[password]);
    //print_r($conn);
    $sql="SELECT * from thetable WHERE myuserid='$username_cs'";
    $rs=$conn->execute($sql);
}

So, where is $conn set up....

inside /configcs.php

$conn = &ADONewConnection($DBTYPE);
$conn->PConnect($DBHOST, $DBUSER, $DBPASSWORD, $DBNAME);

My only thought here is that maybe /configcs.php isn't being pulled in. How can I test this?

[dougal85]

add at the top of your code somewhere;

error_reporting(E_ALL);

That checks all the errors are being displayed. Also If you are using reqiure and the page isn't loaded PHP will end the script. As its required.

ADONewConnection must return a value at some point - can you show us what it returns and where that comes from?

[Rodders]

/include/adodb/adodb.inc.php

function &ADONewConnection($db='')
	{
	GLOBAL $ADODB_Database;

	$rez = true;
	if ($db) {
		if ($ADODB_Database != $db) ADOLoadCode($db);
	} else { 
		if (!empty($ADODB_Database)) {
			ADOLoadCode($ADODB_Database);
		} else {
			 $rez = false;
		}
	}

	$errorfn = (defined('ADODB_ERROR_HANDLER')) ? ADODB_ERROR_HANDLER : false;
	if (!$rez) {
		 if ($errorfn) {
			// raise an error
			$errorfn('ADONewConnection', 'ADONewConnection', -998,
					 "could not load the database driver for '$db",
					 $dbtype);
		} else
			 ADOConnection::outp( "<p>ADONewConnection: Unable to load database driver '$db'</p>",false);

		return false;
	}

	$cls = 'ADODB_'.$ADODB_Database;
	$obj = new $cls();
	if ($errorfn) {
		$obj->raiseErrorFn = $errorfn;
	}
	return $obj;
}

The call to

error_reporting(E_ALL);

hasn't caused any new output.

My suspicion is that one or more of my include files isn't being 'included'. But, I'd have expected some kind of message to tell me that.

[dougal85]

if and include fails you get a warning, if a require fails you get a fatal error.

I see in that function there is two return statements, one "return false;" and one "return $obj;" - I guess its probably following the path down the code and returning false.

I would put and echo before "return false; " to output a message - just to see if that is happening.

[Rodders]

I think I've sorted it.....

simply by placing GLOBAL $conn; prior to trying to use it. I'm lacking the 'scope' department, but I guess that because $conn is created outside of the 'login_box' function that I need to declare it as GLOBAL in order to use it inside the function.

More testing tomorrow, but it's 2:15am and bed is calling.

[Rodders]

Regarding your thought about putting echos in before the two returns, I did that a little while ago and found it to be returning an object. A rather complete one too, so I figured that my $conn was fine, but I couldn't see it inside the function.....tada!