[RESOLVED] Code Snippet To List Directory Contents -- Need Help Displaying Data

mcubedma

Hello. I've used this code snippet to list directory contents, but it lists the contents in a line without blanks. For example,
List of files:

Autumn Leaves.jpgCreek.jpgDesert Landscape.jpgphpshow.phpindex.phpfilelist.php

I'd like to have a line break between file names. Can anyone help me with this?

<?php
 if ($handle = opendir(' . ')) {
   while (false !== ($file = readdir($handle)))
      {
          if ($file != "." && $file != "..")
          {
                  $thelist .= '<a href="'.$file.'">'.$file.'</a>';
          }
       }
  closedir($handle);
  }
?>
<P>List of files:</p>
<P><?=$thelist?></p>

NogDog

I'd recommend using an unordered list, since you are creating a list:

<?php
 if ($handle = opendir(' . ')) {
   while (false !== ($file = readdir($handle)))
      {
          if ($file != "." && $file != "..")
          {
                  $thelist .= '<li><a href="'.$file.'">'.$file."</a></li>\n";
          }
       }
  closedir($handle);
  }
?>
<p>List of files:</p>
<ul>
<?php echo $thelist; ?>
</ul>

mcubedma

that doesn't make the files display in a list. anyone know why?

NogDog

mcubedma wrote:
that doesn't make the files display in a list. anyone know why?

What does it do? (Simply telling us "it doesn't work" makes it very hard to debug.)

mcubedma

Sorry about that. I meant to say that the files still print in one line as in:
Autumn Leaves.jpgCreek.jpgDesert Landscape.jpgphpshow.phpindex.phpfilelist.php

You can see this at
http://www.innovativemgtsolutions.com/upload/filelist.php

Thank you

mcubedma

This has been resolved. I needed to change

$thelist .= '<li><a href="'.$file.'">'.$file."</a>
to
$thelist .= '<a href="'.$file.'">'.$file.'</a><br />';

Thank you for your help.

NogDog

mcubedma wrote:
This has been resolved. I needed to change

$thelist .= '<li><a href="'.$file.'">'.$file."</a>
to
$thelist .= '<a href="'.$file.'">'.$file.'</a><br />';

Thank you for your help.

Looks like you left out the closing "</li>" tag from my suggestion. But if you're happy with just using <br /> and it works, that's OK (if not as semantically meaningful).