PHP image resizer and watermarker

[Kriegster]

I can't seem to get the watermark part to work, anyone have any suggestions? 🙁

<?php
header ("Content-type: image/jpeg");
function resizeimg($image)
{
$image = $_GET['image'];
$w = 320;
$h = 240;

$x = @getimagesize($image);
$sw = $x[0];
$sh = $x[1];


$new = @ImageCreateFromJPEG ($image) or
$new = @ImageCreateFromPNG ($image) or
$new = @ImageCreateFromGIF ($image) or
$new = false;

if (!$new) {
    readfile ($new);
} else {
    $thumb = @ImageCreateTrueColor ($w, $h);
    @ImageCopyResampled ($thumb, $new, 0, 0, 0, 0, $w, $h, $sw, $sh);
  $newimage =    @ImageJPEG ($thumb);
  return $newimage;
}
}
$img = resizeimg($_GET['image']);

$watermark = imagecreatefrompng('watermark.png');  

$watermark_width = imagesx($watermark);  

$watermark_height = imagesy($watermark);  

$image = imagecreatetruecolor($watermark_width, $watermark_height);  

$image = imagecreatefromjpeg($img);  

$size = getimagesize($img);  

$dest_x = $size[0] - $watermark_width - 5;  

$dest_y = $size[1] - $watermark_height - 5;  

imagecopymerge($image, $watermark, $dest_x, $dest_y, 0, 0, $watermark_width, $watermark_height, 100);  

imagejpeg($image);  

imagedestroy($image);  

imagedestroy($watermark);
?>

[NogDog]

imagejpeg() returns a boolean, not the image. So your watermark code is trying to do a imagecreatefromjpeg() of a true or false. So I'm guessing you want to end your function as:

// create thumb, then return it:
    @ImageCopyResampled ($thumb, $new, 0, 0, 0, 0, $w, $h, $sw, $sh);
    return $thumb;
  }
}

[Kriegster]

As soon as I did that it echoed text of the location instead of the image :\

[Kriegster]

I'm thinkin maybe I need to return the location of the image rather than the image it's self. How would I go about doing that?

[leatherback]

I might be completly off (It has been a looong time since I wrote this sort of scripts) but don't these functions take the actual image as input, and not a tet reference to a location?

$_GET['image'];

will return a text string. You need the $_FILES array afak to return the image.

You have a whole oad of @ symbols in your code, effectively stopping you from every knowing what goes wrong, Remove tem, and make your code fool-proof.

[NogDog]

This seems to work. (I tried to add some sort of comment wherever I changed something.)

<?php
header("Content-type: image/jpeg");
function resizeimg($image)
{
   $image = $_GET['image'];
   $w = 320;
   $h = 240;

   $x = @getimagesize($image);
   $sw = $x[0];
   $sh = $x[1];

   $new = @ImageCreateFromJPEG($image) or $new = @ImageCreateFromPNG($image) or $new =
      @ImageCreateFromGIF($image) or $new = false;

   if(!$new)
   {
      readfile($new);
   }
   else
   {
      $thumb = @ImageCreateTrueColor($w, $h);
      @ImageCopyResampled($thumb, $new, 0, 0, 0, 0, $w, $h, $sw, $sh);
//      $newimage = @ImageJPEG($thumb);
//      return $newimage;
      return $thumb;
   }
   return false;
}
$image = resizeimg($_GET['image']);

$watermark = imagecreatefrompng('watermark.png');
$watermark_width = imagesx($watermark);
$watermark_height = imagesy($watermark);
//$image = imagecreatetruecolor($watermark_width, $watermark_height);
//$image = imagecreatefromjpeg($img);
//$size = getimagesize($image);  // changed $img to $image
$dest_x = imagesx($image) - $watermark_width - 5; // use imagesx()
$dest_y = imagesy($image) - $watermark_height - 5; // use imagesy()
imagecopymerge($image, $watermark, $dest_x, $dest_y, 0, 0, $watermark_width, $watermark_height,
   100);
imagejpeg($image);
imagedestroy($image);
imagedestroy($watermark);
?> 

[Kriegster]

Ok, sorry to be a burden but how would I take all of that and center the watermark?