[RESOLVED] PHP_SELF help

[devostash]

I have a page pulls info out of db.
If a row is in error it creates a form to update one field.
It then calls itself with 2 variables set by the form..
Trouble is it doesn't like it..It looks to be executing the update statement when it shouldn't. As the variablkes have not been posted.

form statement

<form method=\"post\" action=\"{$_SERVER['PHP_SELF']}\">

code to check if variables are set. And to set them if

$id= '$POST["id"]';
$cdate= '$POST["cdate"]';

if (isset ($id) && isset ($cdate)) {

$update="query"

ociexecute($update, OCI_DEFAULT);

$committed = ocicommit($conn);

// Test whether commit was successful. If error occurred, return error message
if (!$committed) {
$error = oci_error($conn);
echo 'Commit failed. Oracle reports: ' . $error['message'];
}
}

[laserlight]

The first problem is that these:

$id= '$_POST["id"]';
$cdate= '$_POST["cdate"]';

cause $id and $cdate to be variables containing the strings '$POST["id"]' and '$POST["cdate"]' respectively. They have nothing to do with the incoming variables $POST["id"] and $POST["cdate"].

The next problem is that, assuming the first problem was fixed, you attempt to assign the incoming variables before checking that they exist.

What you should write then, is along these lines:

if (isset($_POST["id"], $_POST["cdate"])) {
    $id = $_POST["id"];
    $cdate= $_POST["cdate"];

$update = "query";

ociexecute($update, OCI_DEFAULT);

$committed = ocicommit($conn);

// Test whether commit was successful. If error occurred, return error message
if (!$committed) {
    $error = oci_error($conn);
    echo 'Commit failed. Oracle reports: ' . $error['message'];
}
}

[devostash]

Thanks laserlight..

I noticed the '' apostrope and removed them. Then I realised I would still be setting the variables but they would be empty. So my check was

if (!empty ($id) && !empty ($cdate)) which seems to work.

The worry is that empty can be a number of things null 0 etc so your solution is definately cleaner.

Thanks again

devo

[laserlight]

if (!empty ($id) && !empty ($cdate)) which seems to work.

That is still not correct though. You should be checking the incoming variables $POST["id"] and $POST["cdate"].