You have an error in your SQL syntax

bhmj6792

I am trying to update a record from a form. Ot says that I have an error at Line 5. I've created a table to spit back the information and everything displays correctly. Can someone tell me what this means and what I've done incorrectly?

<?
$sql = "UPDATE CSRs
SET
CSRID ='$CSRID',
CFName = '$CFName',
CLName = '$CLName',
Group = '$Group',
ReportsTo = '$ReportsTo',
Skillset = '$Skillset',
Location = '$Location',
Level = '$Level',
Novel = '$Novel',
Review = '$Review'
WHERE CSRID = '$CSRID'";

$result = @mysql_query($sql, $conn) or die(mysql_error());

leatherback

It tells you that the query you send to mysql is not valid. Echo out the $sql to see whether all the variables are set

bhmj6792

It says "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Group = 'CSR', ReportsTo = '12', Skillset = 'POS', Location = 'DV'' at line 6"

Form: This works. It populates information already in the table.

<form name="UpdateCSR" method="post" action="result_updatecsr.php">
<input type="hidden" name="CSRID" value="<? echo "$CSRID"; ?>">
<input type="hidden" name="ReportsTo" value="<? echo "$ReportsTo"; ?>">
<input type="hidden" name="Location" value="<? echo "$Location"; ?>">
<table width=100% class="base">
<tr>
    <td colspan=4>Update Base Information</td>
</tr>
<tr>
    <td>First Name</td>
    <td><input type="text" name="CFName" value="<? echo "$CFName"; ?>" tabindex="1"></td>
    <td>Last Name</td>
    <td><input type="text" name="CLName" value="<? echo "$CLName"; ?>" tabindex="2"></td>
</tr>
<tr>
    <td Valign=top>Group</td>
    <td Valign=top><input type="text" name="Group" value="<? echo "$Group"; ?>" tabindex="3"><br><font size="-2">CSR, Key, Support</font></td>
    <td Valign=top>Primary Skillset</td>
    <td><input type="text" name="Skillset" value="<? echo "$Skillset"; ?>" tabindex="4"></td>
</tr>
<tr>
    <td>Level</td>
    <td><input type="text" name="Level" value="<? echo "$Level"; ?>" tabindex="5"></td>
    <td>Review Date</td>
    <td><input type="text" name="Review" value="<? echo "$Review"; ?>" tabindex="6"></td>
</tr>
<tr>
    <td>Novel</td>
    <td><input type="text" name="Novel" value="<? echo "$Novel"; ?>" tabindex="7"></td>
    <td colspan="2"><input type="submit" value="Update"></td>

</tr>
</table>
</form>

I then have it output into a table so that I can see everything and everything carries through, it just won't update the table.

leatherback

as suggested before: Echo out the $sql, it will probably show you where the error in the query is e.g., empty vars, double quotes etc.

bhmj6792

Are you saying to do this:

<? echo "$sql"; ?>

Nothing shows up, but it shows up when I output it into a form.

leatherback

that is exactly what I was suggesting. It should show you the query that is sent to the database, and is causing the error. You can get rid of the quotes, by the way, and PhP tags should ideally be the longer version (<?php) for opening, as other languages use the <? tag too.

// Place this right after you have defined the query
echo $sql;

If you notice noting wrong wih the echoed information, please post it here.