looping help please.....

siriusdave

hello. please can someone help me with some coding, i have two files (codes below)

one makepreds.php this gets the info and sends the info to the database, the other one makepreds.template.php is the template file and submits the form

the only way i can get this to work is with the code below but it is not working the way I would like it to.

What i need it to do is for a user to enter the page and Make Predictions for the weeks football matches using the form, submit it , and it puts the info in to the database which the code does, but it also adds one blank entry as well

i need the code after

if (isset($_POST['Predict'])) {

to be cleaned up and may work on a loop not sure how ? and if poss only post the fields the people put a score in not all the fields .. hope you get what i mean ..here is the code please could someone help

sorry had to upload file as a zip would not let me post them..

siriusdave

/**
 * siriusfootball 1.0.0
 * Copyright © 2006-2007 Siriusdave, All Rights Reserved
 **/
session_start();
require ('includes/config.php');
require ('templates/'. $settings['template'] .'/makepreds.template.php');

global $settings,$tbl_prefix,$user,$p;

if ($user['status'] != '1')
	please_log_in();


$preds_action = $_GET['a'];

if ($preds_action == 'add_preds') {

if (isset($_POST['Predict'])) {

$date = getTodaysDate(date("Y-m-d"));
$toCheck = array( $_POST['matchid1'], $_POST['matchid2'],$_POST['matchid3'], $_POST['matchid4'],$_POST['matchid5'], $_POST['matchid6'],$_POST['matchid7'], $_POST['matchid8'],$_POST['matchid9'], $_POST['matchid10']  ); 
$count = count( $toCheck ); 
for( $i = 0; $i < $count; $i++ ) 
{ 
echo $toCheck[$i] .'&nbsp;'; 
}  

if($_POST['matchid'] = 'matchid1' ){
$matchid1 = $_POST['matchid1'];
$phomescore1 = $_POST['phomescore1'];
$pawayscore1 = $_POST['pawayscore1'];
$insert_query = mysql_query("REPLACE INTO ". $tbl_prefix ."predictiondata SET lid = '0', userid = '".$user['id']."', pmatchid = '".$matchid1." ', predtime ='".$date."', phomescore ='".$phomescore1."', pawayscore ='".$pawayscore1."' ");
}
if($_POST['matchid'] = 'matchid2'){
$matchid2 = $_POST['matchid2'];
$phomescore2 = $_POST['phomescore2'];
$pawayscore2 = $_POST['pawayscore2'];
$insert_query = mysql_query("REPLACE INTO ". $tbl_prefix ."predictiondata SET lid = '0', userid = '".$user['id']."', pmatchid = '".$matchid2." ', predtime ='".$date."', phomescore ='".$phomescore2."', pawayscore ='".$pawayscore2."' ");
}
if($_POST['matchid'] = 'matchid3'){
$matchid3 = $_POST['matchid3'];
$phomescore3 = $_POST['phomescore3'];
$pawayscore3 = $_POST['pawayscore3'];
$insert_query = mysql_query("REPLACE INTO ". $tbl_prefix ."predictiondata SET lid = '0', userid = '".$user['id']."', pmatchid = '".$matchid3." ', predtime ='".$date."', phomescore ='".$phomescore3."', pawayscore ='".$pawayscore3."' ");
}
if($_POST['matchid'] = 'matchid4'){
$matchid4 = $_POST['matchid4'];
$phomescore4 = $_POST['phomescore4'];
$pawayscore4 = $_POST['pawayscore4'];
$insert_query = mysql_query("REPLACE INTO ". $tbl_prefix ."predictiondata SET lid = '0', userid = '".$user['id']."', pmatchid = '".$matchid4." ', predtime ='".$date."', phomescore ='".$phomescore4."', pawayscore ='".$pawayscore4."' ");
}
if($_POST['matchid'] = 'matchid5'){
$matchid5 = $_POST['matchid5'];
$phomescore5 = $_POST['phomescore5'];
$pawayscore5 = $_POST['pawayscore5'];
$insert_query = mysql_query("REPLACE INTO ". $tbl_prefix ."predictiondata SET lid = '0', userid = '".$user['id']."', pmatchid = '".$matchid5." ', predtime ='".$date."', phomescore ='".$phomescore5."', pawayscore ='".$pawayscore5."' ");
}
if($_POST['matchid'] = 'matchid6'){
$matchid6 = $_POST['matchid6'];
$phomescore6 = $_POST['phomescore6'];
$pawayscore6 = $_POST['pawayscore6'];
$insert_query = mysql_query("REPLACE INTO ". $tbl_prefix ."predictiondata SET lid = '0', userid = '".$user['id']."', pmatchid = '".$matchid6." ', predtime ='".$date."', phomescore ='".$phomescore6."', pawayscore ='".$pawayscore6."' ");
}
if($_POST['matchid'] = 'matchid7'){
$matchid7 = $_POST['matchid7'];
$phomescore7 = $_POST['phomescore7'];
$pawayscore7 = $_POST['pawayscore7'];
$insert_query = mysql_query("REPLACE INTO ". $tbl_prefix ."predictiondata SET lid = '0', userid = '".$user['id']."', pmatchid = '".$matchid7." ', predtime ='".$date."', phomescore ='".$phomescore7."', pawayscore ='".$pawayscore7."' ");
}
if($_POST['matchid'] = 'matchid8'){
$matchid8 = $_POST['matchid8'];
$phomescore8 = $_POST['phomescore8'];
$pawayscore8 = $_POST['pawayscore8'];
$insert_query = mysql_query("REPLACE INTO ". $tbl_prefix ."predictiondata SET lid = '0', userid = '".$user['id']."', pmatchid = '".$matchid8." ', predtime ='".$date."', phomescore ='".$phomescore8."', pawayscore ='".$pawayscore8."' ");
}
if($_POST['matchid'] = 'matchid9'){
$matchid9= $_POST['matchid9'];
$phomescore9 = $_POST['phomescore9'];
$pawayscore9 = $_POST['pawayscore9'];
$insert_query = mysql_query("REPLACE INTO ". $tbl_prefix ."predictiondata SET lid = '0', userid = '".$user['id']."', pmatchid = '".$matchid9." ', predtime ='".$date."', phomescore ='".$phomescore9."', pawayscore ='".$pawayscore9."' ");
}
if($_POST['matchid'] = 'matchid10'){
$matchid10 = $_POST['matchid10'];
$phomescore10 = $_POST['phomescore10'];
$pawayscore10 = $_POST['pawayscore10'];
$insert_query = mysql_query("REPLACE INTO ". $tbl_prefix ."predictiondata SET lid = '0', userid = '".$user['id']."', pmatchid = '".$matchid10." ', predtime ='".$date."', phomescore ='".$phomescore10."', pawayscore ='".$pawayscore10."' ");
}
}
}



$date = GetDateFromDatetime(date("Y-m-d"));
$week = GetThisWeek();
if (array_key_exists("week", $_GET)) {
$week = $_GET["week"];
}

$match_query = mysql_query("SELECT *,p.* FROM ". $tbl_prefix ."matchdata AS m LEFT JOIN ". $tbl_prefix ."predictiondata AS p ON (m.matchid = p.pmatchid AND p.userid='".$user['id']."' AND m.lid = p.lid ) WHERE m.week=$week AND m.lid='0' ORDER BY m.week, m.matchdate");

$preds = array();
while($match_row = mysql_fetch_assoc($match_query)) {

$points = 0;




$preds[] = array (
    'matchid' => $match_row["matchid"],
    'matchdate' => convertDatetimeToScreenDate($match_row["matchdate"]),
    'hometeam' =>  $match_row["hometeam"],
    'awayteam' => $match_row["awayteam"],
	'homescore' => $match_row["homescore"], 
    'awayscore' =>$match_row["awayscore"],
    'phomescore' => $match_row["phomescore"], 
    'pawayscore' =>$match_row["pawayscore"],
    'week' => $week,
	'PTS'=> $points,
    'bonus' => $match_row["bonuspoints"],
	'homeflag'=> $match_row["hometeam"],
	'awayflag'=> $match_row["awayteam"]
	);

}	
$page_title = "Predictions";
// Load template
template_preds();

leatherback

Hey Dave,

Sorry to say.. But I cannot make heads or tails from your logic here 😃 For instance.. Where do yu actually run the insert?

Why in your form not set a matchid between 1 and 10, and use that to define where to insert it? And then you can have 1 form for all the matches, and the user just sets which match they are working on or something..

$matchid = $_POST['matchid'];
if(! is_numeric($matchid))
  {
  echo "Did you spoof the form !?";
  }
else
  {
  $phomescore = $_POST['phomescore'];
  $pawayscore = $_POST['pawayscore'];
  $insert_query = mysql_query("REPLACE INTO ". $tbl_prefix ."predictiondata SET lid = '0', userid = '".$user['id']."', pmatchid = '".$matchid." ', predtime ='".$date."', phomescore ='".$phomescore."', pawayscore ='".$pawayscore."' ");
  }

Make sure you verify your input before using it in mysql inserts like this.

siriusdave

soory this bit should not be in there..

$toCheck = array( $_POST['matchid1'], $_POST['matchid2'],$_POST['matchid3'], $_POST['matchid4'],$_POST['matchid5'], $_POST['matchid6'],$_POST['matchid7'], $_POST['matchid8'],$_POST['matchid9'], $_POST['matchid10']  ); 
$count = count( $toCheck ); 
for( $i = 0; $i < $count; $i++ ) 
{ 
echo $toCheck[$i] .'&nbsp;'; 
}

and please have a look at both file in the zip as the matchid come form a loop

just need help with this .... my coding on loop is not that good as i am still learning....

siriusdave

hey leatherback,

i tryed you code but as the template file uses a loop to get all the matches when you hit submit i only puts the last match in the datebase i have try loops for this but can't get anything to work...

please help someone 🙁