Warning: Invalid argument supplied for foreach()

[frijole]

I am getting an error for an invalid argument in the for loop. I don't get it. Any ideas?

<?PHP

function showRegisterForm ($errors) {

foreach ($errors as $error) {
	echo $error;
}
?>
<table>
<form name="input" action="<?php echo $_SERVER['PHP_SELF'] ?>" method="post">
<tr>
<td>Username: </td>
<td><input type="text" name="user"></td>
</tr>
<tr>
<td>Password:</td>
<td><input type="text" name="pass"></td>
</tr>
<tr>
<td>Re-Type Password:</td>
<td><input type="text" name="rePass"></td>
</tr>
<tr colspan="2">
<input type="hidden" value="register">
<td><input type="submit" value="Submit"></td>
</tr>
</form>
</table>
<?PHP
}?>

[NogDog]

Presumably the variable you are passing to the function is not an array, so you need to check where it gets set/modified and ensure that it is, in fact, an array.

[frijole]

I have tried changing the way i set the array and it has not helped. Is this incorrect?

<?php

//this script registers a new user.

require_once 'dbConnect.php';
require_once 'functions.php';

if (isset($_POST['register'])) {	//if the form has been submitted

$userName = $_POST['user'];
$pass = $_POST['pass'];
$rePass = $_POST['rePass'];

$query = 'SELECT * FROM users WHERE user_id="$userName"';
$insertUser = 'INSERT INTO users VALUES ($userName, $pass)';

$errors = array();

if (empty($userName) || empty($pass) || empty($rePass)) {	//are any of the fields empty

	$errors = 'All fields must be filled out.';}

elseif ($pass != $rePass) {	//all fileds are filled out, are the values valid?

	$errors = 'The passwords do not match.';}

elseif (strlen($pass) < 4 || strlen($pass) > 12) {	//check if username is too long or too short

	$errors = 'You password must be between 4 and 12 characters long.';}

elseif (strlen($userName) < 4 || strlen($userName) > 12) {	//check if username is too long or too short

	$errors = 'You username must be between 4 and 12 characters long.';}

elseif (preg_replace('/[\w ]/', '', $userName)) {	//check for invalid characters in the username

	$errors = 'Your username may only contain letters, numbers, or underscores';}

else {	//check if username already exists

	$result = mysql_query($query) or die('Connection Error.');

	if (mysql_num_rows($result) > 0) {

		$errors = 'That username is already taken.';}

	else {	//add user to the database

		mysql_query($insertUser) or die('Connection Error.');
		echo 'You have been added! sign-in and enjoy.'; }
	}

} else { //show form and errors if applicable

showRegisterForm($errors);

}
?>

		 

[NogDog]

$errors[color=red][b][][/b][/color] = "some error message";

[frijole]

Still the same problem, I can't see what is wrong.

[NogDog]

Did you fix every instance of "$errors ="?

To help debug, you might add this to the start of the function just to help debug:

if(!is_array($errors))
{
   ob_start();
   var_dump($errors);
   $varDump = ob_get_clean();
   user_error("Not an array:<br />\n<pre>$varDump</pre>\n");
}

[frijole]

You were right, with the code you offered added to the function it says it is not an array. I have changed all of the $errors to $errors[] though. Not sure what im missing.

<?php

//this script registers a new user.

require_once 'dbConnect.php';
require_once 'functions.php';

if (isset($_POST['register'])) {	//if the form has been submitted

$userName = $_POST['user'];
$pass = $_POST['pass'];
$rePass = $_POST['rePass'];

$query = 'SELECT * FROM users WHERE user_id="$userName"';
$insertUser = 'INSERT INTO users VALUES ($userName, $pass)';

$errors[] = array();

if (empty($userName) || empty($pass) || empty($rePass)) {	//are any of the fields empty

	$errors[] = "All fields must be filled out.";}

elseif ($pass != $rePass) {	//all fileds are filled out, are the values valid?

	$errors[] = "The passwords do not match.";}

elseif (strlen($pass) < 4 || strlen($pass) > 12) {	//check if username is too long or too short

	$errors[] = "You password must be between 4 and 12 characters long.";}

elseif (strlen($userName) < 4 || strlen($userName) > 12) {	//check if username is too long or too short

	$errors[] = "You username must be between 4 and 12 characters long.";}

elseif (preg_replace('/[\w ]/', '', $userName)) {	//check for invalid characters in the username

	$errors[] = "Your username may only contain letters, numbers, or underscores";}

else {	//check if username already exists

	$result = mysql_query($query) or die('Connection Error.');

	if (mysql_num_rows($result) > 0) {

		$errors[] = "That username is already taken.";}

	else {	//add user to the database

		mysql_query($insertUser) or die('Connection Error.');
		echo 'You have been added! sign-in and enjoy.'; }
	}

} else { //show form and errors if applicable

showRegisterForm($errors);

}
?>

[NogDog]

Looks like the problem is that $errors is not initialized until you are inside the first IF block, but you are calling the function with the error in the ELSE that follows. The exact solution will depend on the way you want the logic to flow. As it is now, the function only gets called if the IF condition fails, which means it will never get called with any errors, since all the error-checking is in the IF block.

What I think you want is something like:

$errors = array(); // init to empty array
if(isset($_POST['register']))
{
   // do all the form validation, then...
   if(empty($errors))
   {
      // do database update, then if everything is cool,
      // perhaps redirect to success page?
      header('Location: http://www.yoursite.com/success.php');
      exit;
   }
}
showRegisterForm($errors);  // no need for else

[frijole]

Thank you for all of your help. I am having trouble understanding how to implement the control structure you suggested in my script. I am not sure where to put the first else statement. And, how to do the query in the correct place. What is the problem with the current structure? I know that it doesn't work but I am not sure why.

<?php

//this script registers a new user.

require_once 'dbConnect.php';
require_once 'functions.php';

$errors[] = array();

if (isset($_POST['register'])) {	//if the form has been submitted

$userName = $_POST['user'];
$pass = $_POST['pass'];
$rePass = $_POST['rePass'];

$query = 'SELECT * FROM users WHERE user_id="$userName"';
$insertUser = 'INSERT INTO users VALUES ($userName, $pass)';

if (empty($userName) || empty($pass) || empty($rePass)) {	//are any of the fields empty

	$errors[] = "All fields must be filled out.";}

elseif ($pass != $rePass) {	//all fileds are filled out, are the values valid?

	$errors[] = "The passwords do not match.";}

elseif (strlen($pass) < 4 || strlen($pass) > 12) {	//check if username is too long or too short

	$errors[] = "You password must be between 4 and 12 characters long.";}

elseif (strlen($userName) < 4 || strlen($userName) > 12) {	//check if username is too long or too short

	$errors[] = "You username must be between 4 and 12 characters long.";}

elseif (preg_replace('/[\w ]/', '', $userName)) {	//check for invalid characters in the username

	$errors[] = "Your username may only contain letters, numbers, or underscores";}

else {	//check if username already exists

	$result = mysql_query($query) or die('Connection Error.');

	if (mysql_num_rows($result) > 0) {

		$errors[] = "That username is already taken.";}

	else {	//add user to the database

		mysql_query($insertUser) or die('Connection Error.');
		echo 'You have been added! sign-in and enjoy.'; }
	}

} else { //show form and errors if applicable

showRegisterForm($errors);

}
?>