Login Problem

Ne_OnZ

Hello, I seem to be stuck on my login script. It keeps saying my information is wrong even though I'm sure it's accurate. If anyone could help me out, I would greatly appreciate it. The Code:

<?php

include("Connect.php");
mysql_select_db("divnx5_web");

$user = $_POST['username'];
$pass = md5($_POST['password']);

//MYSQL Injection
$user = stripslashes($user);
$pass = stripslashes($pass);
$user = mysql_real_escape_string($user);
$pass = mysql_real_escape_string($pass);

//Query
$sql = "SELECT * FROM users WHERE username = '$user' AND password = '$pass'";
$res= mysql_query($sql) OR die(mysql_error());

if(mysql_num_rows($res) == 1) {
   echo "Welcome $user!";
}
else {
   echo "Wrong!";
}

?>

As I said before it keeps saying the information is Wrong. You can register and try to login for yourself here:

http://www.divnx.net/index.php?page=Register
Don't worry about the Security Code or it telling you to check your e-mail. Haven't coded that in yet 😛!

Thank You 🙂

Swathimaddipatl

hi...

i think some problem with insertion of details into databse.
please check on click of submit from registration wats gng on.....

Ne_OnZ

I checked my registration form and don't see any problems. Also, I tried doing this with only it checking the username and not the password and it said "Welcome Ne.OnZ!". So apparently, it's the password. Maybe it's not checking the encryption right? I'll post the register script, since I don't see any problems.

<?php

include("Connect.php");
mysql_select_db("divnx5_web");

$username = (4 <= strlen(trim($_POST['user']))) && (strlen(trim($_POST['user'])) <= 20) ? addslashes(trim($_POST['user'])) : null;
$password = (strlen($_POST['pass']) >= 8) ? md5($_POST['pass']) : null;
$password2 = (strlen($_POST['pass2']) >=8) ? md5($_POST['pass2']) : null;
$email = trim($_POST['email']) ? addslashes($_POST['email']) : null;
$checkbox = $_POST['read'];

function check($username, &$set)
{
    $query = "SELECT * FROM `users` WHERE username = '".mysql_real_escape_string($username)."'";
    $result = mysql_query($query) OR die("$query: " . mysql_error());

if(mysql_num_rows($result) > 0)
{
   echo "The username " . $username . ' is already taken.';
   $set = 1;
 }
}

function register($username, $password, $email, &$res)
{
    $que = "INSERT INTO users(username, password, email, rank) VALUES('$username', '$password', '$email', '1')";
    $res = mysql_query($que) OR die(mysql_error());
}

check($username, $set);
if(!isset($username))
   if(strlen($_POST['user']) <= 0) {
        echo "<p>The username you entered encountered a problem.</p>";
        $set = 1;
}

if(strlen($_POST['user']) < 4) {
    echo "<p>The username you entered is too short. (4-20 Characters)</p>";
    $set = 1;
}

if(strlen($_POST['user']) > 20) {
    echo "<p>The username you entered is too long. (4-20 Characters)</p>";
    $set = 1;
}

if(!isset($password) || !isset($password2))
   if(strlen($_POST['pass']) <= 0 || strlen($_POST['pass2']) <= 0) {
        echo "<p>The password's field cannot be left empty.</p>";
        $set = 1;
}

if($password != $password2) {
   echo "<p>The passwords you entered do not match.</p>";
   $set = 1;
}

if(strlen($_POST['pass']) < 8 || strlen($_POST['pass2']) < 8) {
   echo "<p>The password you entered is too short. (Min: 8 Characters)</p>";
   $set = 1;
}

if(!isset($email)) {
   echo "<p>The email you entered encountered a problem.</p>";
   $set = 1;
}

if(!isset($checkbox)) {
    echo  "<p>You must agree to the Terms Of Service before continuing.</p>";
    $set = 1;
}

if($set == 1) {
    echo "<p><a href='javascript:history.go(-1)'>.: Go Back :.</a></p>";
}

if($username && $password && $password2 && $email && $checkbox && !$set)
{
    register($username, $password, $email, $res);

echo "<p>Welcome $username to the community! However, your registration process is not done yet.
         Please check the email you provided us at $email for an activation link. Enjoy!</p>";

   mysql_close($con);
}

?>

Thank You Again!🙂

bradgrafelman

When you insert the password into the database, you use the md5() hashing function.

When you're performing the SELECT statement at login, however, you send the password as plain text.

alphasynaptic

No, if you read his script fully, he md5 hashes the password before he strips slashes and escapes them. For debugging purposes Ne.OnZ, try echoing $res before the if statement. Report back here with the answer and ensure you hide your password. Also ensure your password field in your database is i think it's 32 digits for an md5 hash but i'd say do 50 max to be safe. Also the obvious, ensure the password field in your database is using MD5 hashing.

bradgrafelman

alphasynaptic wrote:
he md5 hashes the password before he strips slashes and escapes them.

Oops! My mistake. :o

You might also try echo'ing out the query string itself so you can visually inspect it and see if it looks right. (Which I believe is what alphasynaptic was referring to, except you'd want to echo $sql, not $res.)

alphasynaptic

No I was saying he should echo $res to ensure anything is getting returned at all. Also there is some strange error I remember getting in my past projects when trying to access returned rows directly instead of putting the row's contents into a variable first and then working with it. But an error that baffled me for the longest time was that I created the password field with only enough space to store a clear-text password instead of the much longer hash. But the inspecting the query part is a good idea. Ensure your field naming scheme within the database matches up with with the query you are using.

bradgrafelman

I definitely agree with you about the password field length; I've seen that problem crop up many times.

Ne.Onz: Make sure you do as alphasynaptic suggested - double check to make sure that your password field is at least 32 characters in width; anything less than that will cause the symptoms you're having.

Ne_OnZ

Thank You All! alphasynaptic, you were absolutely correct! My password field was only 20 characters long. I made it to 50 and it works like a charm.

I also did echo $res, it said Resource ID #4. But everything works now, so no need for that right?

Thank You again! 🙂

PS. I don't see a resolved link under thread tools.

alphasynaptic

No problem. The resource id error will cause you issues if you try to utilize that row for anything other than checking that something exists in it. I usually use something like below because I am reading many variables from the database.

list($userid,$username,$password = mysql_fetch_row($res);

In that example $res is your variable doing the SQL query, and the variables passed as parameters into list are simply the names you assign for the fields of the selected row in order. So if id is first in your database and user second then you'd want to make appropriate variables within the list function. Then change your if statement to something like:

if(isset($_SESSION['username'])){blah}

This will prevent future headaches. This is just a suggestion.

Ne_OnZ

Thank You once again! 🙂 🙂

alphasynaptic

No problem man, good luck with your script/site.