Problem with uploading pictures

[enjoiskater]

Hey again

I have a new problem. I have gotten this script so I can upload a bunch of pictures at the same time, but I cant get the code to work. I think its wrong in the PHP script.

<?php
$target_path = "uploads/";

$target_path = $target_path . basename( $_FILES['uploadedfile']['name']); 

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {
    echo "The file ".  basename( $_FILES['uploadedfile']['name']). 
    " has been uploaded";
} else{
    echo "There was an error uploading the file, please try again!";
}
?>

If anyone can see whats wrong I would be grateful. It works as long as I just upload one picture and dont upload more but as soon as I try to make it upload more than one picture it dosen´t work.

[bpat1434]

What does your form look like? Right now you're only processing the one input field named "uploadedfile". If you show us the form, we can help you out.

[enjoiskater]

Yeah, of course. Forgot to put that in but here you have the form.

      <form enctype="multipart/form-data" action="uploader.php" method="POST">
       <input type="hidden" name="MAX_FILE_SIZE" value="9000000" />
       <input name="uploadedfile" type="file" class="multi"/>
       <input type="submit" value="Upload File" />
       </form>

[bradgrafelman]

At first glance, there doesn't seem to be anything wrong.

Have you tried enabling display_errors and setting error_reporting to E_ALL ? If something's failing, PHP should give you an error message.

[enjoiskater]

I think I might have figured out why the script dosen´t work. The array never stops it keeps going and when it cant find anymore it takes the last upload as empty and then my script tells me that I can´t upload an empty field.

I use another script now. This is the form script:

      

<form enctype="multipart/form-data" action="uploader.php" method="POST">
       <input name="userfile[]" type="file" class="multi"/>
       <input type="submit" value="Upload File" />
       </form>

And this is the upload script:

// In PHP versions earlier than 4.1.0, $HTTP_POST_FILES should be used instead
// of $_FILES.

$uploaddir = 'uploads/';
$uploadfile = $uploaddir . basename($HTTP_POST_FILES['userfile[]']['name']);

echo "<pre>";
if (move_uploaded_file($HTTP_POST_FILES['userfile']['tmp_name'], $uploadfile)) {
    echo "File is valid, and was successfully uploaded.\n";
} else {
    echo "Possible file upload attack!\n";
}

echo 'Here is some more debugging info:';
print_r($HTTP_POST_FILES);

print "</pre>";

Now my question is if someone maybe knows how to make the script stop when it dont find anymore pictures to upload. Because I use a Javascript to upload multipe pictures but if I add 3 pictures my php script writes it as 4 and says that there is something wrong.

Please help me I have been workning with this problem for about 4 straight days now.

[bpat1434]

You could always use [man]is_uploaded_file/man to see if there is an actual upload. If there isn't an upload, skip it; otherwise, process it.