Problem to resize an image

[vigour]

I'm trying to resize an uploaded image, but nothing happens (no file saved in 'large'). Can someone please tell me what I'm doing wrong?

list($width, $height, $type, $attr) = getimagesize("pictures/upload/".$file);
if($width > $height)
	{
	// resize image in 'upload' and save in 'large'
	$i = "pictures/upload/".$file;
	$new_width = 500;
	$p = "pictures/large/";
	$nn = $file;
	$img = imagecreatefromjpeg("$i");					// Create a new image from file or URL  

    $old_width = imagesx($img);							// Get image width  

    $old_height = imagesy($img);						// Get image height 
    $scale = $new_width/$old_width; 
    $new_height = ceil($old_height*$scale);				// Round fractions up 
    $newimg = imagecreate($new_width,$new_height);		// Create a new palette based image
    imagecopyresized($newimg,$img,0,0,0,0,$new_width,$new_height,$old_width,$old_height);	// Copy and resize part of an image 
	imagejpeg($newimg, $p.$nn);							// Output image to browser or file 
	}
else
	{
	// resize image in 'upload' and save in 'large'
	$i = "pictures/upload/".$file;
	$new_height = 500;
	$p = "pictures/large/";
	$nn = $file;
	$img = imagecreatefromjpeg("$i");					// Create a new image from file or URL  

    $old_width = imagesx($img);							// Get image width  

    $old_height = imagesy($img);						// Get image height 
    $scale = $new_height/$old_height; 
    $new_width = ceil($old_width*$scale);				// Round fractions up 
    $newimg = imagecreate($new_width,$new_height);		// Create a new palette based image
    imagecopyresized($newimg,$img,0,0,0,0,$new_width,$new_height,$old_width,$old_height);	// Copy and resize part of an image 		
	imagejpeg($newimg, $p.$nn);							// Output image to browser or file 
	}

[vigour]

I also tried this code but it seems that PHP crashes when I use imagecreatefromjpeg.

// The file
$filename = "pictures/upload/test.jpg";

// Set a maximum height and width
$width = 200;
$height = 200;

// Content type
header('Content-type: image/jpeg');

// Get new dimensions
list($width_orig, $height_orig) = getimagesize("pictures/upload/test.jpg");

$ratio_orig = $width_orig/$height_orig;

if ($width/$height > $ratio_orig)
	{
   	$width = $height*$ratio_orig;
	}
else
	{
   	$height = $width/$ratio_orig;
	}

// Resample
$image_p = imagecreatetruecolor($width, $height);

// PHP CRASHES HERE
$image = imagecreatefromjpeg("pictures/upload/test.jpg");

imagecopyresampled($image_p, $image, 0, 0, 0, 0, $width, $height, $width_orig, $height_orig);

// Output
imagejpeg($image_p, "pictures/large/test.jpg", 100);

[vigour]

I have found the error. It seems that imagecreatefromjpeg crashes if the image is too large. It works perfect with smaller images. How do I solve that?

[NogDog]

You will need to change the memory_limit setting. You can change it within the script via [man]ini_set/man.

[vigour]

My code is running on a web-hotel, so I don't have any permission to change the file.

Can it be solved in another way, for example convert the image is several steps or something? Or is my only option to use smaller images from the start?

[NogDog]

Not sure I understand (or you understand?). You can add an ini_set() command to your script, increasing the memory limit:

<?php
ini_set('memory_limit', '64M'); // increase to 64 megabytes
// rest of script
?>

(The issue is that when PHP works with an image file, it creates a bitmap of it in memory. This means there is no image compression, so it may require significantly more memory than is needed to store the file in its JPEG or other compressed format.)

[vigour]

I tried your code to increase the memory, but not even 128M will work. As far as I know, this memory limit is set in the php.ini file. Do I have access to change that file on a webhotell, probably not. Please correct me if I'm totally wrong.

ini_set('memory_limit', '128M');
// make 500px images
$dir = 'pictures/upload/'; 
if ($handle = opendir($dir))
	{ 
 	while(false!== ($file = readdir($handle)))
		{ 
   		if ($file != '.' && $file != '..')
			{ 
			$width = 500;
			$height = 500;
			list($width_orig, $height_orig) = getimagesize("pictures/upload/".$file);
			$ratio_orig = $width_orig/$height_orig;
			if ($width/$height > $ratio_orig)
				{
   				$width = $height*$ratio_orig;
				}
			else
				{
   				$height = $width/$ratio_orig;
				}
			$image_p = imagecreatetruecolor($width, $height);
			$image = imagecreatefromjpeg("pictures/upload/".$file);
			imagecopyresampled($image_p, $image, 0, 0, 0, 0, $width, $height, $width_orig, $height_orig);
			imagejpeg($image_p, "pictures/large/".$file, 100);
		} 
 	} 
 closedir($handle);  

	} 

[NogDog]

Setting the value in the script will override the value in the php.ini configuration. (However, this is not to say that there might be other limits being imposed on you by the operating system/environment. You'll have to check with your system administrator to see if there are any such limitations.)