DB connect problem

[frijole]

My script is working as it should but when it gets to the point where it is supposed to query the DB, I a connection error. Here is the script:

<?php

//this script registers a new user.

require_once 'dbConnect.php';
require_once 'functions.php';

$error = '';

if ($_POST['register'] == 1) {	//if the form has been submitted

$userName = $_POST['user'];
$pass = $_POST['pass'];
$rePass = $_POST['rePass'];

$query = 'SELECT * FROM users WHERE user_id="$userName"';
$insertUser = 'INSERT INTO users VALUES ($userName, $pass)';

if (empty($userName) || empty($pass) || empty($rePass)) {	//are any of the fields empty

	$error = "All fields must be filled out.";}

elseif ($pass != $rePass) {	//all fileds are filled out, are the values valid?

	$error = "The passwords do not match.";}

elseif (strlen($pass) < 4 || strlen($pass) > 12) {	//check if username is too long or too short

	$error = "You password must be between 4 and 12 characters long.";}

elseif (strlen($userName) < 4 || strlen($userName) > 12) {	//check if username is too long or too short

	$error = "You username must be between 4 and 12 characters long.";}

elseif (preg_replace('/[\w ]/', '', $userName)) {	//check for invalid characters in the username

	$error = "Your username may only contain letters, numbers, or underscores";}

else {	//check if username already exists

	$result = mysql_query($query) or die('Connection Error.');

	if (mysql_num_rows($result) > 0) {

		$error = "That username is already taken.";
		}

	else {	//add user to the database

		if (strlen($error) > 0) {

			showRegisterForm($error);

		} else {

		mysql_query($insertUser) or die('Connection Error.');
		echo 'You have been added! sign-in and enjoy.'; 
		}
		}

} //show form and errors if applicable
}
	showRegisterForm($error);

?>

and here is my dbConnect.php which deals with the DB, minus the username etc.

<?php 
//Database Settings
	define("HOST", "localhost");
	define("DBUSER", "******");
	define("PASS", "******");
	define("DB", "******");

//MySQL Connection
	$conn = mysql_connect(HOST, DBUSER, PASS);
	if (!conn)
	{
		// the connection failed so quit the script
		die('Could not connect !<br />Please contact the site administrator.');
	}

$db = mysql_select_db(DB);
if (!db)
{
	// cannot connect to the database so quit the script
	die('Could not connect to database <br /> Please contact the site administrator.');
}
?>

I would appreciate any ideas.

[hezll]

seems that your mysql_select_db(D😎 is error
$db=mysql_select_db(DB,$conn); //repalce it for this ,$conn must be requird

[NogDog]

It's not necessarily a connection error, that's just what you have hard-coded in your die() statement. Try changing it to something like the following to get more info:

$result = mysql_query($query) or die(mysql_error()."<br />\n$query");

(For the production version you'll want to log the error rather than outputting database info to the user, and then output a more user-friendly message.)

[NogDog]

hezll wrote:

seems that your mysql_select_db(D😎 is error
$db=mysql_select_db(DB,$conn); //repalce it for this ,$conn must be requird

The second parameter is optional (though it certainly does not hurt to use it).

[daredevil14]

$db=mysql_select_db(DB,$conn); //repalce it for this ,$conn must be requird

well $conn is an optional argument... but try it!!

[frijole]

tried but unfortunately no go. Thanks for the idea though

[daredevil14]

hey do what NogDog said...

try to get the exact error by using the mysql_error() function... in every "die" statement, replace your string by mysql_error() function... and tell us the error result supplied by MySQL...

[frijole]

here is what I have now and it is acting as if it was successful, no error. It echoes "You have been successfully added" I don't get it.

<?php

//Database Settings
$host = "localhost";
$dbUser = "user";
$pass = "pass";
$DB = "db";

//MySQL Connection
$conn = mysql_connect($host, $dbUser, $pass);
if (!conn)
{
	// the connection failed so quit the script
	die('Could not connect !<br />Please contact the site administrator.');
}

$db = mysql_select_db($DB, $conn);
if (!db)
{
	// cannot connect to the database so quit the script
	die('Could not connect to database <br /> Please contact the site administrator.');
}

//this script registers a new user.

require_once 'functions.php';

$error = '';

if ($_POST['register'] == 1) {	//if the form has been submitted

$userName = $_POST['user'];
$pass = $_POST['pass'];
$rePass = $_POST['rePass'];

$query = 'SELECT * FROM users WHERE user_id="$userName"';
$insertUser = 'INSERT INTO users VALUES ($userName, $pass)';

if (empty($userName) || empty($pass) || empty($rePass)) {	//are any of the fields empty

	$error = "All fields must be filled out.";}

elseif ($pass != $rePass) {	//all fileds are filled out, are the values valid?

	$error = "The passwords do not match.";}

elseif (strlen($pass) < 4 || strlen($pass) > 12) {	//check if username is too long or too short

	$error = "You password must be between 4 and 12 characters long.";}

elseif (strlen($userName) < 4 || strlen($userName) > 12) {	//check if username is too long or too short

	$error = "You username must be between 4 and 12 characters long.";}

elseif (preg_replace('/[\w ]/', '', $userName)) {	//check for invalid characters in the username

	$error = "Your username may only contain letters, numbers, or underscores";}

else {	//check if username already exists

	$result = mysql_query($query) or mysql_error($conn);

	if (mysql_num_rows($result) > 0) {

		$error = "That username is already taken.";
		}

	else {	//add user to the database

		if (strlen($error) > 0) {

			showRegisterForm($error);

		} else {

		$result = mysql_query($insertUser) or mysql_error($conn);
		echo 'You have been added! sign-in and enjoy.'; 
		}
		}

} //show form and errors if applicable
}
	showRegisterForm($error);

?>

		 

[NogDog]

This will not output anything if there is an error:

$result = mysql_query($query) or mysql_error($conn);

You'll either need to die() if you want to use the "or" pattern:

$result = mysql_query($query) or die(mysql_error($conn));

[frijole]

here is the error i get:

errorUnknown column '$userName' in 'field list'

[daredevil14]

hey try to change this :

'SELECT * FROM users WHERE user_id="$userName"';

to

"SELECT * FROM users WHERE user_id='$userName'";

[frijole]

thats it! thanks so much. I really appreciate you guys taking the time to help me out.

[bradgrafelman]

Don't forget to mark this thread resolved.

Incidentally, there is another error in your code. This:

if (!db)

should instead be:

if (!$db)