PHP If Statement Help

IMP_TWI

Alright I'm confused with the code now lol I'm trying to get it to say "If attack = greater then 69 less then 100, pick random 1,2. Each shot does 50 damage, If attack is less then 69 but greater then 30, pick random 1-3, and Each attack = 30%.. If attack is greater then 5% but less then 30.. pick a random number 1/4, and each random shot = 10%.. Can someone help me out?🙂


if($attacks[weapon]=='4'){

if($attacks[ga]>69 and $attacks[ga]<101){

$rand=rand(1,4);

if($rand=='1'){

$shots='4';

$damage='100';

}

else

{

$shots='3';

$damage='75';

}

}

if($attacks[ga]<69 and $attacks[ga]>30){

$rand=rand(1,4);

if($rand==1){

$shots='3';

$damage='75';

}

else{

$shots='2';

$damage='50';

}

}

if($attacks[ga]>5 and $attacks[ga]<30){

$rand=rand(1,3);

if($rand=='1'){

$shots='1';

$damage='25';

}

elseif($rand=='2'){

$shots='0';

$damage='0';

}

else

{

$shots='0';

$damage='0';

}

}

}

laserlight

A few things to note:

String indices should be quoted. That is, you should write $attacks['weapon'] instead of $attacks[weapon]
Code should be indented to reflect levels of scope
Unless you are giving the general workings of an algorithm, you should systematically lay out your algorithm in pseudocode (or a flow chart, but that is not practical here) instead of lumping it into prose

IMP_TWI

 $r = mysql_fetch_array(mysql_query("SELECT * FROM user_skills where nickname='$attacks[attacker]'")) or die(mysql_error());

$attacks[ga]=$r[skill_gunaccuracy];

if($attacks[weapon]=='3'){

if($attacks[ga]>69 and $attacks[ga]<101){

$rand=rand(1,4);

if($rand=='1'){

$shots='10';

$damage='30';

}

else

{

$shots='5';

$damage='15';

}

}

if($attacks[ga]<69 and $attacks[ga]>30){

$rand=rand(1,4);

if($rand==1){

$shots='7';

$damage='21';

}

else{

$shots='4';

$damage='12';

}

}

if($attacks[ga]>5 and $attacks[ga]<30){

$rand=rand(1,3);

if($rand=='1'){

$shots='2';

$damage='6';

}

elseif($rand=='2'){

$shots='1';

$damage='3';

}

else

{

$shots='0';

$damage='0';

}

}

}

if($attacks[weapon]=='4'){

if($attacks[ga]>69 and $attacks[ga]<101){

$rand=rand(1,4);

if($rand=='1'){

$shots='4';

$damage='100';

}

else

{

$shots='3';

$damage='75';

}

}

if($attacks[ga]<69 and $attacks[ga]>30){

$rand=rand(1,4);

if($rand==1){

$shots='3';

$damage='75';

}

else{

$shots='2';

$damage='50';

}

}

if($attacks[ga]>5 and $attacks[ga]<30){

$rand=rand(1,3);

if($rand=='1'){

$shots='1';

$damage='25';

}

elseif($rand=='2'){

$shots='0';

$damage='0';

}

else

{

$shots='0';

$damage='0';

}

}

}

if($attacks[weapon]=='2'){

if($attacks[ga]>69 and $attacks[ga]<101){

$rand=rand(1,4);

if($rand=='1'){

$shots='5';

$damage='20';

}

else

{

$shots='2';

$damage='10';

}

}

if($attacks[ga]<69 and $attacks[ga]>30){

$rand=rand(1,4);

if($rand==1){

$shots='5';

$damage='20';

}

else{

$shots='2';

$damage='10';

}

}

if($attacks[ga]>5 and $attacks[ga]<30){

$rand=rand(1,4);

if($rand=='1'){

$shots='1';

$damage='5';

}

else

{

$shots='0';

$damage='0';

}

}

}

if($attacks[weapon]=='1'){

if($attacks[ga]>69 and $attacks[ga]<101){

$rand=rand(1,4);

if($rand=='1'){

$shots='5';

$damage='20';

}

else

{

$shots='3';

$damage='15';

}

}

if($attacks[ga]<69 and $attacks[ga]>30){

$rand=rand(1,4);

if($rand==1){

$shots='5';

$damage='20';

}

else{

$shots='2';

$damage='10';

}

}

if($attacks[ga]>5 and $attacks[ga]<30){

$rand=rand(1,4);

if($rand<'3'){

$shots='1';

$damage='5';

}

else

{

$shots='0';

$damage='0';

}

}

}

That's basically the code. It's giving each weapon damage power/amount of times hit depending on attack accuracy.

laserlight

That's basically the code. It's giving each weapon damage power/amount of times hit depending on attack accuracy.

Giving the code can help, but in this case I am talking about giving your algorithm in pseudocode. For example:

if attack is in the range of (69, 100)
    if 1/4 chance
        shots = 4
        damage = 100
    else
        shots = 3
        damage = 75
else if attack is in the range of (30, 69]
    if 1/4 chance
        shots = 3
        damage = 75
    else
        shots = 2
        damage = 50
else if attack is in the range of (5, 30]
    if 1/3 chance
        shots = 1
        damage = 25
    else
        shots = 0
        damage = 0
else
    shots = 0
    damage = 0

The above can very easily be translated into:

if (69 < $attacks['ga'] && $attacks['ga'] < 100) {
    if (mt_rand(0, 3) == 0) {
        $shots = 4;
        $damage = 100;
    } else {
        $shots = 3;
        $damage = 75;
    }
} else if (30 < $attacks['ga'] && $attacks['ga'] <= 69) {
    if (mt_rand(0, 3) == 0) {
        $shots = 3;
        $damage = 65;
    } else {
        $shots = 2;
        $damage = 50;
    }
} else if (5 < $attacks['ga'] && $attacks['ga'] <= 30) {
    if (mt_rand(0, 2) == 0) {
        $shots = 1;
        $damage = 25;
    } else {
        $shots = 0;
        $damage = 0;
    }
} else {
    $shots = 0;
    $damage = 0;
}

After that, we can apply optimisations, if any.

retro

You might want to use SWITCH instead of IF.

For example:

<?php

//this line is to test the switch
$attack = rand(1,100);

switch (TRUE)
{
  case ($attack > 69 AND $attack <= 100):
    $rand = rand(1,2);
    $damage = 50;
    break;
  case ($attack > 30 AND $attack <= 69):
    $rand = rand(1,3);
    $damage = 30;
    break;
  case ($attack > 5 AND $attack <= 30):
    $rand = rand(1,4);
    $damage = 10;
    break;
  default:
    $rand = "miss!";
    $damage = 0;
}

//check results
echo "Attack: " . $attack . "<br />";
echo "Rand: " . $rand . "<br />";
echo "Damage: " . $damage . "<br />";

?>

Incidentally, what you said in your description and what was in your code were doing two different things! It was a bit confusing that you mentioned percentages sometimes, but not all times. That could be construed as $damage = 50% of something, rather than $damage = 50.

Also, you said one range should be greater than 69, another range should be less than 69. What happens if the value IS 69? To account for this, I used <= in my code. I based my code on your description, so where variables aren't correctly named, you can adjust.

Oh, and if you're getting confused by your code, indent it! Hopefully you're using a PHP editor! I like to indent for each curly bracket.

Hope this helps!