[RESOLVED] undefined function problem

[sp33d1]

Ok i keep getting this error everytime i try seperating a code i just cant understand why the code starts out like this

<?php

define ( 'LIMIT', 20 );

mysql_connect ( 'localhost', 'USER', 'PASS' )
or die(mysql_error());

mysql_select_db ( 'layoutst_graphics' )
or die(mysql_error());

function getCategories ()
{
$fetch = mysql_query("SELECT * FROM categories LEFT JOIN parents ON ( categoryParentID = parentID ) GROUP BY parentName, categoryName");

$parentName = "";

while ( $row = mysql_fetch_assoc ( $fetch ) )
{
	if ( $parentName != $row['parentName'] )
	{
		echo '<p><strong><a href="/Graphics/'.$row['parentPerm'].'.html">'.$row['parentName'].'</a></strong></p>';
		$parentName = $row['parentName'];
	}

	echo '<a href="/Graphics/'. $row['parentPerm'].'-' . $row['categoryPerm'] . '.html">'. $row['categoryName'] . '</a><br />';
}

}

function makePermalink ( $i )
{
$url = ereg_replace('[^A-Za-z0-9]', ' ', $i);
$url = preg_replace('/\s\s+/', ' ', $url);
$url = str_replace(' ', '_', $url);
$url = trim_end_thing($url);
$url = strtolower($url);
return $url;
}

function trim_end_thing ($text)
{
if ( $text{strlen($text) -1} == "_" )
{
$text = substr_replace($text, "", strlen($text) -1);
}

return $text;

}

?> i try seperating the code to just put the mysql connect and moving "function getCategories ()" and everything under to another side of the page to show up where i need it to show up to but the problem is i keep getting this error "
Fatal error: Call to undefined function: getcategories() in /home/layoutst/public_html/Graphics/index.php on line 14" this is what's on line 14 index.php "getCategories();" i was just wondering is this what is causing it any help would be appreciated.

[laserlight]

You never call the function, so the error does not make sense.

Post in php bbcode tags the smallest and simplest script that demonstrates the error.

[NogDog]

Check your upper-/lower-case usage. The function definition spells it "getCategories()", while the error message spells it "getcategories()".

[sp33d1]

ok here's the db code what i want to do is take everything under function getCategories () including function getCategories () to move the page links but when i try moving it to another file it gives me a error saying Fatal error: Call to undefined function: getcategories() in /home/layoutst/public_html/Graphics/index.php on line 14

here's what in index.php

This is index.php

require 'db.php';





getCategories(); //this is line 14 where the error is occuring

echo '<h2>Latest 10 Added Graphics</h2>';
echo '<div align="center">';
$fetch = mysql_query("SELECT * FROM graphics LEFT JOIN categories ON ( graphicCategoryID = categoryID ) LEFT JOIN parents ON ( graphicParentID = parentID ) ORDER BY graphicID DESC LIMIT 10");
while ( $row = mysql_fetch_assoc ( $fetch ) )
{
	if ( is_numeric ( $row['graphicID'] ) )
	{

?>
<p>
<a href="/Graphics/<?=$row['parentPerm'];?>-<?=$row['categoryPerm'];?>.html"><img src="<?=$row['graphicURL'];?>" alt="" border="0" /></a>
<h3><?=$row['graphicName'];?> myspace graphics<br /><a href="/Graphics/<?=$row['parentPerm'];?>-<?=$row['categoryPerm'];?>.html"><?=$row['categoryName'];?></a></h3>
</p>
<?

This is db.php

<?php

define ( 'LIMIT', 20 );

mysql_connect ( 'localhost', 'USER', 'PASS' )
	or die(mysql_error());

mysql_select_db ( 'layoutst_graphics' )
	or die(mysql_error());

function getCategories ()
{
	$fetch = mysql_query("SELECT * FROM categories LEFT JOIN parents ON ( categoryParentID = parentID ) GROUP BY parentName, categoryName");

$parentName = "";

while ( $row = mysql_fetch_assoc ( $fetch ) )
{
	if ( $parentName != $row['parentName'] )
	{
		echo '<p><strong><a href="/Graphics/'.$row['parentPerm'].'.html">'.$row['parentName'].'</a></strong></p>';
		$parentName = $row['parentName'];
	}

	echo '<a href="/Graphics/'. $row['parentPerm'].'-' . $row['categoryPerm'] . '.html">'. $row['categoryName'] . '</a><br />';
}
}

function makePermalink ( $i )
{
	$url = ereg_replace('[^A-Za-z0-9]', ' ', $i);
	$url = preg_replace('/\s\s+/', ' ', $url);
	$url = str_replace(' ', '_', $url);
	$url = trim_end_thing($url);
	$url = strtolower($url);
	return $url;
}

function trim_end_thing ($text)
{
	if ( $text{strlen($text) -1} == "_" )
	{
		$text = substr_replace($text, "", strlen($text) -1);
	}

return $text;
}

?>

where im trying to copy the code into is my footer which is the navigation
here's the code

						<h2>Categories</h2>

						<ul>

							<li><a href="http://layoutstreet.com/rap-myspace-layouts/">Rap Layouts</a></li>

							<li><a href="http://layoutstreet.com/money-myspace-layouts/">Money Layouts</a></li>

							<li><a href="http://layoutstreet.com/quotes-myspace-layouts/">Quote Layouts</a></li>

                            <li><a href="http://layoutstreet.com/fashion-myspace-layouts/">Fashion Layouts</a></li>

                            <li><a href="http://layoutstreet.com/cartoons-myspace-layouts/">Cartoon Layouts</a></li>

							<li><a href="http://layoutstreet.com/models-myspace-layouts/">Model Layouts</a></li>

							<li><a href="http://layoutstreet.com/sports-myspace-layouts/">Sports Layouts</a></li>

							<li><a href="http://layoutstreet.com/miscellaneous-myspace-layouts/">Misc Layouts</a></li>

                     	<li><a href="http://layoutstreet.com/cars-myspace-layouts/">Car Layouts</a></li>
function getCategories ()
{
	$fetch = mysql_query("SELECT * FROM categories LEFT JOIN parents ON ( categoryParentID = parentID ) GROUP BY parentName, categoryName");

$parentName = "";

while ( $row = mysql_fetch_assoc ( $fetch ) )
{
	if ( $parentName != $row['parentName'] )
	{
		echo '<p><strong><a href="/Graphics/'.$row['parentPerm'].'.html">'.$row['parentName'].'</a></strong></p>';
		$parentName = $row['parentName'];
	}

	echo '<a href="/Graphics/'. $row['parentPerm'].'-' . $row['categoryPerm'] . '.html">'. $row['categoryName'] . '</a><br />';
}
}

function makePermalink ( $i )
{
	$url = ereg_replace('[^A-Za-z0-9]', ' ', $i);
	$url = preg_replace('/\s\s+/', ' ', $url);
	$url = str_replace(' ', '_', $url);
	$url = trim_end_thing($url);
	$url = strtolower($url);
	return $url;
}

function trim_end_thing ($text)
{
	if ( $text{strlen($text) -1} == "_" )
	{
		$text = substr_replace($text, "", strlen($text) -1);
	}

return $text;
}

but it keeps giving me the error Fatal error: Call to undefined function: getcategories() in /home/layoutst/public_html/Graphics/index.php on line 14
hope this help clear it up.

[laserlight]

Check your upper-/lower-case usage. The function definition spells it "getCategories()", while the error message spells it "getcategories()".

That should not be the problem since function names in PHP are case insensitive.

ok here's the db code what i want to do is take everything under function getCategories () including function getCategories () to move the page links but when i try moving it to another file it gives me a error saying Fatal error: Call to undefined function: getcategories() in /home/layoutst/public_html/Graphics/index.php on line 14

The getCategories() call in index.php does not appear to be on line 14. You really need to be clear on what you are trying to do, and post the smallest and simplest code that demonstrates the problem.

[sp33d1]

laserlight wrote:

That should not be the problem since function names in PHP are case insensitive.

The getCategories() call in index.php does not appear to be on line 14. You really need to be clear on what you are trying to do, and post the smallest and simplest code that demonstrates the problem.

Ok what im trying to do is move part of the code into another file

<?php

define ( 'LIMIT', 20 );

mysql_connect ( 'localhost', 'USER', 'PASS' )
	or die(mysql_error());

mysql_select_db ( 'layoutst_graphics' )
	or die(mysql_error());

[COLOR="Red"]function getCategories ()
{
	$fetch = mysql_query("SELECT * FROM categories LEFT JOIN parents ON ( categoryParentID = parentID ) GROUP BY parentName, categoryName");

$parentName = "";

while ( $row = mysql_fetch_assoc ( $fetch ) )
{
	if ( $parentName != $row['parentName'] )
	{
		echo '<p><strong><a href="/Graphics/'.$row['parentPerm'].'.html">'.$row['parentName'].'</a></strong></p>';
		$parentName = $row['parentName'];
	}

	echo '<a href="/Graphics/'. $row['parentPerm'].'-' . $row['categoryPerm'] . '.html">'. $row['categoryName'] . '</a><br />';
}
}

function makePermalink ( $i )
{
	$url = ereg_replace('[^A-Za-z0-9]', ' ', $i);
	$url = preg_replace('/\s\s+/', ' ', $url);
	$url = str_replace(' ', '_', $url);
	$url = trim_end_thing($url);
	$url = strtolower($url);
	return $url;
}

function trim_end_thing ($text)
{
	if ( $text{strlen($text) -1} == "_" )
	{
		$text = substr_replace($text, "", strlen($text) -1);
	}

return $text;
}
[/COLOR]
?>

the color that is red is the part of the code im trying to seperate and put it into another file the file inputs the red part of the code in another place
which is here in my footer im using it for a navigation but everytime i seperate it i get the error Fatal error: Call to undefined function: getcategories() in /home/layoutst/public_html/Graphics/index.php on line 14 the index is up top if you need to see the error line 14 is the part that has "
getCategories();" in index.php

<?php function getCategories ()
{
	$fetch = mysql_query("SELECT * FROM categories LEFT JOIN parents ON ( categoryParentID = parentID ) GROUP BY parentName, categoryName");

$parentName = "";

while ( $row = mysql_fetch_assoc ( $fetch ) )
{
	if ( $parentName != $row['parentName'] )
	{
		echo '<p><strong><a href="/Graphics/'.$row['parentPerm'].'.html">'.$row['parentName'].'</a></strong></p>';
		$parentName = $row['parentName'];
	}

	echo '<a href="/Graphics/'. $row['parentPerm'].'-' . $row['categoryPerm'] . '.html">'. $row['categoryName'] . '</a><br />';
}
}

function makePermalink ( $i )
{
	$url = ereg_replace('[^A-Za-z0-9]', ' ', $i);
	$url = preg_replace('/\s\s+/', ' ', $url);
	$url = str_replace(' ', '_', $url);
	$url = trim_end_thing($url);
	$url = strtolower($url);
	return $url;
}

function trim_end_thing ($text)
{
	if ( $text{strlen($text) -1} == "_" )
	{
		$text = substr_replace($text, "", strlen($text) -1);
	}

return $text;
}
 ?>

[laserlight]

Ah, so originally, getCategories() was defined in db.php. You moved the definition of getCategories() to another file. In that case, did you include this new file into index.php? If not, with respect to index.php, it is undefined, and thus you get the error.

[sp33d1]

laserlight wrote:

Ah, so originally, getCategories() was defined in db.php. You moved the definition of getCategories() to another file. In that case, did you include this new file into index.php? If not, with respect to index.php, it is undefined, and thus you get the error.

No i moved

function getCategories () // error is coming from here index.php & line 14

from the db.php file and everything under it so i could move the link code the error is coming from index.php and thats why i don't understand why thats part of the index at the bottom it requires the file "footer.php" which is where the red part of the db.php code is see the problem is the database is connecting but for some odd reason getCategories(); is giving a error from index.php

getCategories();

echo '<h2>Latest 10 Added Graphics</h2>';
echo '<div align="center">';
$fetch = mysql_query("SELECT * FROM graphics LEFT JOIN categories ON ( graphicCategoryID = categoryID ) LEFT JOIN parents ON ( graphicParentID = parentID ) ORDER BY graphicID DESC LIMIT 10");
while ( $row = mysql_fetch_assoc ( $fetch ) )
{
	if ( is_numeric ( $row['graphicID'] ) )
	{

?>

[laserlight]

from the db.php file and everything under it so i could move the link code the error is coming from index.php and thats why i don't understand why thats part of the index at the bottom it requires the file "footer.php" which is where the red part of the db.php code is see the problem is the database is connecting but for some odd reason getCategories(); is giving a error from index.php

Eh, please try and use proper punctuation so we can understand you better.

Anyway, when I say function definition, I mean:

function getCategories()
{
    // ...
}

The function call would be:

getCategories();

In index.php, you call the getCategories() function. Where is that function defined?

[sp33d1]

in footer.php it's the part i took from db.php

[sp33d1]

hm, maybe thats the problem.. should i define it before i try moving it?

[laserlight]

in footer.php it's the part i took from db.php

Okay. Is footer.php included in index.php?

hm, maybe thats the problem.. should i define it before i try moving it?

If you call it from a file, it needs to be defined in that file, or in a file included in that file.

[sp33d1]

yes but at the bottom of the page i was wondering did that part matter?

[laserlight]

yes but at the bottom of the page i was wondering did that part matter?

hmm... apparently it does. Normally I define functions before using them, and since PHP 4 functions can be called before their point of definition, but apparently this does not apply if they are defined in another file.

My suggestion is to separate the functions into yet another file. So you include db.php for say, your database connection library, then you include this new file for getCategories() and related functions, and then at the end you include your footer (if you still need it).

[sp33d1]

you mind breaking that up for me out of this code
the define is in there i just need you to help me seperate it in the order you just said

<?php

define ( 'LIMIT', 20 );

mysql_connect ( 'localhost', 'USER', 'PASS' )
	or die(mysql_error());

mysql_select_db ( 'layoutst_graphics' )
	or die(mysql_error());

function getCategories ()
{
	$fetch = mysql_query("SELECT * FROM categories LEFT JOIN parents ON ( categoryParentID = parentID ) GROUP BY parentName, categoryName");

$parentName = "";

while ( $row = mysql_fetch_assoc ( $fetch ) )
{
	if ( $parentName != $row['parentName'] )
	{
		echo '<p><strong><a href="/Graphics/'.$row['parentPerm'].'.html">'.$row['parentName'].'</a></strong></p>';
		$parentName = $row['parentName'];
	}

	echo '<a href="/Graphics/'. $row['parentPerm'].'-' . $row['categoryPerm'] . '.html">'. $row['categoryName'] . '</a><br />';
}
}

function makePermalink ( $i )
{
	$url = ereg_replace('[^A-Za-z0-9]', ' ', $i);
	$url = preg_replace('/\s\s+/', ' ', $url);
	$url = str_replace(' ', '_', $url);
	$url = trim_end_thing($url);
	$url = strtolower($url);
	return $url;
}

function trim_end_thing ($text)
{
	if ( $text{strlen($text) -1} == "_" )
	{
		$text = substr_replace($text, "", strlen($text) -1);
	}

return $text;
}

?>

Thank you for all your help i really appreciate it.

[laserlight]

If that is all there is to it, then it already is suitable as a header file. Just include it at the top instead of the bottom, so that it is included before any function is called.

[sp33d1]

oh wow thanks i see the problem now i wasn't closing the curly bracket when i was trying to separate the code... thanks!!!

[laserlight]

No problem. Remember to mark this thread as resolved using the thread tools.

[sp33d1]

one last thing sorry about this im getting this error from graphics_footer.php

  Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in /home/layoutst/public_html/graphics_footer.php on line 37

<?php


while ( $row = mysql_fetch_assoc ( $fetch ) ) // Line 37
{

if ( $parentName != $row['parentName'] )
	{
		echo '<p><strong><a href="/Graphics/'.$row['parentPerm'].'.html">'.$row['parentName'].'</a></strong></p>';
		$parentName = $row['parentName'];
	}

	echo '<a href="/Graphics/'. $row['parentPerm'].'-' . $row['categoryPerm'] . '.html">'. $row['categoryName'] . '</a><br />';
}


function makePermalink ( $i )
{
	$url = ereg_replace('[^A-Za-z0-9]', ' ', $i);
	$url = preg_replace('/\s\s+/', ' ', $url);
	$url = str_replace(' ', '_', $url);
	$url = trim_end_thing($url);
	$url = strtolower($url);
	return $url;
}

function trim_end_thing ($text)
{
	if ( $text{strlen($text) -1} == "_" )
	{
		$text = substr_replace($text, "", strlen($text) -1);
	}

return $text;
}

?>

this is the last one should be a peace of cake for you

[laserlight]

Where is $fetch defined? It should be a valid MySQL result resource.