Good practice??

[Robert_B_]

Hello,
I'm generating this data for a graphic class for stats and it's working good, but I need to know if this is a good practice or if this is too slow.

// Unique Visitors
$sql  =  "SELECT DISTINCT (ip) FROM $dbtbl WHERE browser NOT LIKE ('%bot%') AND browser NOT LIKE ('%slurp%') ORDER BY ip" ;  

$results  =  mysql_query ( $sql ) or die(mysql_error().sql);;  

$uni_vis  =  mysql_num_rows ( $results );

// Unique Visitors
$sql  =  "SELECT (ip) FROM $dbtbl WHERE browser NOT LIKE ('%bot%') AND browser NOT LIKE ('%slurp%') ORDER BY ip" ;  

$results  =  mysql_query ( $sql ) or die(mysql_error().sql);;  

$total_vis  =  mysql_num_rows ( $results );  

// End Populate Visitors Hits

// --- Check Visitor's Browser --- //

// Explorer
$sql  =  "SELECT DISTINCT (ip) FROM $dbtbl WHERE browser LIKE ('%MSIE%')" ;  

$results  =  mysql_query ( $sql );  

$ms  =  mysql_num_rows ( $results );  

// Safari
$sql  =  "SELECT DISTINCT (ip) FROM $dbtbl WHERE browser LIKE ('%Safari%')" ;  

$results  =  mysql_query ( $sql );  

$safari  =  mysql_num_rows ( $results );  

// Netscape
$sql  =  "SELECT DISTINCT (ip) FROM $dbtbl WHERE browser LIKE ('%Netscape%')" ;  

$results  =  mysql_query ( $sql );  

$netscape  =  mysql_num_rows ( $results );  

// Firefox
$sql  =  "SELECT DISTINCT (ip) FROM $dbtbl WHERE browser LIKE ('%Firefox%')" ;  

$results  =  mysql_query ( $sql );  

$firefox  =  mysql_num_rows ( $results );

// Other/Unknown
$sql  =  "SELECT DISTINCT (ip) FROM $dbtbl WHERE browser NOT LIKE ('%MSIE%') AND browser NOT LIKE ('%Safari%') AND browser NOT LIKE ('%Netscape%') AND browser NOT LIKE ('%Firefox%') AND browser NOT LIKE ('%bot%') AND browser NOT LIKE ('%slurp%')" ;  

$results  =  mysql_query ( $sql );  

$other_brow  =  mysql_num_rows ( $results );

// --- End Check Visitor's Browser --- //

// --- Check If Is A Bot --- //

// Google
$sql  =  "SELECT (ip) FROM $dbtbl WHERE browser LIKE ('%Googlebot%')" ;  

$results  =  mysql_query ( $sql );  

$google_bot  =  mysql_num_rows ( $results );

// Yahoo!
$sql  =  "SELECT (ip) FROM $dbtbl WHERE browser LIKE ('%Yahoo! Slurp%')" ;  

$results  =  mysql_query ( $sql );  

$yahoo_bot  =  mysql_num_rows ( $results );

// MSN
$sql  =  "SELECT (ip) FROM $dbtbl WHERE browser LIKE ('%msnbot%')" ;  

$results  =  mysql_query ( $sql );  

$msn_bot  =  mysql_num_rows ( $results );

// Other Bot
$sql  =  "SELECT (ip) FROM $dbtbl WHERE browser LIKE ('%bot%') AND browser NOT LIKE ('%Googlebot%') AND browser NOT LIKE ('%msnbot%')" ;  

$results  =  mysql_query ( $sql );  

$other_bot  =  mysql_num_rows ( $results );

// --- Check If Is A Bot --- //

// --- Check Where User Came From --- //

// Other site Referer
$sql = "SELECT (ip) FROM $dbtlb WHERE referer NOT LIKE ('%search%') AND referer NOT LIKE ('$sitename')" ;
$results = mysql_query ( $sql );
$site_ref = mysql_num_rows ( $results );

// Search Engine Referer
$sql = "SELECT (ip) FROM $dbtlb WHERE referer LIKE ('%search%')" ;
$results = mysql_query ( $sql );
$se_ref = mysql_num_rows ( $results );

// --- End Check Where User Came From --- //

// --- Check Operating System --- //

// Windows
$sql  =  "SELECT DISTINCT (ip) FROM $dbtbl WHERE browser LIKE ('%Windows%')" ;  

$results  =  mysql_query ( $sql );  

$windows  =  mysql_num_rows ( $results );  

// Macintosh
$sql  =  "SELECT DISTINCT (ip) FROM $dbtbl WHERE browser LIKE ('%Macintosh%')" ;  

$results  =  mysql_query ( $sql );  

$mac  =  mysql_num_rows ( $results ); 

// Linux
$sql  =  "SELECT DISTINCT (ip) FROM $dbtbl WHERE browser LIKE ('%Linux%')" ;  

$results  =  mysql_query ( $sql );  

$linux  =  mysql_num_rows ( $results ); 

// Other/Unknown
$sql  =  "SELECT DISTINCT (ip) FROM $dbtbl WHERE browser NOT LIKE ('%Windows%') AND browser NOT LIKE ('%Macintosh%') AND browser NOT LIKE ('%Linux%')" ;  

$results  =  mysql_query ( $sql );  

$other_os  =  mysql_num_rows ( $results );

// --- End Check Operating System --- //

Thank you all for your help

[laserlight]

You should use SELECT COUNT(DISTINCT ip) instead of using SELECT DISTINCT (ip) with mysql_num_rows(). Likewise SELECT COUNT(ip) or SELECT COUNT(*) instead of SELECT (ip) with mysql_num_rows().

[Robert_B_]

Thank you Laserlight, I'm using Libchart and does not let me use COUNT()

[laserlight]

I'm using Libchart and does not let me use COUNT()

The only thing preventing you from using the COUNT() is the database and the fact that you have to modify the PHP code to replace the use of mysql_num_rows() with mysql_result(). Libchart should have nothing to do with it, other than that it provides the data in the database or processes the data that you retrieve in the required format.