Code Help please

[TaosBill]

Trying to make a dynamic sql update statement from the string $headers.

$headers = 'company,approved';
/The results would be:
a string containing: company='$company',approved=$'approved'
/
$upd_columns = explode(",", $headers);
$count_total = count($upd_columns);
for ($counter=0; $counter<$count_total; $counter++){
$line = each ($upd_columns);
echo "key ->" .$line[key]." value ->".$line[value]." <br />";
$col_fld = $line[value];
$col_var = ${$col_fld};
$colname = '';
$colname .= $col_fld;
$colname .= " = '";
$colname .= ${$col_var};
// this doesn't work!
$colname .= "',";
echo $colname."<br>";

$sql_upd .= $colname;
}
Thanks in advance

[timus]

This is pretty basic but it might help. Not really sure where you are getting the values from for the columns you wish to update and I suspect its a problem with the scope of those values but to test, i just populated them before going into the the loop

$company = 'comp_name';
$approved = 'app_status';

$headers = 'company,approved';
$upd_columns = explode(",", $headers);

$sql = 'update table set ';
$comma = '';

foreach($upd_columns as $val)
{
	$sql .= $comma . $val . ' = "' . ${$val} . '"';
	$comma = ',';	 	
}

print $sql;

Hope it helps
Tim

[TaosBill]

Thanks Tim,
I changed the code to single quotes around the sql column value
and echo $sql displays
company = '',approverd= ''
the ${$val} didn't produce '$columnname'

[TaosBill]

This is the test code
<?
$headers = 'company_id,emp_id,approver_login,approver_passwrd,approver_email,hrmanager_emp_id,ssn,hire_date,perf_rating_date,emp_status,hourly_rate,incentive_pay,locn1,salary_eff_date';
$upd_columns = explode(",", $headers);
$comma = '';
foreach($upd_columns as $val) {
if ( ($val == 'company_id') OR ($val == 'emp_id')){
// no update on the primary keys
}else {

$sql .= $comma . $val . " = '" . ${$val} . "'";
$comma = ',';
}

}

echo $sql."<br>";
?>

[timus]

Hey

Are you using a form to populate these values? if so try $_POST[$val] instead of ${$val}

Tim