Feedback syntax

gordonas

I create this feedback file below and I get, offcourse, all the results in one line.

<?php
$message = $REQUEST[‘message’] ;
$message .= "username: " . $REQUEST['username'] ;
$message .= "password: " . $REQUEST['password'] ;
$message .= "home: " . $REQUEST['home'] ;
$message .= "away: " . $REQUEST['away'] ;
$message .= "1: " . $REQUEST['Assos'] ;
$message .= "X: " . $REQUEST['Xi'] ;
$message .= "2: " . $REQUEST['2'] ;

mail( "myname@hotmail.com", $username,
$message,"From: $username");
header("Location: http://www.mysite.gr/thankyou.html");
?>

Two questions...

How can I get ever field in a different line, like:
username:
password:
home:
away:
1:
X:
2:

at mail command can I put to "From" many fields? Now I have $username but I would like to put two more fields.

Thank you...

djheru

<?php
$message = $_REQUEST[‘message’] ;
$message .= "\nusername: " . $_REQUEST['username'] ;
$message .= "\npassword: " . $_REQUEST['password'] ;
$message .= "\nhome: " . $_REQUEST['home'] ;
$message .= "\naway: " . $_REQUEST['away'] ;
$message .= "\n1: " . $_REQUEST['Assos'] ;
$message .= "\nX: " . $_REQUEST['Xi'] ;
$message .= "\n2: " . $_REQUEST['2'] ;

mail( "myname@hotmail.com", $username,
$message,"From: $username");
header("Location: http://www.mysite.gr/thankyou.html");
?>

\n is the newline character in Linux. In Windows, I believe it is \r

Also, very very dangerous to allow user input in the form of $_REQUEST variables to interact directly with your server.

gordonas

If I replace request with post will be better?

PartialReptile

This link might help you with security from mail.

http://www.phpbuilder.com/columns/ian_gilfillan20060412.php3?aid=1133

In simple terms (because that's all I understand myself 🙂 ) $REQUEST is a mixture of both $POST and $GET - if you're info is only going to be sent from a form that is set to post then you only need to use $POST and don't need to use $_REQUEST.

You should also look at sanitising the info that is collected (removing unwanted info such as inserted code etc.). Again, the link above will help you with this.