[RESOLVED] Formmailer not working properly.

[rrohljr]

This is the php formmailer script from modules/apply.php:

<?php
if (!$RealName) {echo "You must enter your Real Name."; } else {
if (!$Age) {echo "You must enter your Age."; } else { 
if (!$Character_Alias) {echo "You must enter your Characters Name."; } else { 
if (!$Character_Class) {echo "You must enter your Characters Class."; } else { 
if (!$Character_Level) {echo "You must enter your Characters Level."; } else { 
if (!$Character_Race) {echo "You must enter your Characters Race."; } else { 
if (!$SundayAvailability) {echo "You must enter your availability on Sundays."; } else { 
if (!$MondayAvailability) {echo "You must enter your availability on Mondays."; } else { 
if (!$TuesdayAvailability) {echo "You must enter your availability on Tuesdays."; } else { 
if (!$WednesdayAvailability) {echo "You must enter your availability on Wednesdays."; } else { 
if (!$ThursdayAvailability) {echo "You must enter your availability on Thursdays."; } else { 
if (!$EmailAddress) {echo "You must enter your Email Address."; } else { 
if (!$AIMSN) {echo "You must enter your AIM Screen Name, or type N/A."; } else { 
if (!$MSNSN) {echo "You must enter your MSN Screen Name, or type N/A."; } else { 
if (!$YSN) {echo "You must enter your Yahoo! Screen Name, or type N/A."; } else { 
if (!$Profession1) {echo "You must enter your Primary Profession."; } else { 
if (!$Profession1_Level) {echo "You must enter your Primary Profession's Level."; } else { 
if (!$Profession2) {echo "You must enter your Secondary Profession."; } else { 
if (!$Profession2_Level) {echo "You must enter your Secondary Profession's Level."; } else { 
if (!$Guild_History) {echo "You must enter your Recent Guild History"; } else { 
if (!$Expectations) {echo "You must enter your Expectations of Mediocracy"; } else {
if (!$GearSummary) {echo "You must summarize your gear for us."; } else { 
if (!$BCRaidExperience) {echo "You must enter your Raid Experience in the Burning Crusade"; } else { 

PRINT "Thank you for applying to Mediocracy!";
$EmailTo = '' . ', ';
$EmailTo = '' . ', ';
$EmailTo = '' . ', ';
$EmailTo = '' . ', ';
$EmailTo = '[e-mail]' . ', ';
$Subject = "Mediocracy Application: ".$_POST['Character_Level'].$_POST['Character_Class'].$_POST['Character_Alias'];

$Body .= "\n \n Real Name: ".$_POST['RealName'];
$Body .= "\n Age: ".$_POST['Age'];
$Body .= "\n \n Character Name: ".$_POST['Character_Alias'];
$Body .= "\n Character Race/Class: ".$_POST['Character_Race'].' '.$_POST['Character_Class'];
$Body .= "\n Character Level: ".$_POST['Character_Level'];

$Body .= "\n \n Life Status: ".$_POST['Status'];

$Body .= "\n \n Days Available to Raid: \n";
$Body .= " Sunday Availability: ".$_POST['SundayAvailability'];
$Body .= "\n Monday Availability: ".$_POST['MondayAvailability'];
$Body .= "\n Tuesday Availability: ".$_POST['TuesdayAvailability'];
$Body .= "\n Wednesday Availability: ".$_POST['WednesdayAvailability'];
$Body .= "\n Thursday Availability: ".$_POST['ThursdayAvailability'];

$Body .= "\n \n Contact Information: \n";
$Body .= "\n EMail Address: ".$_POST['EmailAddress'];
$Body .= "\n AIM Screen Name: ".$_POST['AIMSN'];
$Body .= "\n MSN Screen Name: ".$_POST['MSNSN'];
$Body .= "\n Yahoo! Screen Name: ".$_POST['YSN'];

$Body .= "\n \n Profession 1: ".$_POST['Profession1'];
$Body .= "\n Profession 1 Level: ".$_POST['Profession1_Level'];
$Body .= "\n Profession 2: ".$_POST['Profession2'];
$Body .= "\n Profession 2 Level: ".$_POST['Profession2_Level'];

$Body .= "\n \n Other Guilds and Servers: ".$_POST['Guild_History'];

$Body .= "\n \n What do you expect?: ".$_POST['Expectations'];

$Body .= "\n \n Gear Summary: ".$_POST['GearSummary'];

$Body .= "\n \n BC Raid Experience: ".$_POST['BCRaidExperience'];

$Body .= "\n \n \n \n \n \n";

mail($EmailTo,$Subject,$Body,"From: [e-mail]");}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
?>

When I submit the application and post it to this page that contains the above script, my error appears... it says "You must enter your Real Name." However, this error appears whether or not I have anything submitted into the field or not. I suspect I'm doing something wrong in the coding. Perhaps the script is too elaborate and I should just be using an if-else statement... I don't know. I'm new to this stuff, and I'm just looking to accomplish something simple... making every field required on the form.

You can test it out @ http://mediocracyguild.com/apply.php if it helps with trying to figure out what's wrong.

[NogDog]

Looks like it's depending upon [man]register_globals[/man] being turned on, which - obviously - is not a good way to develop a PHP program for wide distribution. (Also, it will not even be an option in PHP 6.) Try adding the following to the very start of the script:

<?php
import_request_variables('p');

[rrohljr]

Didn't work. I thought register_globals were used to authenticate sessions, etc.? Basically, I'm not requiring a log in to the website. I just want to basically take the form from apply.php and post it to modules/apply.php to validate all the information was filled in, and then send the information out in an email.

Any other ideas?

[NogDog]

Nope. register_globals is used to take inputs from post, get, and/or cookie data and automatically create global variables from them. Without it on, you would have to access the values from the form via the $POST or $GET array as applicable (which is the 'best practice' way to do it now). Thus I was assuming that since the script starts by assuming $RealName is already set instead of referencing $_POST['RealName'], that it was depending upon register_gobals being turned on.

To help debug what's going on, you could try adding the following to start of the script just to find out what (if any) form data is being received, and perhaps post the results here to help us see if there is some disconnect in form element names or such:

<?php
echo "<pre>";
echo ini_get('register_globals') . "\n\n";
echo "Post data:\n";
print_r($_POST);
echo "\nGet data:\n";
print_r($_GET);
echo "</pre>\n";

[rrohljr]

Post data:
Array
(
[Character_Alias] => Shankinyou
[Character_Class] => Hunter
[Character_Level] => 70
[Character_Race] => Bloodelf
[$RealName] => Rikk
[Age] => 22
[Status] => Work
[MondayAvailability] => Open Availability
[TuesdayAvailability] => Open Availability
[WednesdayAvailability] => Open Availability
[ThursdayAvailability] => Open Availability
[SundayAvailability] => Open Availability
[EmailAddress] => [e-mail]
[MSNSN] => N/A
[AIMSN] => rikkindyt
[YSN] => N/A
[Profession1] => Leatherworking
[Profession1_Level] => 300
[Profession2] => Enchanting
[Profession2_Level] => 375
[Guild_History] => Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah
[Expectations] => Blah blah Blah blah Blah blah Blah blah Blah blah
[GearSummary] => Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah
[BCRaidExperience] => Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah
[Submit] => Submit Application
)

Get data:
Array
(
)

[NogDog]

[$RealName] => Rikk

Looks like you have a form field named "$RealName". Try removing that "$" from the that field's name attribute, and see if that helps.

[rrohljr]

Yeah I was fooling with it a bit to see if it'd fix the problem, but it didn't. Fixed, and here you go:

Post data:
Array
(
[Character_Alias] => Shankinyou
[Character_Class] => Hunter
[Character_Level] => 70
[Character_Race] => Bloodelf
[RealName] => Rikk
[Age] => 22
[Status] => Work
[MondayAvailability] => Open Availability
[TuesdayAvailability] => Open Availability
[WednesdayAvailability] => Open Availability
[ThursdayAvailability] => Open Availability
[SundayAvailability] => Open Availability
[EmailAddress] => [e-mail]
[MSNSN] => N/A
[AIMSN] => rikkindyt
[YSN] => N/A
[Profession1] => Leatherworking
[Profession1_Level] => 300
[Profession2] => Enchanting
[Profession2_Level] => 375
[Guild_History] => Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah
[Expectations] => Blah blah Blah blah Blah blah Blah blah Blah blah
[GearSummary] => Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah
[BCRaidExperience] => Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah Blah blah
[Submit] => Submit Application
)

Get data:
Array
(
)

You must enter your Real Name.

[NogDog]

Are you using the import_request_variables('p'); that I suggested above? Also, just to see if something else is causing the problem, you might want to make sure all error reporting is on:

<?php
ini_set('display_errors', 1);
error_reporting(E_ALL);
import_request_variables('p');
// rest of script......
?>

[rrohljr]

omg i love you. i did get an error though

Notice: import_request_variables() [function.import-request-variables]: No prefix specified - possible security hazard in /home/mediocra/public_html/modules/apply.php on line 37

line 37 is what you told me to run:

import_request_variables('p'); 

[NogDog]

You can suppress that notice with the @ operator:

@import_request_variables('p');

(Or just turn off display_errors once you're done debugging.)

[rrohljr]

yeah, got it all squared away and taken care of and everything works beautifully. thanks so very much, nog!

[NogDog]

w00t!

Don't forget to mark this thread Resolved (via the "Thread Tools" link at the top of the thread).

[rrohljr]

done. thanks again.