[RESOLVED] extending my code

[g5604]

Hi,

I have the following code, and it works great for a what i want to do, it takes the contents of one folder and generates an external xml file. Now i need to extend this so it will do this for x number of folders within a master folder. I want it all to be put into one xml file but I don`t know really where to start so can anyone help?

<?php

$imageDir = 'images/';
$extensions = array(".jpg", ".jpeg", ".JPG",".JPEG",".gif",".GIF",".swf",".SWF");

if ($folder = opendir($imageDir)) {

   $filenames=array();

	while (false !== ($file = readdir($folder)))) {

	$dot = strrchr($file, '');
    if(in_array($dot, $extensions)){
		array_push($filenames, $file);

	} 		
   }

   $output = "<?xml version=\"1.0\" encoding=\"utf-8\"?>";
   $output .= "<folder>";
   foreach ($filenames as $suurce) {
        $imageName = str_replace("_"," ",$source);
        $imageName = str_replace($extensions,"",$imageName);
        $output .= "\t<image src=\"$imageDir$source\">$imageName</image>\n";
   }
   $output .= "</folder>";



   $fp = fopen("gallery.xml", "w");
   fwrite($fp, $output);
   fclose($fp);

   }
?>

[leatherback]

Hi,

Untested and all, and I did not check your code for efficiency and stuff, but I am thinking something like this:

<?php

// Set a dir
$indir = 'SomeDir';

$files = opendir($indir);

$outxml = "<?xml version=\"1.0\" encoding=\"utf-8\"?>";

while ($file = readdir($files)) {
  {
  if(is_dir($folder))
    {
	$outxml .= get_folder_xml($folder);
	}
  }
$outxml .= "</xml>";

closedir($indir);  

$fp = fopen("gallery.xml", "w");
fwrite($fp, $output);
fclose($fp);




function get_folder_xml($imageDir)
  {
  $extensions = array(".jpg", ".jpeg", ".JPG",".JPEG",".gif",".GIF",".swf",".SWF");
  $output = "";

  if($folder = opendir($imageDir)) 
    {
    $filenames=array();

while (false !== ($file = readdir($folder))) 
  {
  $dot = strrchr($file, '.');
  if(in_array($dot, $extensions))
    {
    array_push($filenames, $file);
    }         
  }

$output .= "<folder>";
foreach ($filenames as $source) 
  {
  $imageName = str_replace("_"," ",$source);
  $imageName = str_replace($extensions,"",$imageName);
  $output .= "\t<image src=\"$imageDir$source\">$imageName</image>\n";
  }
$output .= "</folder>";

closedir($folder);   
}
  }
?>

[g5604]

thanks so much for your help with this.

i get:

Parse error: syntax error, unexpected $end in C:\wamp\www\gallery\buildXML_new.php on line 57

any ideas why?

[leatherback]

Yes. Incorrect bracketing on my side here:

while ($file = readdir($files)) {
{

Remove one of the double brackets.

[g5604]

thanks! good spot.

unfortunately i am now getting:

Warning: closedir(): supplied argument is not a valid Directory resource i

[leatherback]

Well... What do you think the problem might be ? (I mean: I know what went wrong in the code I sent you, but you should be able to pick up the problem, and solve it.

Have a look at the code, and the error, take a peek in the manual, and give it a shot.

[g5604]

well, i am a bit lost.

I know closeDir needs the directory stream parameter but isn't that just the var $indir?

thanks for you help, i am a total php noob.

[g5604]

ah should it be:

closedir($files); ?

that removes the error but none of the xml is written.

[leatherback]

😐 Me silly:

this:
$output .= "</folder>";

should be:
$output .= "</folder>";
return $output;

[g5604]

thanks, but still no xml is written.

was i right with closedir($files); ?

sorry for being a dumbass :-) and thanks again for your time

[leatherback]

Yes.. You were right with the closedir.

As for your current problem: You could have found this one too...

The output is written to anothe rvariable than used in the
fwrite($fp, $output); line.

I usually try to not change variable names when code gets longer, but in this case I warped the code so much that I forgot to replace all the variable names. Sorry.

[g5604]

ah i seen now, it should be:

fwrite($fp, $outxml);

but that just returns

<?xml version="1.0" encoding="utf-8"?></xml>

[g5604]

its seems this part of the code is not being fired, but i cant figure out why:

if(is_dir($folder))
{
$outxml .= get_folder_xml($folder);
}

[leatherback]

Hm.. I am not sure what you now have as most recent version. Could you pop it online? Also.. Just go through the code, and verify that the right variables are used, and echo out variables halfway through.

J

[g5604]

I think it might be because $file does not return a full path, but i don`t know how to make it..

heres my code now:

<?php

$indir = "photos";

$files = opendir($indir);

$outxml = "<?xml version=\"1.0\" encoding=\"utf-8\"?>";
while ($file = readdir($files)) {
echo $file;
  if(is_dir($folder))
    {
    $outxml .= get_folder_xml($folder);
    }
  }
$outxml .= "</xml>";

closedir($files);  

$fp = fopen("gallery.xml", "w");
fwrite($fp, $outxml);
fclose($fp);


function get_folder_xml($imageDir)
  {

  $extensions = array(".jpg", ".jpeg", ".JPG",".JPEG",".gif",".GIF",".swf",".SWF");
  $output = "";

  if($folder = opendir($imageDir))
    {
    $filenames=array();

while (false !== ($file = readdir($folder)))
  {
  $dot = strrchr($file, '.');
  if(in_array($dot, $extensions))
    {
    array_push($filenames, $file);
    }         
  }

$output .= "<folder>";
foreach ($filenames as $surce)
  {
  $imageName = str_replace("_"," ",$source);
  $imageName = str_replace($extensions,"",$imageName);
  $output .= "\t<image src=\"$imageDir$source\">$imageName</image>\n";
  }
   $output .= "</folder>";


closedir($folder);   
}
  }
?>

[leatherback]

so it does:

while ($file = readdir($files)) {
echo $indir.'/'.$file;
  if(is_dir($indir.'/'.$file))
    {
    $outxml .= get_folder_xml($indir.'/'.$file);
    }
  }

[g5604]

thanks so much :-)

its almost perfect now. The only problem is the file paths are not written correctly in the xml, but i think i can fix that. The only other thing is that this is added before
<?xml version="1.0" encoding="utf-8"?>

<folder></folder><folder></folder>

there are no empty folders, so not sure why that`s happening.

thanks again.
g

[leatherback]

The . and .. filenames are also included, I bet.

[g5604]

yep it returning:

photos/.photos/..photos/