[RESOLVED] Not Printing Results from Table

Warmaster

Hello,

 First thanks for the help! I am trying to learn how to use databases using MySQL. I have the database and table created, and the information is posting to the table, but I cannot get it to SELECT and print to the websites HTML table. Any help would be greatly appreciated. The entire project is three pages "guestbook.php, addguestbook.php, and viewguestbook.php" I did not include any of the code from the first two mentioned, only from viewguestbook.php as that is the only place I am having trouble. If you need a snippet from the others I will gladly produce. I have no errors being printed and it takes me to the viewguestbook.php page and shows the HTML table but does not show the data from the database table. Stumping to me but probably something simple.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
<head>
<title>View Guestbook</title>
</head>
<body>
<table width="400" border="0" align="center" cellpadding="3" cellspacing="0">
<tr>
<td><strong>View Guestbook | <a href="guestbook.php">Sign Guestbook</a> </strong></td>
</tr>
</table>
<br>
<?php 

//Removed all references to connecting to DB and connecting to table since those are functional.

$sql = sprintf("SELECT * FROM $tbl_name", mysql_real_escape_string ($name), mysql_real_escape_string ($email),
mysql_real_escape_string ($comment), mysql_real_escape_string ($datetime));

$result=mysql_query("$sql");

if (!$result) {
    $message  = 'Invalid query: ' . mysql_error() . "\n";
    $message .= 'Whole query: ' . $query;
    die($message);
}

while ($rows=mysql_fetch_array($result, MYSQL_ASSOC));{
?>
<table width="400" border="0" align="center" cellpadding="0" cellspacing="1" bgcolor="#CCCCCC">
<tr>
  <td><table width="400" border="0" cellpadding="3" cellspacing="1" bgcolor="#FFFFFF">
<tr>
  <td>ID</td>
  <td>:</td>
  <td><? printf($rows['id']); ?></td>
</tr>
<?php//Removed the rest of the table as it is redundant coding of the above TR
//remainder of php
<tr>
  <td valign="top">Date/Time </td>
  <td valign="top">:</td>
  <td><? printf($rows['datetime']); ?></td>
</tr>
</table></td>
</tr>
</table>
<BR>
<?php
}
mysql_free_result($result);
mysql_close(); //close the database
?>
?>

Thanks again!

       Warmaster

Kudose

Your query is invalid.

Print it out and you will see.

Warmaster

Ok, I changed my query to

$sql = 'SELECT * FROM guestbook ORDER BY datetime DESC';

Still to no avail. I went as simple as possible and still returns an empty table. I printed the $sql and it returned "SELECT * FROM guestbook ORDER BY datetime DESC"

Did I print the wrong thing? Thanks for the help 😉

Warmaster

HalfaBee

You need to remove the ; from this line

while ($rows=mysql_fetch_array($result, MYSQL_ASSOC));{

Warmaster

Well that was half the problem solved. I will play around with it some more (as I have been for six hours straight, it is all looking jumbled together now lol).

Removing the semi colon actually fixed a portion of the problem, I now have 13 empty html tables. The data is not being extracted from the MySQL table and printed to the html table, but it printed 13 tables to correspond with my 13 test posts to the guestbook.

Thanks HalfaBee

 Warmaster

bradgrafelman

You're using the function [man]printf/man, which doesn't simply print any string it's passed. Try using [man]print/man instead.

Also note that you should change the deprecated '<?' short tags to the full '<?php' tags.

Warmaster

thanks a lot brad, that was the trick. Guess I need to go read exactly what printf() is for. I just used the code for a query from php.net and figured it would work. Then again, that is why they call us beginners!

Warmaster