[RESOLVED] Can someone analyse my code and enhance it please...

endurox

I know their has to be a more efficient way to code what I have done below. I'm keeping it for now since there are only four links needed. But so I can better learn php can someone help me make it more efficient please. Thank you...

/////////////////////////////// GLOBAL.PHP FILE ///////////////////////////////////////
if($title == 'Welcome')  { $ext1 = '-bg'; } else { $ext1 = '-sm'; }
if($title == 'Services') { $ext2 = '-bg'; } else { $ext2 = '-sm'; }
if($title == 'About')    { $ext3 = '-bg'; } else { $ext3 = '-sm'; }
if($title == 'Contact')  { $ext4 = '-bg'; } else { $ext4 = '-sm'; }

$nav = '
<tr>
  <td><a href="index.php"><img src="images/home'.$ext1.'.jpg" alt="Home" /></a></td>
</tr>
<tr>
  <td><a href="services.php"><img src="images/services'.$ext2.'.jpg" alt="Services" /></a></td>
</tr>
<tr>
  <td><a href="about.php"><img src="images/about'.$ext3.'.jpg" alt="About" /></a></td>
</tr>
<tr>
  <td><a href="contact.php"><img src="images/contact'.$ext4.'.jpg" alt="Contact" /></a></td>
</tr>';

- - The '-bg' added shows a larger image, the '-sm' shows a smaller image. So for example when I'm on the home/welcome page the home button is large while the other images/links are small, until clicked on at which point it becomes larger and the others become small. Hope this isn't too confusing.

<!-- HOME PAGE : index.php -->
<?php
$title = "Welcome";
require('global.php');
?>

<html>
<body>
<table>
  <?php echo $nav; ?>
</table>
</body>
</html>

sneakyimp

This tiny bit of code is hardly worth optimizing. You have 4 variables and 4 conditional statements to set them.

endurox

I know, but I would still like to know how to optimize it because I plan on doing bigger sites eventually!

Basically I'm asking how to do it so that I can learn for the next time. Thank again for the prompt reply mate! 😃

sneakyimp

If you mean optimize it for speed, I don't think you can do it any faster.

I can appreciate that it's a lot of typing for very little action, though. Like if you had 100 images to deal with it would get tedious really fast. In that case, you should think about using an [man]array[/man] or two and looping through them.

endurox

Again thanks for the prompt reply, can your provide me with more information on using an array to accomplish what I originally asked?

Perhaps a switch statement???

NogDog

Something like this makes things a bit more modular, resulting in less repetition of code and making it easier to add/delete/change menu items:

$pages = array(
   array('Welcome', 'index', 'home', 'Home'),
   array('Services', 'services'),
   array('About', 'about'),
   array('Contact', 'contact')
);

foreach($pages as $page)
{
   printf(
      "<tr>\n  <td><a href='%s.php'><img src='images/%s%s.jpg' alt='%s' /></a></td>\n</tr>\n",
      $page[1],
      (isset($page[2])) ? $page[2] : $page[1],
      ($page[0] == $title) ? '-bg' : '-sm',
      (isset($page[3])) ? $page[3] : $page[0]
   );
}

endurox

THANK YOU