[RESOLVED] PHP Email HELP

Thikho

I am creating a simple helpdesk where people will send their trouble tickets and i want the email to be sent to the support 1 which i can do , but there are two specific categories which when selected i want the email to be send to a support 2 and not support 1

pls help me the code below its only sending to the support one but i want it to work in a way that when Feitware is selectected it only send to support 2

pls help

<?php
include("connection.php");
//Check for required fields from query.html
if (!$_POST[name]|!$_POST[email]|!$_POST[branch]|!$_POST[ext]|$_POST[category] == 'NS'|!$_POST[subject]|!$_POST[problem])

die('You did not fill in a required field');
// Define variables
$IP=$_SERVER['REMOTE_ADDR'];
//echo $IP;
$date=mktime(date(H),date(i),date(s),date(m),date(d),date(Y));
// Strip all HTML tags
$name=strip_tags($_POST[name]);
$email=strip_tags($_POST[email]);
$branch=strip_tags($_POST[branch]);
$ext=strip_tags($_POST[ext]);
$category=$_POST[category];
$subject=strip_tags($_POST[subject]);
$problem=strip_tags($_POST[problem]);
$status="3"; //3-Active,2-Busy,1-Approval,0-Closed
//Add the information to the users tables
$submit = "insert into query (name,email,branch,ext,date_add,category,subject,problem,status,ip)
          values ('$name','$email','$branch','$ext','$date','$category','$subject','$problem','$status','$IP')";
mysql_query($submit);

// Get ticket number
// Get ticket number
$search="select ticket from query where date_add='$date'";
$tic=mysql_fetch_array(mysql_query($search));
$msg="<html><head><title>Query logged</title></head>";
$msg.="<body><h3>Query logged</h3><table>";
$msg.="<tr><td><b>Ticket:</b></td> <td>$tic[ticket]</td></tr>";
$msg.="<tr><td><b>Name:</b></td> <td>$name</td></tr>";
$msg.="<tr><td><b>E-mail:</b></td> <td>$email</td></tr>";
$msg.="<tr><td><b>Branch:</b></td> <td>$branch</td></tr>";
$msg.="<tr><td><b>Extension:</b></td> <td>$ext</td></tr>";
$msg.="<tr><td><b>Category:</b></td> <td>$category</td></tr>";
$msg.="<tr><td><b>Subject:</b></td> <td>$subject</td></tr></table>";
$msg.="<br><b>Description:</b><br>";
$msg.="$problem";
$msg.="</body></html>";

if ($_POST[category] == 'Freightware'){

Header("Location:querylogged.php");
// E-mail function
require("mail/class.phpmailer.php");
require("mail/class.smtp.php");

$mail = new PHPMailer();
$mail->IsSMTP();
$mail->Host = "10.0.0.3";
$mail->From = "testmail@thikho.co.za";
$mail->FromName = "Thikho IT Helpdesk";
$mail->Sender = "\"Thikho IT Helpdesk\" ";
$mail->IsHTML(true);
//$mail->CharSet  = "iso-8859-1"; 
$mail->AddAddress($email);
$mail->AddAddress("testmail@gmail.com");
$mail->Subject = "New query - Ticket no. $tic[ticket]";
$mail->Body = $msg;
//$mail->AltBody = "Hi, \n\n A query has been logged \n\nregards, \n\n Thikho IT Helpdesk!";

if(!$mail->Send()) // Now we send the email and check if it was send or not.
{
   echo 'Message was not sent.';
   echo 'Mailer error: ' . $mail->ErrorInfo;
}
else
{
   echo 'Message has been sent 1.';
}


echo mysql_error();

}else{

// E-mail function
//require("mail/class.phpmailer.php");
//require("mail/class.smtp.php");

$mail = new PHPMailer();
$mail->IsSMTP();
$mail->Host = "10.0.0.3";
$mail->From = "testmail@thikho.co.za";
$mail->FromName = "Thikho IT Helpdesk";
$mail->Sender = "\"Thikho IT Helpdesk\" ";
$mail->IsHTML(true);
//$mail->CharSet  = "iso-8859-1"; 
$mail->AddAddress($email);
$mail->AddAddress("testmail@thikho.co.za");
$mail->Subject = "New query - Ticket no. $tic[ticket]";
$mail->Body = $msg;
//$mail->AltBody = "Hi, \n\n A query has been logged \n\nregards, \n\n Thikho IT Helpdesk!";

if(!$mail->Send()) // Now we send the email and check if it was send or not.
{
   echo 'Message was not sent 2.';
   echo 'Mailer error: ' . $mail->ErrorInfo;
}
else
{
   echo 'Message has been sent.';
}


echo mysql_error();

?>

leatherback

this:

Header("Location:querylogged.php");
Will move you awayfrom the current script, so the mailing is not performed. You should move it to the end of that { } section

compbry15

yea, aside from that misplaced header, I don't see anything that would cause the mail to only send to support1.

My only suggestion would be slightly cleaner programming style. For instance, since most of the calls on the $mail object are identical, you could set up the $mail object outside the logic, then just set the address and send within the logic. Also move the require statements outside the logic.

    require("mail/class.phpmailer.php");
    require("mail/class.smtp.php"); 

$mail = new PHPMailer();
$mail->IsSMTP();
$mail->Host = "10.0.0.3";
$mail->From = "testmail@thikho.co.za";
$mail->FromName = "Thikho IT Helpdesk";
$mail->Sender = "\"Thikho IT Helpdesk\" ";
$mail->IsHTML(true);
//$mail->CharSet  = "iso-8859-1";
$mail->AddAddress($email);
$mail->Subject = "New query - Ticket no. $tic[ticket]";
$mail->Body = $msg;

   if ( Freightware ) {
         $mail->AddAddress("testmail@gmail.com");
    } else {
          $mail->AddAddress("testmail@thikho.co.za");
    }

//$mail->Send and error checking

Something like that seems much cleaner to me.

Thikho

Hi All

Going back to Leatherbacks reply i have tried to move the Header() to the end of the {} it give me an error headers already sent out , and i dont have any white spaces.

Compbry15 i am a newbie in PHP and i would like to learn to code in a neater way , I have tried your method above it works and send to different people but i have put the code in this way but i want to move the header to the rite place and my require statements pld help me with that

<?php
	include("connection.php");
	//Check for required fields from query.html
	if (!$_POST[name]|!$_POST[email]|!$_POST[branch]|!$_POST[ext]|$_POST[category] == 'NS'|!$_POST[subject]|!$_POST[problem])

	die('You did not fill in a required field');
// Define variables
$IP=$_SERVER['REMOTE_ADDR'];
//echo $IP;
$date=mktime(date(H),date(i),date(s),date(m),date(d),date(Y));
// Strip all HTML tags
$name=strip_tags($_POST[name]);
$email=strip_tags($_POST[email]);
$branch=strip_tags($_POST[branch]);
$ext=strip_tags($_POST[ext]);
$category=$_POST[category];
$subject=strip_tags($_POST[subject]);
$problem=strip_tags($_POST[problem]);
$status="3"; //3-Active,2-Busy,1-Approval,0-Closed
//Add the information to the users tables
$submit = "insert into query (name,email,branch,ext,date_add,category,subject,problem,status,ip)
	values ('$name','$email','$branch','$ext','$date','$category','$subject','$problem','$status','$IP')";
mysql_query($submit);

// Get ticket number
$search="select ticket from query where date_add='$date'";
$tic=mysql_fetch_array(mysql_query($search));
$msg="<html><head><title>Query logged</title></head>";
$msg.="<body><h3>Query logged</h3><table>";
$msg.="<tr><td><b>Ticket:</b></td> <td>$tic[ticket]</td></tr>";
$msg.="<tr><td><b>Name:</b></td> <td>$name</td></tr>";
$msg.="<tr><td><b>E-mail:</b></td> <td>$email</td></tr>";
$msg.="<tr><td><b>Branch:</b></td> <td>$branch</td></tr>";
$msg.="<tr><td><b>Extension:</b></td> <td>$ext</td></tr>";
$msg.="<tr><td><b>Category:</b></td> <td>$category</td></tr>";
$msg.="<tr><td><b>Subject:</b></td> <td>$subject</td></tr></table>";
$msg.="<br><b>Description:</b><br>";
$msg.="$problem";
$msg.="</body></html>";

Header("Location:querylogged.php");

// E-mail function
require("mail/class.phpmailer.php");
require("mail/class.smtp.php");

$mail = new PHPMailer();
$mail->IsSMTP();
$mail->Host = "10.0.0.3";
$mail->FromName = "Thikho IT Helpdesk";
$mail->Sender = "\"Thikho IT Helpdesk\" ";
$mail->IsHTML(true); 
$mail->AddAddress($email);
$mail->Subject = "New query - Ticket no. $tic[ticket]";
$mail->Body = $msg;


if ($_POST[category] == 'FW'){
	$mail->AddAddress("support1@webmail.co.za");
} else {
	$mail->AddAddress("support2@webmail.co.za");
}

	//$mail->Send and error checking 

if(!$mail->Send()) // Now we send the email and check if it was send or not.
{
echo 'Message was not sent.';
echo 'Mailer error: ' . $mail->ErrorInfo;
}
else
{
echo 'Message has been sent.';
}

echo mysql_error();

?>

sarahrtan

i guess u should place the header in:
if(!$mail->Send()) // Now we send the email and check if it was send or not.
{
echo 'Message was not sent.';
echo 'Mailer error: ' . $mail->ErrorInfo;
}
like:
if(!$mail->Send()) // Now we send the email and check if it was send or not.
{
echo 'Message was not sent.';
echo 'Mailer error: ' . $mail->ErrorInfo;
Header("Location:querylogged.php");
}

just a guess.

Thikho

it echos Message has been sent it does not go back to the addquery page and after the echo 'Message was not sent.'; it show this error

Message has been sent.
Warning: Cannot modify header information - headers already sent by (output started at /var/www/test/IT/help/add_ticket.php:73) in /var/www/test/IT/help/add_ticket.php on line 74

sarahrtan

im sorry
shoul be this one:
else
{
echo 'Message has been sent.';
Header("Location:querylogged.php");
}

also check if you anly have one header address in your syntax. you should have only one.

Thikho

I have one header in my class Sarahrtan it still show me the headers already sent out error i have treid moving it round and inside the {
} and outside but still dont work , it add the new query to the db and send emails but it does not direct the page to addquery it shows the error message

sarahrtan

try using header("Location:") with complete url. example, header("Location:http://localhost//querylogged.php")

leatherback

You cannot use header() commands when output has been produced. As per definition: The header is the header information of the page, kinda like an envelope. Once you have started to write your letter there is no option to add a heading to your letter.

Also.. Why do you want to use headers to move to another page if you are already producing the message here!?

If you do want the user to go somewhere else, use the HTML meta-refresh tags

Thikho

I wanted to show a message that will show that the query has been logged successfully and it show some links to go add new one view ticktes added , so let me google but all the example i saw it used the the Header method to go back maybe im using it in the wrong way

leatherback

what do you need the header() for then?

Thikho

In my code here i was redirecting it to the page querylogged.php , Leatherback I dont want my message to be echoed on the same page im adding my query i want the message to be displayed in the new page and the $msg to be send via email.

leatherback

well.. then don't echo the message 😃

I think you can safely send an email and then move to another page. If you set a $_SESSION variable with the success status, you can in the next page verify the success, and echo out whatever message required.
You just canoot output anything before a header() command. And if you move location, nothing will be output after the header(location🙂 command

compbry15

If it is something that will be used throughout the script/page, it is usually best to just put all your includes/requires at the top of the page.

If it were a huge file/class you were including, and it would only be used on a limited basis, then you could move it into an IF block to reduce overhead.

But, in your situation I would all the includes at the top of the page.

As for the putting output on another page, like leatherback said, you can just not echo any messages on the current page.

if ($mail->Send()) {
header(blah);
} else {
}

You could even, if you wanted, send some variable to the redirected page to decide what ouput to do ... i.e.

Header("Location:querylogged.php?status=success");
Header("Location:querylogged.php?status=failure");

Then on querylogged.php, display the necessary success/error messages.

The only way the Header function will work in your script below is if no output has been printed at the time of printing the header.

Thikho

tnks i understand you now i will make some changes and get back to u guys tnks a lot

seisei

i found an article that may be useful to your problem. this is the common cause of header was already sent problem. here is the url...
http://phpsense.com/php/php-sessions-errors.html

Thikho

thank you seisei

seisei

no prob thikho! hope that helps!