Bad Function?

DizzyD

This is a simple function that is getting the category name and id from the db.

function Get_all_cats()
{

$query = "SELECT * FROM cats ORDER BY id DESC";

$result = mysql_query($query) OR DIE ("Unable to get comments!");


where($row = mysql_fetch_array($result)) {

	?><option value="<?php echo $row['id']; ?>"><?php echo $row['cat_name']; ?></option>
	<?php
}
}

I want to be able to use this to create a drop down in the form to choose the category for a blog post. However this function has an error somewhere as it's causing a white screen. Am I missing it? Thanks for any help

Also how would i return this if it's a loop?

NogDog

You misspelled "while" as "where".

leatherback

Hm.. Could be that this:
where(
should be :
while(

Also, you do not need to open and lose php all the time:

function Get_all_cats()
{

$query = "SELECT * FROM cats ORDER BY id DESC";

$result = mysql_query($query) OR DIE ("Unable to get comments!");


while($row = mysql_fetch_array($result)) {
     echo "option value=\"".$row['id']."\">".$row['cat_name']."</option>";
}
}

Also.. Do you connect to the database to do this somewhere?

DizzyD

Thanks, I just saw the misspelling. The page loads now but the values are not returned. How would i return this eventhough it's a loop? I planned on doing the following:

Category:<select name="cat_name"><?php Get_all_cats(); ?></select><br>

Thanks for the prompt help guys!!

DizzyD

actually nvm, i got it working no problem... Thanks again guys for the help