[RESOLVED] too many IF statements!?

[MitchEvans]

Hi,

I have a database with 50 fields the first being the table id and the other 49 numbered 1 to 49.

In these numbered fields can be 3 different integers either a 0,1 or 2.

0=NA
1=Pass
2=Fail

I want to echo the results of the tables so instead of echoing "0" I want it to echo "NA".

I am currently carrying out three IFS like below, but this would be a massive page of php if I had to do it for every field numbered 1 to 49.

$el1 = $auditRow["1"];
IF ($el1=='0'){	$el1='N/A';	}
IF ($el1=='1'){	$el1='Pass';	}
IF (substr($el1,0,1)=='2'){	$el1='Fail';	}

Hope you can help!?

Thanks for looking

[TheVestel]

Here's my solution:

<?
$i = 1;
$auditRow["1"] = 0;
$auditRow["2"] = 1;
while ($i <= 2) {
if($auditRow["".$i++.""] == 0){
echo 'N/A<br>';
}elseif($auditRow["".$i++.""] == 1){
echo 'Pass<br>';
}else{
echo 'Fail<br>';
}
}
?>

[MitchEvans]

Thanks for replying,

I am currently echoing my results as so:

$el1 = $auditRow["1"];
through to
$el49 = $auditRow["49"];

echo"$el1,$el2,$el3......$el49";

So how would I get your solution worlking for this?

Thanks a lot!

[TheVestel]

So you want to select them from a database? If I'm correct:

• Edit all $el1 variables and change them into $auditRow["1"], $auditRow["2"], etc.
• just add the following line to the PHP script:

<?
$i = 1;
$auditRow["1"] = MYSQL_QUERY_THING; // Put your Mysql_Query here ^ ^
while ($i <= 2) {
if($auditRow["".$i++.""] == 0){
echo 'N/A<br>';
}elseif($auditRow["".$i++.""] == 1){
echo 'Pass<br>';
}else{
echo 'Fail<br>';
}
}
?> 

[MitchEvans]

This comes back to my original problem of a really long php page with lots of repeated code im afraid.

like so:

$el1 = $auditRow["1"];
IF ($el1=='0'){	$el1='N/A';	}
IF ($el1=='1'){	$el1='Pass';	}
IF (substr($el1,0,1)=='2'){	$el1='Fail';

I would like to ideally have one if statemnet that would change all of the variables!?!

[TheVestel]

Wait a moment... 😉

[TheVestel]

<?
// Make sure you are connected to a database
$i = 1;
while ($i <= 4):
$var[''$i++''] = "SELECT number FROM numbers WHERE id='".$i++."'"; // Please edit the table and the row ;)
if(mysql_result($var[''$i++''], 0) == 0){
echo "N/A";
}elseif(mysql_result($var[''$i++''], 0) == 1){
echo 'Pas';
}else{
echo 'Fail';
}
    $i++;
endwhile;
?> 

[MitchEvans]

thanks for that i'll see if I can it working!

If anyone has any other ideas in the meantime that would great thanks

🙂

[laserlight]

For starters, it sounds like your database is not normalised. Instead of having numbered columns, it would be more typical to have rows in another table.

But anyway, the make-shift solution is along the lines of:

while ($row = $result->fetch()) {
    echo 'Record #' . $row['id'] . "<br />\n";
    for ($i = 1; $i <= 49; ++$i) {
        echo 'Entry #' . $i . ': ';
        switch ($row[$i]) {
        case 0:
            echo 'NA';
            break;
        case 1:
            echo 'Pass';
            break;
        case 2:
            echo 'Fail';
            break;
        }
        echo "<br />\n";
    }
    echo "<br />\n";
}

[NogDog]

You could use an array for the number-to-string relationship and a foreach loop to cycle through each result:

$resultArray = array(0 => 'N/A', 1 => 'Pass', 2 => 'Fail');
foreach($auditRow as $nbr => $value)
{
   echo $nbr . ': ' . $resultArray($value) . "<br />\n";
}