[RESOLVED] Preg_match_all where pattern can be different?

psunshine

Hi,

I posted this in newbies section but maybe it is better asked here.

I have a list of items each on newlines that can look like this:

<item><1>abc123</1><2>abc123</2><3>abc123</3><4>abc123</4></item>
<item><1>abc123</1><3>abc123</3><5>abc123</5><6>abc123</6></item>
<item><1>abc123</1><6>abc123</6><2>abc123</2><3>abc123</3></item>

I have used preg_match_all before to return the details between each tag as an array which can then be inserted to database, but that has always been where the pattern in item follows the same structure for each line

if (preg_match_all('/<item><1>(.+)</1><2>(.+)</2><3>(.+)</3><4>(.+)</4></item>/mi', $result, $matches))

where $result looks like this:

<item><1>abc123</1><2>abc123</2><3>abc123</3><4>abc123</4></item>
<item><1>abc123</1><2>abc123</2><3>abc123</3><4>abc123</4></item>
<item><1>abc123</1><2>abc123</2><3>abc123</3><4>abc123</4></item>

So how do I acheive the same when the pattern may or may not contain a certain pattern without missing any pattern? On the same note, is it possible to get $matches to return "none" for the lines which dont contain a pattern for a specific part of the item?

Thanks
Pat

sneakyimp

replace all of the <1> and </1> with <\d> and </\d>

mmilano

you're probably not getting responses because you're not explaining what you want to achieve very clearly. i got lost in the may or may not contain a certain pattern without missing any pattern part. 🙂

have you considered SimpleXML ? Seems like it would be more useful than regex for XML.

You could load the XML, then run a foreach on the items, then use ->children() to get all the data for an item.

sneakyimp

i tried SimpleXML and it chokes on the xml...something about a 'bad name' error.

<?
$xml = '<item><1>abc123</1><2>abc123</2><3>abc123</3><4>abc123</4></item>
<item><1>abc123</1><3>abc123</3><5>abc123</5><6>abc123</6></item>
<item><1>abc123</1><6>abc123</6><2>abc123</2><3>abc123</3></item>';


$xml = new SimpleXMLElement($xml);
print_r($xml);
?>

output has a bunch of errors like this:

Warning: SimpleXMLElement::__construct() [function.SimpleXMLElement---construct]: Entity: line 1: parser error : StartTag: invalid element name in /home/crs/public/chump.php on line 7

Warning: SimpleXMLElement::__construct() [function.SimpleXMLElement---construct]: <item><1>abc123</1><2>abc123</2><3>abc123</3><4>abc123</4></item> in /home/crs/public/chump.php on line 7

Warning: SimpleXMLElement::__construct() [function.SimpleXMLElement---construct]: ^ in /home/crs/public/chump.php on line 7

Warning: SimpleXMLElement::__construct() [function.SimpleXMLElement---construct]: Entity: line 1: parser error : expected '>' in /home/crs/public/chump.php on line 7

Warning: SimpleXMLElement::__construct() [function.SimpleXMLElement---construct]: <item><1>abc123</1><2>abc123</2><3>abc123</3><4>abc123</4></item> in /home/crs/public/chump.php on line 7

Warning: SimpleXMLElement::__construct() [function.SimpleXMLElement---construct]: ^ in /home/crs/public/chump.php on line 7

Warning: SimpleXMLElement::__construct() [function.SimpleXMLElement---construct]: Entity: line 1: parser error : Opening and ending tag mismatch: item line 1 and unparseable in /home/crs/public/chump.php on line 7

Warning: SimpleXMLElement::__construct() [function.SimpleXMLElement---construct]: <item><1>abc123</1><2>abc123</2><3>abc123</3><4>abc123</4></item> in /home/crs/public/chump.php on line 7

Warning: SimpleXMLElement::__construct() [function.SimpleXMLElement---construct]: ^ in /home/crs/public/chump.php on line 7

Warning: SimpleXMLElement::__construct() [function.SimpleXMLElement---construct]: Entity: line 1: parser error : Extra content at the end of the document in /home/crs/public/chump.php on line 7

Warning: SimpleXMLElement::__construct() [function.SimpleXMLElement---construct]: <item><1>abc123</1><2>abc123</2><3>abc123</3><4>abc123</4></item> in /home/crs/public/chump.php on line 7

Warning: SimpleXMLElement::__construct() [function.SimpleXMLElement---construct]: ^ in /home/crs/public/chump.php on line 7

Fatal error: Uncaught exception 'Exception' with message 'String could not be parsed as XML' in /home/crs/public/chump.php:7 Stack trace: #0 /home/crs/public/chump.php(7): SimpleXMLElement->__construct('<item><1>abc123...') #1 {main} thrown in /home/crs/public/chump.php on line 7

mmilano

ok, so 2 things.

<1> is invalid xml

also, your xml should be wrapped in a root node

so for the 1st issue, you can use preg_replace to replace <1> with <foo-1>, <2> with <foo-2> etc..

and second, just wrap the items in a root node.

?
$xml = '<root>';
$xml .= '<item><1>abc123</1><2>abc123</2><3>abc123</3><4>abc123</4></item>
<item><1>abc123</1><3>abc123</3><5>abc123</5><6>abc123</6></item>
<item><1>abc123</1><6>abc123</6><2>abc123</2><3>abc123</3></item>';
$xml .= '</root>';

// replace <1> and </1> with <foo-1> and </foo-1>
$xml = preg_replace('/\<(\/{0,1})([0-9]+)\>/', "<$1foo-$2>", $xml);

header('content-type: text/plain');
$xml = new SimpleXMLElement($xml);
print_r($xml);
?>

bradgrafelman

What's wrong with:

preg_match_all('@<\d+>(.*?)</\d+>@', $data);

mmilano

bradgrafelman wrote:
What's wrong with:
preg_match_all('@<\d+>(.*?)</\d+>@', $data);
?

huh? i don't see anyone saying there's anything wrong with that. there's many ways to skin a cat.

i suggested simplexml because it's xml, albeit not well formed xml. if we make it well formed though, then we have a library we can manipulate it with.

psunshine

Ok, so I got there in the end with help off lots of people. Thanks for all the pointers 🙂

Fully functioning data to array to mysql database 🙂

<?php
	$lines = array(
		'<item><1>abc1</1><2>abc2</2><3>abc3</3><4>abc4</4></item>',
		'<item><1>abc1</1><3>abc3</3><5>abc5</5><6>abc6</6></item>',
		'<item><1>abc1</1><6>abc6</6><2>abc2</2><3>abc3</3></item>'
	);
	$data = array();
	$num = 1;
	foreach ($lines as $line) {
		preg_match_all('%<(\d+)>(.+?)</\1>%', $line, $matches);
		foreach ($matches[1] as $key => $value) {
			$data[$num][$value] = $matches[2][$key];
		}
		++$num;
	}
	foreach ($data as &$line) {
		for ($key = 1; $key <= 6; $key++) {
			if (!array_key_exists($key, $line)) {
				$line[$key] = 'none';
			}
		}
	}

  $map = array(
        1 => 'field1name',
	2 => 'field2',
	3 => 'field3',
	4 => 'field4',
	5 => 'field5',
	6 => 'field6',

  );


  foreach($data as $row){

$dbname = "xxx";
$dbuser = "xxx";
$dbpass = "xxx";
$dbserver = "xxx";
$tablename = "mytable";

mysql_connect($dbserver, $dbuser, $dbpass) or die('Error connecting to mysql');
mysql_select_db($dbname);

$values = array();
foreach($map as $n => $key){
  if(isset($row[$n]))
    $values[$key] = mysql_real_escape_string($row[$n]);
}
$sql = "INSERT INTO `mytable` (`".implode("`,`",array_keys($values))."`) VALUES ('".implode("','",$values)."')";
mysql_query($sql) or die("Error: ".mysql_error());
  }
?>