[RESOLVED] image and thumbnails array sorting...

[nrg_alpha]

I would like some feedback on my code.

Just to be clear, it works perfectly. But what I am interested in knowing is what can be done
to make this segment of my site faster and more efficient..

The idea is simple.. have PHP go into a directory that contains full sized images and small companion thumbnails.
Sort them such that all thumbnail filenames are put into one array while the full sized filenames are
put into another array.

So inside this directory: illustrations/images/

I have:

illust01_thumbv2-0.gif
illust01v2-0.jpg

illust02_thumbv2-0.gif
illust02v2-0.jpg

illust03_thumbv2-0.gif
illust03v2-0.jpg

, etc...

Here is my code:

$dir = $_SERVER['DOCUMENT_ROOT'].'/illustrations/images/';
if(is_dir($dir)){ // test to see if folder exists
	$fullImageArray = array();
	$thumbnailArray = array();
	$thumbnailTotal = 0;
	$fullImageTotal = 0;
	$scanarray = scandir($dir);
	for($i=0; $i < count ($scanarray); $i++){
		if($scanarray[$i]!="." && $scanarray[$i]!=".."){
			if(is_file($dir . $scanarray[$i])){ // find out if this is a file
				if(ereg('_thumb', $scanarray[$i])){ // find only the thumbnail images
					$thumbnailArray[$thumbnailTotal] = $scanarray[$i];
					$thumbnailTotal++;
				} else {
					$fullImageArray[$fullImageTotal] = $scanarray[$i];
					$fullImageTotal++;
				}
			}
		}
	}
} else {
	echo "<p class=\"errorFont\">Error! Directory does not exist!</p>";
}

What can be done to improve on this? How can I reduce code overhead and speed-up / streamline this process?

Any suggestions would be appreciated.

Cheers,

NRG

*Edit: I am using PHP 5.2.6 (in case of suggested functions that require the latest version).

[HalfaBee]

You may be able to use preg_grep(), assuming you have the same file types.

$dir = $_SERVER['DOCUMENT_ROOT'].'/illustrations/images/';
if(is_dir($dir)){ // test to see if folder exists
    $fullImageArray = array();
    $thumbnailArray = array();
    $thumbnailTotal = 0;
    $fullImageTotal = 0;
    $scanarray = scandir($dir);

$thumbnailArray = preg_grep( "/jpg$/" , $scanarray );
$fullImageArray =  preg_grep( "/gif$/" , $scanarray );


} else {
    echo "<p class=\"errorFont\">Error! Directory does not exist!</p>";
} 

[Weedpacket]

[man]glob[/man] cures world hunger!

[NogDog]

Weedpacket wrote:

[man]glob[/man] cures world hunger!

One of my favorite functions both for its usefulness and its name. 🙂

[nrg_alpha]

HalfaBee wrote:

You may be able to use preg_grep(), assuming you have the same file types.

$dir = $_SERVER['DOCUMENT_ROOT'].'/illustrations/images/';
if(is_dir($dir)){ // test to see if folder exists
    $fullImageArray = array();
    $thumbnailArray = array();
    $thumbnailTotal = 0;
    $fullImageTotal = 0;
    $scanarray = scandir($dir);

$thumbnailArray = preg_grep( "/jpg$/" , $scanarray );
$fullImageArray =  preg_grep( "/gif$/" , $scanarray );


} else {
    echo "<p class=\"errorFont\">Error! Directory does not exist!</p>";
} 

Hey, HalfaBee... thanks for the response.
I tried integrating your version, but it only half worked.. not all of the thumbnails were being generated (about half were missing for some reason). But it is certainly appreciated. Now that I think of it, I should have viewed source to see what exactly was going on under the hood.

Again though, thank you for your offerings. I was not aware of preg_grep (I'm not aware of many functions these days.

Cheers,

NRG

[nrg_alpha]

Weedpacket wrote:

[man]glob[/man] cures world hunger!

Weedpacket.. with your ever cyptic solutions...

I mucked around with glob().. and I did get it working..

Here is what I came up with:

$dir = $_SERVER['DOCUMENT_ROOT'].'/illustrations/images/';
if(is_dir($dir)){ // test to see if folder exists
	$fullImageArray = array();
	$thumbnailArray = array();
            $thumbnailTotal = 0;
            $fullImageTotal = 0;

foreach (glob($dir."*.gif") as $filename){
	$thumbnailArray[$thumbnailTotal] = pathinfo($filename);
	$thumbnailArray[$thumbnailTotal] = $thumbnailArray[$thumbnailTotal]['basename'];
	$thumbnailTotal++;
}
foreach (glob($dir."*.jpg") as $filename){
	$fullImageArray[$fullImageTotal] = pathinfo($filename);
	$fullImageArray[$fullImageTotal] = $fullImageArray[$fullImageTotal]['basename'];
	$fullImageTotal++;
}
} else {
    echo "<p class=\"errorFont\">Error! Directory does not exist!</p>";
}

I'm not sure if this is what you had in mind. It seems as fast as my solution (not sure if it is actually quicker or not).

If this is not the solution you were thinking of.. please endulge me. (don't mind the pathinfo / ['basename'] stuff. I need to ultimately extract this info..

I do have one question though.. is it necessary to really declare variables before using them? For example, I have the following snippet in the code above:

$fullImageArray = array();
$thumbnailArray = array();
$thumbnailTotal = 0;
$fullImageTotal = 0;

Is there benefits to setting up variables prior to utilising them? Or is it better to simply leave these declarations out for the sake of code brevity?

Cheers,

NRG

[NogDog]

In general, I know of no benefit to initializing variables in terms of functionality except one: if you are going to append to them later such as via $array[] = 'some value' or $string .= 'append this to the string'. Explicitly initializing them wth the correct type can help avoid problems should something cause them to be defined earlier (in particular via the dreaded register_globals or functions like extract() or import_request_variables().

The non-functional benefit is that you can use such "declarations" to have all variables of interest in one place in the code with applicable comments, helping you understand what each variable represents when you come back to the code a year later to update it. Of course, if you get into OOP you'll find yourself doing that sort of thing automatically with all your class variables. 🙂

[nrg_alpha]

NogDog wrote:

In general, I know of no benefit to initializing variables in terms of functionality except one: if you are going to append to them later such as via $array[] = 'some value' or $string .= 'append this to the string'. Explicitly initializing them wth the correct type can help avoid problems should something cause them to be defined earlier (in particular via the dreaded register_globals or functions like extract() or import_request_variables().

The non-functional benefit is that you can use such "declarations" to have all variables of interest in one place in the code with applicable comments, helping you understand what each variable represents when you come back to the code a year later to update it. Of course, if you get into OOP you'll find yourself doing that sort of thing automatically with all your class variables. 🙂

Hey Nog.. thanks for the heads up. To be specific, no, there is no appending going on... The only thing I initially thought of is what you mentioned in your last point..

declaring them for the sake of knowing which variables will come into play later in the code. I tend to list these variables.. say I need to return to this code months later.. having variables declared and initiallised would help me understand what is needed upfront to get things going.

So I suppose I will simply continue this practice, just for organizational sake.

Cheers,

NRG