[RESOLVED] PHP Syntax ESCALATION using php mailer

[Thikho]

Hi

I have a code which is using php mail to send emails but i want to change it to use php mailer , I want this piece of code to work like this when the the user click on closed query an email must be sent with a link and if the query is assigned or updated an email must be sent, the code below works perfectly

Can I have two php mailer function like in this code below where i am having two php mail????

pls help me with structuring here is my addresolved.php

<?php
include("connection.php");
// Check if tech is not set
if ($_POST[tech]=="")
{
  header("location: indexticket.php");
  die();
}

if ($_POST[priority]=="")
 $_POST[priority]=2;

// Is record in resolved table
$get="select date_started from resolved where ticket_query=$_POST[ticket]";
$set=mysql_query($get);
$result=mysql_num_rows($set);
$date=mktime(date(H),date(i),date(s),date(m),date(d),date(Y));
// Record exsists
if($result == 1)
{
  if ($_POST[status]==1)
    $date_f=$date;
  else
    $date_f="null";
  $sql="update resolved set date_finished=$date_f, tech_id=$_POST[tech],";
  $sql.=" tech_comment='$_POST[tech_comment]'";
  $sql.=" where ticket_query=$_POST[ticket]";
  mysql_query($sql);
  echo mysql_error();

}
// Record does not exsists
else
{
  $date_s=$date;   

  if ($_POST[status]==1)
    $date_f=$date;
  else
    $date_f="null";


  $sql="insert into resolved (ticket_query, tech_id, date_started, date_finished, tech_comment)";
  $sql.=" values ($_POST[ticket], $_POST[tech], $date_s, $date_f, '$_POST[tech_comment]')";
  mysql_query($sql);
  echo mysql_error();
}  

// Update the status in the query table
$sql="update query set status=$_POST[status], priority=$_POST[priority], category='$_POST[category]' where ticket=$_POST[ticket]";
mysql_query($sql);
echo mysql_error();

//send email to user if tech marks closed
if ($_POST[status]==1) {
//Get info on technician
$sql="select * from tech where tech_id=$_POST[tech]";
$get=mysql_query($sql);
$result=mysql_fetch_array($get);

// E-mail function
$tic=$_POST[ticket]*1024;
$headers="From: $_POST[useremail]\r\n";
$headers.="Bcc: [e-mail]\r\n";
$headers.="X-Priority: 1\r\n";
$to="$_POST[useremail]\r\n";
$sub="Close query - Ticket no. $_POST[ticket]";
$msg="Please review and close your query.\r\n";
$msg.="Goto http://10.0.0.7/helpdesk/approval.php?ticket=$tic and please comment on our service.";
mail("$to","$sub","$msg","$headers");
echo mysql_error();
}
else
{
//Get info on technician
$sql="select * from tech where tech_id=$_POST[tech]";
$get=mysql_query($sql);
$result=mysql_fetch_array($get);

// E-mail function
$tic=$_POST[ticket]*1024;
$headers="From: $_POST[useremail]\r\n";
$headers.="Bcc: [e-mail]\r\n";
$headers.="X-Priority: 1\r\n";
$to="$_POST[useremail]\r\n";
$sub="Update of query - Ticket no. $_POST[ticket]";
$msg="Update from technician.\r\n\n";
$msg.="$_POST[tech_comment]";
mail("$to","$sub","$msg","$headers");
echo mysql_error();
}

header("location: indexticket.php");
die();
?>

my new code llooks like this the message get sent but its show the header information has aleady been sent i cant seem to get the header error right and its really stressing me pls help me out

my new code below

<?php
include("connection.php");
require("class.phpmailer.php");
require("class.smtp.php");
// Check if tech is not set
if ($_POST[tech]=="")
{
  header("location: indexticket.php");
  die();
}

if ($_POST[priority]=="")
 $_POST[priority]=2;


// include("connection.php");
// Is record in resolved table
$get="select date_started from resolved where ticket_query=$_POST[ticket]";
$set=mysql_query($get);
$result=mysql_num_rows($set);
$date=mktime(date(H),date(i),date(s),date(m),date(d),date(Y));
// Record exsists
if($result == 1)
{
  if ($_POST[status]==1)
    $date_f=$date;
  else
    $date_f="null";
  $sql="update resolved set date_finished=$date_f, tech_id=$_POST[tech],";
  $sql.=" tech_comment='$_POST[tech_comment]'";
  $sql.=" where ticket_query=$_POST[ticket]";
  mysql_query($sql);
  echo mysql_error();

}
// Record does not exsists
else
{
  $date_s=$date;   

  if ($_POST[status]==1)
    $date_f=$date;
  else
    $date_f="null";
  $sql="insert into resolved (ticket_query, tech_id, date_started, date_finished, tech_comment)";
  $sql.=" values ($_POST[ticket], $_POST[tech], $date_s, $date_f, '$_POST[tech_comment]')";
  mysql_query($sql);
  echo mysql_error();
}  

// Update the status in the query table
$sql="update query set status=$_POST[status], priority=$_POST[priority], category='$_POST[category]' where ticket=$_POST[ticket]";
mysql_query($sql);
echo mysql_error();

//send email to user if tech marks closed
if ($_POST[status]==1) {
//Get info on technician
$sql="select * from tech where tech_id=$_POST[tech]";
$get=mysql_query($sql);
$result=mysql_fetch_array($get);

// E-mail function
$tic=$_POST[ticket]*1024;
$headers="From: $_POST[useremail]\r\n";
$headers.="Bcc: [e-mail]\r\n";
$headers.="X-Priority: 1\r\n";                         

$to="$_POST[useremail]\r\n";
$sub="Close query - Ticket no. $_POST[ticket]";
$msg="Please review and close your query.\r\n";
$msg.="Goto http://10.0.0.7/helpdesk/approval.php?ticket=$tic and please comment on our service.";
mail("$to","$sub","$msg","$headers");                                                                                                       

echo mysql_error();
}
else
{
//Get info on technician
$sql="select * from tech where tech_id=$_POST[tech]";
$get=mysql_query($sql);
$result=mysql_fetch_array($get);

// E-mail function
//$tic=$_POST[ticket]*1024;
$to="$_POST[useremail]\r\n";
$msg="Update of Query.\r\n\n";
$msg.="$_POST[tech_comment]";

$mail = new PHPMailer();
$mail->IsSMTP();
$mail->Host = "10.0.0.3";
$mail->FromName = "Thikho IT Helpdesk";
$mail->Sender = "\"Thikho IT Helpdesk\" ";
$mail->IsHTML(true); 
$mail->From = "From: $_POST[useremail]\r\n";
$mail->AddAddress($to);
$mail->Subject = "Update of query - Ticket no. $_POST[ticket]";
$mail->Body = $msg;


if ($_POST[category] == 'Freightware' || $_POST[category] == 'Freightware Printer'){
	$mail->AddAddress("[e-mail]");
} else {
	$mail->AddAddress("[e-mail]");
}

//$mail->Send and error checking 

if(!$mail->Send()) // Now we send the email and check if it was send or not.
{
echo 'Message was not sent.';
echo 'Mailer error: ' . $mail->ErrorInfo;
}
else
{
echo 'Message has been sent.';


}
echo mysql_error();
}

header("location: indexticket.php");
die();
?>

[bpat1434]

The [man]header/man call requires that NO output of any kind be done prior to it's call. So your "echo" lines are what's causing the issue.

There are two methods to solve this issue:

1.) Remove the echo lines and leave the header() line, or use [man]headers_sent/man to check to see if headers have already been sent prior to using [man]header/man.

OR

2.) Use a <meta> tag refresh to refresh the browser to a new URL.

Either way will work; although sometimes using a <meta> refresh is sometimes easier to manage because you don't have to worry about headers being sent; however, even if you display an error message you run the risk of moving them to a new page before they can fully read the error messages. Run the risk, but you can work around that 😉

[Thikho]

tnks in the case of sending two email is it possible to do have to email function in one file , i need clarity on that and how i can do it using php mailer

[bpat1434]

You can have as many phpMailer objects in one file as you deem necessary. What you can't do is say create a function with the same name:

/**
 * DO NOT DO THIS, WILL RESULT IN ERROR
 */

function sendEmail($to, $from, $subject, $body, $headers)
{
    // PHPMailer stuff here
}

function sendEmail($to, $from, $body, $subject, $headers)
{
    // PHPMailer stuff here
}

The above code will result in an error noting that there's already a function defined with that name "sendEmail". But you can make as many instances of phpMailer object as you please:

require('class.phpmailer.php');

$mail = new PHPMailer();
$mail2 = new PHPMailer();
$mail3 = new PHPMailer();
$mailn = new PHPMailer();

/* Set headers and other contents for the program here... */

$mail2->send();
$mail->send();
$mailn->send();
$mail3->send();
$mail1->send();

You can create as many instances as you like, they just have to be kept in different variables; otherwise, the old instance will be overwritten. If you're going to use it in an if()else{} statement, then you're fine to use the same variable "$mail". But if you want one to go to an admin, and another to the user, you'd be better off using $mail and $mail2.

[Thikho]

Thank you very much it is working perfectly 🙂