[RESOLVED] Echo Not Displaying Right

SamusKay

Hi
I have a problem with my script (below).
It doesnt show any errors but it displays this when I view it on my server.

SELECT * FROM products WHERE id = 1

I want it to execute the SQL.

				    <?php
// Include MySQL class
require_once('../../../shop/shop/cart/inc/mysql.class.php');
// Include database connection
require_once('../../../shop/shop/cart/inc/global.inc.php');
$cart = $row_Orders['ordered'];
if ($cart) {
		$items = explode(',',$cart);
		$contents = array();
		foreach ($items as $item) {
			$contents[$item] = (isset($contents[$item])) ? $contents[$item] + 1 : 1;
		}
		foreach ($contents as $id=>$qty) {
			$sql = 'SELECT * FROM products WHERE id = '.$id;
			$result = $db->query($sql);
			$row = $result->fetch();
			extract($row);
			echo $sql;
			}}
					?>

bradgrafelman

Well of course it's simply printing the SQL query... you told it to:

echo $sql;

What is PHP supposed to be outputting, if not the contents of the $sql variable?

illzz

As bradgrafelman said, your code is just printing out the SQL Query, not the results....

I'm assuming you want to print out the results from the query.

Use fetch()if you are using prepared statements, which you aren't in this example.

Try one of these:

<?php
foreach ($contents as $id=>$qty) {
    $sql = 'SELECT * FROM products WHERE id = '.$id;
    $result = $db->query($sql);
    $row = $result->fetch_array();
    extract($row);
    echo $columnName1;
    echo $columnName2;
    echo $columnName3;
}
?>

Or ...

<?php
foreach ($contents as $id=>$qty) {
    $sql = 'SELECT * FROM products WHERE id = '.$id;
    $result = $db->query($sql);
    $row = $result->fetch_array();
    echo $row['columnName1'];
    echo $row['columnName2'];
    echo $row['columnName3'];
}
?>

Or a number of others depending on your style and needs....

Note: It is typically a bad practice to use "SELECT *" in your queries.. instead, specify your column names in your query.

SamusKay

Thanks 🙂
How do I seperate the results. As it works out the product and just sticks them right next to each other for example:

Product1 Product2 will display as

Product1Product2 which can be confusing.

😕

illzz

That depends on how you want it displayed.

You can echo a space between each entry...
Or you can echo HTML tags to do your formatting...
Or you can do a number of other things...

SamusKay

Thanks. I'm sorted 🙂