undefined offset: 0 ??

ajcether

Okay so it seems to be one issue after another with this code...

This time it's a notice:
"Notice: Undefined offset: 0 in ..."
and is printed a bunch of times (once each time through the loop)

foreach($lines as $no => $line) {

	if (!$finish[0]) {
		break;
	}

		# Where the content starts
		if (strstr($line, $start[0])) { // line the notice refers to
			array_shift($start);
			$keep = true;
		}

		if ($keep) { ... }
}

So this code is supposed to find where the content begins in an html file (which is a page displaying a news article). After finding the beginning (which I don't think it does), it's supposed to alter things like links etc so that the article can be posted to a newsgroup. Currently, the content of the html file is being erased when the code runs, and a blank message is posted to the newsgroup instead of the article. I think this notice might be the problem since the alterations to the file depend on $keep being true.

Please don't suggest that I lower my error reporting settings, I would rather get suggestions that could help me in fixing the problem rather than hiding it.

Thanks a ton!

laserlight

This time it's a notice:
"Notice: Undefined offset: 0 in ..."

Basically, PHP is complaining that $start[0] does not exist because $start does not have an element with index 0.

Please don't suggest that I lower my error reporting settings, I would rather get suggestions that could help me in fixing the problem rather than hiding it.

Yes, I like your approach 🙂

ajcether

laserlight wrote:
Basically, PHP is complaining that $start[0] does not exist because $start does not have an element with index 0.

Ah alright, then I guess I'll sift through and see whats up with $start, thanks for the help again 🙂

laserlight wrote:
Yes, I like your approach 🙂

Yeah hehe well through all the results I found off Google for notices, I've always only seen people being told to lower their error reporting. In my opinion, if theres a notice, warning, or anything, then there's something not right with your code and you need to fix it 🙂

NogDog

Notice that it could also be the $finish[0] in the if condition.

Weedpacket

That's true. The elided line number would indicate which.

ajcether

Sorry forgot to show which line the notice referred to 😛

On another note....start[0] is clearly defined I think...I left out the declarations >.<:

$keep = false;

	$start = array();
	$finish = array();

	$start[0] = '<div class="headline_summary">';
	$finish[0] = '<div class="contact_summary">';

	$start[1] = '<div id="primarycontent">';
	$finish[1] = '<!-- InstanceEndRepeat -->';


	foreach($lines as $no => $line) {

	if (!$finish[0]) {
		break;
	}

		# Where the content starts
		if (strstr($line, $start[0])) { // Notice refers to this line
			array_shift($start);
			$keep = true;
		}

maybe am I supposed to escape that? lol I should really figure out this escaping strings thing >.<

laserlight

Sorry forgot to show which line the notice referred to 😛 Edited my first post to show it.

I think you edited it out by accident shortly after posting your code. I was going to berate you for not stating the line number, but then I noticed that you had it as a comment in your code, but apparently you removed that comment while I was reading it, only to put it back again just now.

Now you guys know why I was so certain that $start, not $finish, was the problem 🙂

ajcether

haha yeah I forgot to put it back in when I edited 🙂

NogDog

I suspect the cause is the array_shift() removing the last numerically indexed element from the $start array. Perhaps you need to [man]break[/man] out of the foreach loop once the array is emptied?

ajcether

How do I check if the array is empty? Would $start.empty() work?

ajcether

Okay so I just used isset to check that $start and $finish had something in the first position:

if (isset($start[0]) && strstr($line, $start[0])) {
	array_shift($start);
	$keep = true;
}

Bad news is, its still posting blank messages to the newsgroups and deleting all text in the files 🙁 I have no clue where to look now haha all the warnings and notices are gone...guess I'll have to read all the code >.<

Has anyone ever heard of messages being posted to a newsgroup all of a sudden posting blank messages instead of the text they're supposed to? (this was working up until a couple weeks ago then it just decided it didn't want to work anymore)

illzz

ajcether wrote:
How do I check if the array is empty? Would $start.empty() work?

right command, empty()... wrong usage...

To check if an variable is not empty:

<?php
if (!empty($var)) {
    // Do stuff
}
?>

Return Values

Returns FALSE if var has a non-empty and non-zero value.

The following things are considered to be empty:

* "" (an empty string)
* 0 (0 as an integer)
* "0" (0 as a string)
* NULL
* FALSE
* array() (an empty array)
* var $var; (a variable declared, but without a value in a class)